Comments about cm_SyncChangeDir changes in 11.02b4

English support forum

Moderators: white, Hacker, petermad, Stefan2

User avatar
wanderer
Power Member
Power Member
Posts: 1579
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Comments about cm_SyncChangeDir changes in 11.02b4

Post by *wanderer »

History.txt wrote:24.10.23 Added: cm_SyncChangeDir: Going up one level is now handled in a similar way to going down: If the names of the left and right directories are different, the function gets turned off or suspended just like when the clicked subdirectory doesn't exist on the other side (32/64)
24.10.23 Added: cm_SyncChangeDir: In button bar, show yellow pause icon overlayed over button while the function is suspended (32/64)
Well, my first impression when i saw the icon was that i dislike it. Perhaps the original icon should be left as is and just be filled with a yellow or orange color, or something similar.

Second, i'm not sure i like the "Going up one level is now handled in a similar way to going down". In many cases i have faced, the "up" folders have a different name (or it may be the same folder) but i wouldn't like SyncChangeDir to be suspended. Perhaps it would be better to have another flag to enable this functionality (or even better, another number in the existing flag).

EDIT: This comment was triggered by a test i did with this structure : https://imgur.com/a/70Hlrxa

I was in folders Folders\TestFolder1 and Links\TestFolder1 and going up suspended cm_SyncChangeDir. Perhaps in this case where the parent folders may have different names but have the same parent folder, cm_SyncChangeDir should not be suspended...
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
Fla$her
Power Member
Power Member
Posts: 2388
Joined: 2020-01-18, 04:03 UTC

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *Fla$her »

wanderer wrote: 2023-10-26, 07:24 UTC i'm not sure i like the "Going up one level is now handled in a similar way to going down". In many cases i have faced, the "up" folders have a different name (or it may be the same folder) but i wouldn't like SyncChangeDir to be suspended.
The discussion was conducted in this topic. No one wanted to join.
You write about your insecurities. And I am fully confident that behavior in both directions must be synchronous in terms of name similarity. And so it's implemented in other file managers, which is correct. The fact that the contents may be the same for different-name folders doesn't mean that this should have something to do with the synchronous change of directories. After all, in this case, it can be addressed not only to the exit from folders, but also to the entry into them. That is, you still need to compare the contents beforehand, which may coincide only partially. This is the wrong approach.
Overquoting is evil! 👎
User avatar
wanderer
Power Member
Power Member
Posts: 1579
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *wanderer »

Fla$her wrote: 2023-10-26, 07:54 UTCThe discussion was conducted in this topic. No one wanted to join.
Well, thanks for the reminder but was there a "Please join this thread" public announcement that i missed or denied to participate??? Some of us may scarcely participate in the forum nowadays and some features may have been formed in a certain way, but that doesn't mean that we can't express our opinion, even a little late in the discussion, right?
Fla$her wrote: 2023-10-26, 07:54 UTCYou write about your insecurities.
Nah, i feel pretty secure :). All i'm saying is that just like there's a flag for going downwards behavior, it might be a good idea to also have a flag for enabling going upwards behavior (but in this case enable/disable, not 0, 1, 2, 4). I'm also reporting a specific case in which IMO, it may be inconvenient to suspend Sync.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
Fla$her
Power Member
Power Member
Posts: 2388
Joined: 2020-01-18, 04:03 UTC

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *Fla$her »

wanderer wrote: 2023-10-26, 08:44 UTCbut was there a "Please join this thread" public announcement that i missed
The second message is in the topic with the author's appeal.
wanderer wrote: 2023-10-26, 08:44 UTCbut that doesn't mean that we can't express our opinion, even a little late in the discussion, right?
Does anyone forbid it? I gave a hint with the topic of discussion.
wanderer wrote: 2023-10-26, 08:44 UTCNah, i feel pretty secure :).
I didn't write anything about your personal secure. I wrote about the phrase "I'm not sure". ;)
wanderer wrote: 2023-10-26, 08:44 UTCAll i'm saying is that just like there's a flag for going downwards behavior, it might be a good idea to also have a flag for enabling going upwards behavior (but in this case enable/disable, not 0, 1, 2, 4). I'm also reporting a specific case in which IMO, it may be inconvenient to suspend Sync.
The suspension is used only with the flag 4. If you use only 1/3, then the change in the other panel will simply not work, as it should, but there will be no suspension.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48231
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *ghisler(Author) »

Well, my first impression when i saw the icon was that i dislike it. Perhaps the original icon should be left as is and just be filled with a yellow or orange color, or something similar.
I'm open to suggestions here. Just keep in mind that users can use alternate icon dlls, so have to use a method which works with older dlls without any special icon for the suspended state. I tried with a dimmed or gray icon, but that's difficult to notice with some icons. Maybe a smaller pause overlay in a corner would be better?
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2388
Joined: 2020-01-18, 04:03 UTC

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *Fla$her »

ghisler(Author) wrote: 2023-10-26, 09:50 UTC Maybe a smaller pause overlay in a corner would be better?
And could you draw a pause on top of the current icon of the pressed button so that it can be attached to other sets like wciconex.dll ?
Overquoting is evil! 👎
User avatar
wanderer
Power Member
Power Member
Posts: 1579
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *wanderer »

Fla$her wrote: 2023-10-26, 09:40 UTCThe second message is in the topic with the author's appeal.
Fla$her wrote: 2023-10-26, 09:40 UTCDoes anyone forbid it? I gave a hint with the topic of discussion.
:) OK, pass. Let's just say that they way you said what you said, i misunderstood your intentions.
Fla$her wrote: 2023-10-26, 09:40 UTCThe suspension is used only with the flag 4. If you use only 1/3, then the change in the other panel will simply not work, as it should, but there will be no suspension.
OK, so 4 could be only for the "down" direction and 8 could be for "up" and the user can use whatever combination he feels is convenient for him.
ghisler(Author) wrote: 2023-10-26, 09:50 UTCI'm open to suggestions here. Just keep in mind that users can use alternate icon dlls, so have to use a method which works with older dlls without any special icon for the suspended state. I tried with a dimmed or gray icon, but that's difficult to notice with some icons. Maybe a smaller pause overlay in a corner would be better?
!!! That yellow bars are supposed to be a "pause" overlay? Sorry, i didn't get it.

Well, i don't have much time to try things out ATM, but it might be better if the bars had another color (gray, black, navy blue, red - or perhaps gradient, from yellow to red?) but IMO they should be shorter, not take the whole height of the button.

Here's a very quick and crude attempt to demonstrate the "pause" bars. Size seems good, about the color, i'm guessing if it's something gradient, it could be more visible and might be usable in other cases too (if needed).
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
Fla$her
Power Member
Power Member
Posts: 2388
Joined: 2020-01-18, 04:03 UTC

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *Fla$her »

wanderer wrote: 2023-10-26, 11:23 UTCOK, so 4 could be only for the "down" direction
Not only. The behavior is also distinguished by the absence or presence of suspension for 1/3 and 5/7, respectively.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 14913
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *petermad »

See more about the pause icon overlay here: https://ghisler.ch/board/viewtopic.php?p=443660#p443660 and forward.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14913
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *petermad »

Fla$her wrote: 2023-10-26, 10:27 UTC And could you draw a pause on top of the current icon of the pressed button so that it can be attached to other sets like wciconex.dll ?
That is already how it is done - see: https://ghisler.ch/board/viewtopic.php?p=443635#p443635
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
wanderer
Power Member
Power Member
Posts: 1579
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *wanderer »

Fla$her wrote: 2023-10-26, 12:43 UTC
wanderer wrote: 2023-10-26, 11:23 UTCOK, so 4 could be only for the "down" direction
Not only. The behavior is also distinguished by the absence or presence of suspension for 1/3 and 5/7, respectively.
Well, yes, but instead of using 4 for both directions, 4 will be used for down (combined with 1 and 2) and 8 for up (again, combined with 1 and 2).
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
wanderer
Power Member
Power Member
Posts: 1579
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *wanderer »

petermad wrote: 2023-10-26, 13:16 UTC See more about the pause icon overlay here: https://ghisler.ch/board/viewtopic.php?p=443660#p443660 and forward.
Hmmm, i see you too have a problem with the size of the thing... :)
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
Fla$her
Power Member
Power Member
Posts: 2388
Joined: 2020-01-18, 04:03 UTC

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *Fla$her »

petermad wrote: 2023-10-26, 13:18 UTC That is already how it is done - see: https://ghisler.ch/board/viewtopic.php?p=443635#p443635
Understood. I'm in favor of a red pause with a dark shadow without a background in the bottom right corner of the icon.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48231
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *ghisler(Author) »

Red is traditionally used for STOP or Error, while yellow is often used for pause or warning, e.g.
- the color of the icon background in the task bar of Windows 10 while paused
- the yellow warning icon (exclamation mark) in TC
- STOP traffic signs are usually red
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2388
Joined: 2020-01-18, 04:03 UTC

Re: Comments about cm_SyncChangeDir changes in 11.02b4

Post by *Fla$her »

The problem with the yellow color is that it matches the color tone of the folders on the icon. When mixing colors of the same tone, a daub is obtained. The red one will be well legible. It's not necessary to focus special attention on the traditional use. However, I don't recall yellow pause icons in different applications. See:
DiagCpl.dll,3 (red)
mmcbase.dll,8 (blue)
ieframe.dll,77 (green, IE8)
prnfldr.dll,11 (green)
Overquoting is evil! 👎
Post Reply