[TC 10.52] Inconsistent behavior when quick view archives without plugins

Please report only one bug per message!

Moderators: Hacker, petermad, Stefan2, white

Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

[TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

1. If QuickViewUnzipReadMe=1 is set, then after Ctrl+Q, when pressing keys 2 or 3, the view will change not in relation to the archive, but in relation to the ReadMe, which is harmful when you need to look at the signature of the archive itself.

2. After pressing 4, the ReadMe viewing functionality in the current session in relation to the viewed file generally flies off.
In this way, I checked 3 dozen zip archives found. Only the one that had DIZ turned out to be trouble-free.

3. Please do with QuickViewUnzipReadMe=2 in such a way that when executing cm_SrcQuickInternalOnly, the same behavior as with cm_ListInternalOnly, i.e. Readme is not shown (see about the signature in p. 1).
Overquoting is evil! πŸ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48238
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *ghisler(Author) »

when pressing keys 2 or 3, the view will change not in relation to the archive
This only changes the view of the currently loaded file, which is the readme.
After pressing 4, the ReadMe viewing functionality in the current session in relation to the viewed file generally flies off.
Sorry, I don't understand what you mean. This works fine here with the plugins I have installed.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

ghisler(Author) wrote: ↑2023-04-24, 14:29 UTCThis only changes the view of the currently loaded file, which is the readme.
And that's bad. Can you fix this (possibly optional)?
ghisler(Author) wrote: ↑2023-04-24, 14:29 UTCSorry, I don't understand what you mean.
And what exactly is unclear?
1. The cursor on zip with ReadMe.txt .
2. Execute cm_SrcQuickInternalOnly and make sure that the ReadMe text is displayed in the other panel.
3. Press Tab, 4, Tab and Ctrl+Q.
4. Execute cm_SrcQuickInternalOnly again.
5. Now we see that the ReadMe is no longer displayed.
6. Do 1-4 with diz instead of txt and see that the ReadMe is expected to still be displayed.

TC x32 10.52

So what about the difference in the behavior of cm_SrcQuickInternalOnly and cm_ListInternalOnly? This is also important.
Overquoting is evil! πŸ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48238
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *ghisler(Author) »

And that's bad. Can you fix this (possibly optional)?
Why? The user may want to change to text mode, e.g. when a readme is just 1 line with no line break at the end (recognized as binary).
And what exactly is unclear?
I have followed your steps, but it does show the readme again here after step 4.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

2ghisler(Author)
1. It's too unlikely. Usually the user deals with already unpacked files.
2. If this is related to some plugin, can you fix it later? It will take me some time to find the source of the problem.
3. Why are you ignoring the question about the discrepancy in the work of cm_SrcQuickInternalOnly and cm_ListInternalOnly? This directly concerns inconsistent behavior.
Overquoting is evil! πŸ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48238
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *ghisler(Author) »

1. Sorry but the keys 1, 2 etc. only change the view, they never change what file is displayed.
2. I don't understand what you mean with it "flies off". When I press '4', the readme is shown with a plugin like cudalister, syn2 etc.
3. Currently the difference between cm_SrcQuickInternalOnly and cm_SrcQuickView is that the former always shows the readme with the internal viewer, while the second shows the readme also with plugins (on my system that would be cudalister). With your suggestion there would be no way to view the readme with the internal viewer, and no way to view the zip itself with a plugin.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

1. But why not control it optionally? For the archives themselves, this is much more necessary.
2. See p. 5. Yes, 4 switches to the plugin. Apparently, one of them affects the further behavior of TC itself without plugins. Perhaps some flag is set, which is why TC stops accessing the ReadMe files by signature. Moreover, this plugin is not in the list of those that display something (I checked them).
3. cm_SrcQuickView shows first what is associated with archives by extensions or signatures (arcview, Total7zip, eBookInfo, etc.). But that's not the point. It was necessary to clarify. I don't suggest using the value 2 to repeat the behavior similar to 0. I meant exactly what I wrote about in p, 1, i.e. only when pressing 2 or 3. There is also a need to make the behavior for cm_ListInternalOnly the same (with the addition of the ViewUnzipReadMe key with the same options, for example).
Overquoting is evil! πŸ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48238
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *ghisler(Author) »

1. I could indeed make it an option, just not the default (QuickViewUnzipReadMe=1)
2. Hmm, any idea what plugin that was?
3. QuickViewUnzipReadMe is controlling what is viewed (the readme or the zip), not how it is viewed. I could use QuickViewUnzipReadMe=2 for your complaint Nr. 1, though (QuickViewUnzipReadMe=2 would initially show the readme, any view change would then show the ZIP). What do you think?
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

1. Good.
2. Look at these: filter and inddview
3. Not sure if switching to zip for 5,6,7,8 can have any benefit.
Overquoting is evil! πŸ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48238
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *ghisler(Author) »

3. The same can be said for 1 and 2.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

2. Did you manage to reproduce the bug?
3. Why is that? We look, for example, at rar and see "Rar!" in front by 1, 2, 3.
I would prefer to use the keys 2,3,4 to switch the view for the archive, and everything else for the nested ReadMe.
Overquoting is evil! πŸ‘Ž
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

2ghisler(Author)
I would like some kind of reaction. When should be expect changes?
Overquoting is evil! πŸ‘Ž
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

Bump
Overquoting is evil! πŸ‘Ž
Fla$her
Power Member
Power Member
Posts: 2390
Joined: 2020-01-18, 04:03 UTC

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *Fla$her »

2ghisler(Author)
Please return to the described problems! It's very necessary to correct the current behavior.
TC 11.03 release is on the way, but nothing has been done. πŸ˜”
Overquoting is evil! πŸ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48238
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Inconsistent behavior when quick view archives without plugins

Post by *ghisler(Author) »

Sorry, I don't see what I would have to change. See my comments above.
Author of Total Commander
https://www.ghisler.com
Post Reply