Find duplicates - two issues

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
oko
Senior Member
Senior Member
Posts: 201
Joined: 2007-05-03, 16:22 UTC

Find duplicates - two issues

Post by *oko »

(EDITED) First turn to dark theme in tc if you do not use it (Configuration-Dark<>Normal).

create file: dir\abc\dfile.txt
create file: dir\rst\2file.txt
the 2 files must be the same, so you can copy dfile and rename to 2file.
Be in "dir" folder.
Find duplicates: Alt+F7 - Advanced - Find duplicate files - Same contents (NOT same name) - start search - feed to list.
Tc will find 2 files.
To select, press "+" key.
click "Select by folder" tab.
all two dirs are selected in the list.
click None to deselect.
write "abc" into "select folders by pattern" field.
click Select.
the "abc" folder will be selected.
click Ok.
the 2file.txt in rst folder is selected instead of file in abc folder. WHY?! The files in abc folder should be selected, not in rst folder!
It means risk of incorrect files will be selected resp. deleted afterwards !

***SECOND ISSUE
...go to folder dir\ as it was created in previous

Find duplicates: Alt+F7 - Advanced - Find duplicate files - Same contents - start search - feed to list.
Tc will find 2 files.
To select, press "+" key.
click "Select by folder" tab.
all two dirs are selected in list.
click None to deselect.
write "rst" into "select folders by pattern" field.
the "rst" folder will not be selected in list. WHY? directory "abc" in previous text was selected, but "rst" is not selected. Strange behaviour.

(EDITED)
***DISCOVERY
Try to turn theme to Normal and repeat steps above. What results do you get?

I find out the theme used causes the problem. If I use normal theme it works ok, dark theme is buggy (either of two issues is related to theme used).
It is SERIOUS BUG because incorrect resp. unwanted files are selected and probably deleted by user afterwards ! Please repair. As I have used dark mode I rather turn to normal mode until repaired.
Last edited by oko on 2024-01-07, 10:30 UTC, edited 2 times in total.
User avatar
Gral
Power Member
Power Member
Posts: 1467
Joined: 2005-01-26, 15:12 UTC

Re: Find duplicates - two issues

Post by *Gral »

I can't confirm such a behaviour - all works as expected.
Post more info - TC version and bitness, OS version and bitness.
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6496
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Find duplicates - two issues

Post by *Horst.Epp »

You have not set the option
"Also select all subfolders (manually and with pattern)"
Set it and it works
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
oko
Senior Member
Senior Member
Posts: 201
Joined: 2007-05-03, 16:22 UTC

Re: Find duplicates - two issues

Post by *oko »

Gral wrote: 2024-01-06, 17:52 UTC I can't confirm such a behaviour - all works as expected.
Post more info - TC version and bitness, OS version and bitness.
if you select "abc" folder in list of dialog window (not directly clicking on item in list, but by writing pattern in the field), does tc select "dfile.txt" in main window ? Me not. tc selects "2file.txt" .
It works bad here on win10 x64, tc 11.02 x64 and on win 8 too.
Last edited by oko on 2024-01-06, 20:46 UTC, edited 1 time in total.
oko
Senior Member
Senior Member
Posts: 201
Joined: 2007-05-03, 16:22 UTC

Re: Find duplicates - two issues

Post by *oko »

Horst.Epp wrote: 2024-01-06, 18:28 UTC You have not set the option
"Also select all subfolders (manually and with pattern)"
Set it and it works
Only for the second issue checking option allows select "rst" folder in list of dialog window by writing "rst" pattern. But why "abc" can be selected without checking option and "rst" not?
The first issue is not affected by checking option. Checked or unchecked, still the "2file.txt" is selected instead of "dfile.txt". It is wrong. Does tc select "dfile" for you?
oko
Senior Member
Senior Member
Posts: 201
Joined: 2007-05-03, 16:22 UTC

Re: Find duplicates - two issues

Post by *oko »

I tested in dialog window and realised that:
- if I click "None" and then I manually (not by writing in pattern field but directly clicking on item in list) click on item "abc" folder and then click Ok, the "dfile.txt" is selected (it is right behaviour). But if I select abc item by pattern, then the "2file.txt" is selected (it is wrong behaviour).
- if I click "None" and no items in list is selected, then I click Ok, the "2file.txt" is selected (wrong behaviour). But if I click manually on every item in list to deselect all items, then I click Ok, tc shows error message: "No folders selected" (right behaviour).

It seems like selection of folders in list in dialog is not interpreted right by tc and then incorrect files are selected in tc main window.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Find duplicates - two issues

Post by *petermad »

2oko
It works as expected here - see video: https://tcmd.madsenworld.dk/duplicatesselect.mp4 - or have I misunderstood something.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
oko
Senior Member
Senior Member
Posts: 201
Joined: 2007-05-03, 16:22 UTC

Re: Find duplicates - two issues

Post by *oko »

petermad, your video is exact.
I got it. The dark theme is problem. I use tc dark theme. If I turn to Normal theme, it works. If I turn back to dark theme it is buggy.
Try dark theme, what result do you get?
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Find duplicates - two issues

Post by *petermad »

2oko
I can confirm your report in dark mode.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Find duplicates - two issues

Post by *ghisler(Author) »

Thanks, I can confirm it for 64-bit dark mode only. It seems to happen due to a strange handling of selected files in the Lazarus library.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Find duplicates - two issues

Post by *petermad »

I can confirm that the problem is not preent in 32bit version.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Find duplicates - two issues

Post by *ghisler(Author) »

This should be fixed in Total Commander 11.03 RC1 64-bit (with dark mode), please check it!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Find duplicates - two issues

Post by *petermad »

history.txt wrote:09.01.24 Fixed: Selection dialog after searching for duplicate files and "feed to listbox": Selection not working correctly in dark mode (64)
confirmed fixed in TC 11.03rc1 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Find duplicates - two issues

Post by *ghisler(Author) »

Thanks!

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply