Start menu icon not showing if usercmd button is set with <iconlib>,<index>

[Stiltzkin]

for example:
any usercmd.ini em_ command

Code: Select all

button=test.ico

-> will be displayed in buttonbar and start menu

Code: Select all

button=shell32.dll,162

will display the icon in the buttonbar, but not the start menu
(same with *.icl or *.dll)

[ghisler(Author)]

This is actually intentional: Icons in the start menu are only shown if they are either
1. in an .ico file, or
2. in the wcmicons.dll (then it will be loaded from the currently chosen substitute if using an icon library)
This is done because menu icons are not cached, and loading them from arbitrary dlls and exe files is VERY slow with some virus scanners (up to several seconds per file). There is a button labeled "->.ico" in the dialog to extract the icon and put it in a .ico file for that purpose.

Button bar icons are cached in the .br2 files, but this means that changing the bar can be very slow, so I didn't use that approach for the menu.

[AntonyD]

2ghisler(Author)
And what rules are used to extract icons? In what format are they saved?
And in what format is the entry `button=<path_to-ICO>` pointing to the icon file supported?
I mean, icons in most cases are SETS of icons with different resolutions and a bit depths.
And that's how this fact is supported by the Total anywhere?

[nsp]

@AnthonyD to what i have seen:
the -> ico extract in the .ico file all the icons present at the specified index without any conversions.
If you have 2556x256, 128x128, 96x69, 48x48, 16x16 32bit you will get exactly those icon, no less no more.
If you only have 16 or 256 color alternative you will get what you have.
It is extraction not conversion.

[petermad]

This is actually intentional: Icons in the start menu are only shown if they are either
1. in an .ico file, or
2. in the wcmicons.dll (then it will be loaded from the currently chosen substitute if using an icon library)

There is a 3rd possibility:
3. in the main Total Commander executable, must be set to %COMMANDER_EXE% or the program name without path

[ghisler(Author)]

I will add shell32.dll as a 4th possibility, because shell32.dll is already loaded (to use its functions), so loading icons from it will also be fast. shell32.dll seems to be the only system dll used by Total Commander containing a significant amount of icons.

[petermad]

Whar about imageres.dll ?

[ghisler(Author)]

imageres.dll isn't actively used by Total Commander, and it doesn't seem to be loaded by default when launching Total Commander with a fresh wincmd.ini. But it might be useful to support anyway because it contains a lot of icons...

[Stiltzkin]

maybe the icon library from `[Configuration] IconLib=` could also be used?

[ghisler(Author)]

I have added support for shell32.dll or imageres.dll in 11.51 RC1, please try it!

Main menu and "Start" menu: Use icons defined in em_command also if they are located in shell32.dll or imageres.dll

[petermad]

Confirmed that Icons from shell32.dll and imageres.dll are now working in the menu in TC 11.51rc1

[sa16]

2petermad
in TC 11.51rc1

[petermad]

n TC 11.51rc1

Thanks - corrected previous post.

[ghisler(Author)]

Moderator message from: ghisler(Author) » 2025-01-19, 08:15 UTC

Moved to fixed bugs