7Zip Plugin Continued ...

[gora]

dllee
I added a file russian.lng, but the interface remains in English. How to enable Russian interface?

[dllee]

Total7zip doesn't "remove all attributes of the dir" =)
When you browse archive you can see that all attributes are reported to TC.

as far as I can remember the problem with dir attributes comes from TC itself.
when TC unpacks archive it creates all directories by itself and sets wrong attributes (or doesn't set them at all).

Yes, I have posted this bug on bug report.

I tried your new version, but it looks like it doesn't restore dir time. (or I didn't get it).
"reorder directory list" is set, I see how the plugin changes order, but when I extract from this archive I always get dirs with current time:

you have to check the setting

Configuration -> Copy/Delete -> [v] Copy date/time of directories

and then when you extract files/dirs via 7zip, you will have the same date/time of directory as it stored in archive file.

and one more - when you change order you don't clear time values, you change them only if they is set for new item. this can lead to bug.

I change the order of the dir items including their CreateTime, AccessTime, ModifyTime entries, so the TC will show the correct datetime info of the dir in 7zip. Is there something I missed?

[dllee]

dllee
I added a file russian.lng, but the interface remains in English. How to enable Russian interface?

From Readme.txt

Code: Select all

3. Translation
--------------
To use selected translation from lang/ copy it to 7zip.lng file into 7zip.wcx
installation folder.
Note for translators: On OS supporting unicode codepage= setting is crucial as
	translation strings are set using unicode SetWindowTextW(...).
	Also when sending the translation please translate "7-Zip archive support"
	for your language string in pluginst.inf.

So, you need to rename russian.lng to 7zip.lng, and put it to the directory of the 7zip plugins, then you will have your Russian translation when config 7zip.

[Total7zip]

Is there something I missed?

no, I checked it again - I was wrong, sorry. =)

Configuration -> Copy/Delete -> [v] Copy date/time of directories

hm... I turn this on and now it works.
but it works also with my Total7zip without any reordering tricks.

can you, please, give me test archive that doesn't work without reordering?[/code]

[gora]

2 dllee
Made the Russian language file and corrected the file pluginst.inf here:
Made a patch to fix display icons and little changed interface options: here
Now looks like this:
Image: http://gora.7zsfx.info/test/7-Zip.PNG

Image: http://gora.7zsfx.info/test/Pass.PNG

Maybe you will find it possible to fix this in the source?

Add:
In the options icon is displayed for the SFX archive, but it is not taken out of my chosen module. My module has a special icon, and displays the standard icon 7-Zip

[dllee]

hm... I turn this on and now it works.
but it works also with my Total7zip without any reordering tricks.

can you, please, give me test archive that doesn't work without reordering?

ROOT0401.7Z
the datetime of the root dir \ROOT0401 should be 2011-04-01 01:01

Using Total7zip or old 7zip, the datetime of the root dir
\ROOT0401 becomes to 2011-04-03 03:03

[Total7zip]

ROOT0401 time is 31.03.2011 21:01
all other times are right as well.

only dir attributes are missing (as I said before).

I use Total7zip 0.8.5.0, TC 7.56a

[dllee]

2 dllee
Made the Russian language file and corrected the file pluginst.inf here:

Thanks. Now, Russian translation adds to 7zip plugins 0.7.6.1

Made a patch to fix display icons and little changed interface options: here
Now looks like this:
Image: http://gora.7zsfx.info/test/7-Zip.PNG
Image: http://gora.7zsfx.info/test/Pass.PNG
Maybe you will find it possible to fix this in the source?

OK, I will fix the display icon on dialogs.
Can you tell me what "interface options" that you changed?

Add:
In the options icon is displayed for the SFX archive, but it is not taken out of my chosen module. My module has a special icon, and displays the standard icon 7-Zip

I have tested different .exe,.dll files for icons, they are all correct to display. Maybe your icon is too speical

[gora]

Can you tell me what "interface options" that you changed?

Compare files and see the changes

Maybe your icon is too speical

1 Create a SFX module with my icon (for example, 7zsd_LZMA2.sfx)
2 I chose this module (for example, 7zsd_LZMA2.sfx) in the "Options"
3 In the "Options" I see the standard icon 7-Zip, but not my icon from my module (for example, 7zsd_LZMA2.sfx).
If I did not choose an icon from another file (exe, dll, icon), I should always see the icon from the selected module in the "Options" (for example, 7zsd_LZMA2.sfx)

[dllee]

2Total7zip : If you have more sub-dir with sub-dir in 7z, the datetime of dir with sub-dir may be wrong. If you don't care about the datetime of dir, Total7zip and old 7zip are fine. Attribute of dir is another issue.


2gora : Icon of SFX is assigned by chick on the icon between [x] and SFX: during config 7zip. You can click on the old [7Z] icon and an icon selection dialog will popup, select your module, you will see your icon

[gora]

2dllee
You do not understand me.
What makes the button [x]? This button sets the icon of the selected module! (All other modules, I just deleted.) But into my module NO icon 7-Zip! Why do I see an icon that does not exist in my module?

[Total7zip]

2dllee
I cannot reproduce dir time bug with your archive...
Maybe you can give me another example?

[dllee]

2gora : maybe I do not understand your problem...
My test steps:
1. Click on the icon between [x] and SFX: , demo pic
2. Select file for icon, demo pic
3. icon update to your new selected icon for SFX. demo pic

2Total7zip : You can create for your own. Just create a root-dir, and then create sub-dir under the root-dir, set these two dir to different datetime, and then using 7z pack the root-dir.
You can create more sub-dir or sub-dir with sub-sub-dir, and set the different datetime for testing.
If your 7z archives contain only one layer of dir, the datetime will all be correct.
If your 7z archives contain more then two layers of dir, the datetime of upper layer dir will be error.

for testing ROOT0401.7Z using wcxtest(you can find it in 7zip source), and Total7zip 0.8.5.0

Code: Select all

r:\Total7zip>wcxtest.exe Total7zip.wcx ROOT0401.7z
 Length    YYYY/MM/DD HH:MM:SS   Attr   Name
---------  ---------- --------  ------  ------------
        2  2011/04/01 01:01:00  r----a  ROOT0401\R1.txt
        2  2011/04/01 01:01:00  -h---a  ROOT0401\R2.txt
        2  2011/04/01 01:01:00  rhs---  ROOT0401\R3.txt
        4  2011/04/02 02:02:00  r-----  ROOT0401\SUB10402\S1_1.txt
        4  2011/04/02 02:02:00  -h----  ROOT0401\SUB10402\S1_2.txt
        4  2011/04/02 02:02:00  --s---  ROOT0401\SUB10402\S1_3.txt
        4  2011/04/04 04:04:00  -----a  ROOT0401\SUB20404\S2_1.txt
        4  2011/04/04 04:04:00  r-----  ROOT0401\SUB20404\S2_2.txt
        4  2011/04/04 04:04:00  --s---  ROOT0401\SUB20404\S2_3.txt
        4  2011/04/03 03:03:00  -hs--a  ROOT0401\SUB30403\S3_1.txt
        4  2011/04/03 03:03:00  rhs--a  ROOT0401\SUB30403\S3_2.txt
        4  2011/04/03 03:03:00  rhs---  ROOT0401\SUB30403\S3_3.txt
        0  2011/04/03 03:03:00  -hs-d-  ROOT0401\SUB30403
        0  2011/04/04 04:04:00  -h--d-  ROOT0401\SUB20404
        0  2011/04/02 02:02:00  ----d-  ROOT0401\SUB10402
        0  2011/04/01 01:01:00  ----d-  ROOT0401

Total Commander will use the datetime of the first subdir in 7z archive

Code: Select all

        0  2011/04/03 03:03:00  -hs-d-  ROOT0401\SUB30403

as the datetime of the root dir ROOT0401.

this is my screen-shoot
in my system, I use 7zip for *.7z, and Total7zip for *.7zip,
so in this screen-shoot, left hand side is using Total7zip,
and the datetime of ROOT04001 is 2011/04/03 03:03:00,
but correct datetime should be 2011/04/01 01:01:00
as the right hand side 7zip result.

using wcxtest with 7zip 0.7.6.x 7zip.wcx and 7zip.ini

Code: Select all

r:\7zip>wcxtest 7zip.wcx ROOT0401.7z
 Length    YYYY/MM/DD HH:MM:SS   Attr   Name
---------  ---------- --------  ------  ------------
        2  2011/04/01 01:01:00  r----a  ROOT0401\R1.txt
        2  2011/04/01 01:01:00  -h---a  ROOT0401\R2.txt
        2  2011/04/01 01:01:00  rhs---  ROOT0401\R3.txt
        4  2011/04/02 02:02:00  r-----  ROOT0401\SUB10402\S1_1.txt
        4  2011/04/02 02:02:00  -h----  ROOT0401\SUB10402\S1_2.txt
        4  2011/04/02 02:02:00  --s---  ROOT0401\SUB10402\S1_3.txt
        4  2011/04/04 04:04:00  -----a  ROOT0401\SUB20404\S2_1.txt
        4  2011/04/04 04:04:00  r-----  ROOT0401\SUB20404\S2_2.txt
        4  2011/04/04 04:04:00  --s---  ROOT0401\SUB20404\S2_3.txt
        4  2011/04/03 03:03:00  -hs--a  ROOT0401\SUB30403\S3_1.txt
        4  2011/04/03 03:03:00  rhs--a  ROOT0401\SUB30403\S3_2.txt
        4  2011/04/03 03:03:00  rhs---  ROOT0401\SUB30403\S3_3.txt
        0  2011/04/01 01:01:00  ----d-  ROOT0401
        0  2011/04/02 02:02:00  ----d-  ROOT0401\SUB10402
        0  2011/04/04 04:04:00  -h--d-  ROOT0401\SUB20404
        0  2011/04/03 03:03:00  -hs-d-  ROOT0401\SUB30403

the root dir is at first directory list, so the datetime in Total Commander will be correct.

[Total7zip]

this is my screenshot
http://img62.imageshack.us/i/dater.png/
and I see exactly the same date as in archive

[dllee]

2Total7zip
I guess, you extract my ROOT0401.7Z and repack.

when you extract ROOT0401.7Z, you do not set

Configuration -> Copy/Delete -> [v] Copy date/time of directories

so, your all dir/sub-dir have the same datetime, the time that you extracted them.

since all dir and sub-dir have the same datetime, so you will not find this bug.

Please use 7zFM.exe(7z file manager) to open my ROOT0401.7Z, and check the datetime as it shows in Total7zip.