Page 3 of 5

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 07:58 UTC
by ghisler(Author)
I can change it, but the problem is that you can't use a backslash consistently when it's possible that the location is a drive root, e.g. on a USB flash drive.

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 09:38 UTC
by beb
ghisler(Author) wrote: 2024-01-19, 07:58 UTC ...problem is that you can't use a backslash consistently when it's possible that the location is a drive root...
Then the same will occur in case of the %COMMANDER_PATH%, won't it?
Nevertheless, %COMMANDER_PATH% does not include the terminal backslash.
So, regarding consistency, my vote goes, for one of the variables.
In other words, let them variables, %COMMANDER_PATH% and %COMMANDER_INI_PATH%, behave the same way.
Edit:
%COMMANDER_DRIVE% as well.

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 09:51 UTC
by ghisler(Author)
I will not change %COMMANDER_DRIVE% and %COMMANDER_PATH% because it would break existing configurations.

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 10:18 UTC
by JOUBE
ghisler(Author) wrote: 2024-01-19, 09:51 UTC I will not change %COMMANDER_DRIVE% and %COMMANDER_PATH% because it would break existing configurations.
Of course, that shouldn't change under any circumstances. But %COMMANDER_INI_PATH% should look like %COMMANDER_PATH% otherwise there will just be endless stress...

[edit]
ghisler(Author) wrote: 2024-01-19, 07:58 UTC I can change it, but the problem is that you can't use a backslash consistently when it's possible that the location is a drive root, e.g. on a USB flash drive.
"drive root" nobody does that
[/edit]

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 10:25 UTC
by beb
2ghisler(Author)
Lol. I didn't imply changing %COMMANDER_DRIVE%, %COMMANDER_PATH%.
On the contrary, my idea is that %COMMANDER_INI_PATH% dealing with a similar entity is expected to follow the syntax of the two.
I.e. %COMMANDER_INI_PATH% is one to be changed.

%COMMANDER_DRIVE%, %COMMANDER_PATH% are going without trailing backslash -- %COMMANDER_INI_PATH% should follow the conception (to go without trailing backslash).

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 11:14 UTC
by Dalai
JOUBE wrote: 2024-01-19, 10:18 UTC"drive root" nobody does that
Says who? You might not even realize that it's the drive root, e.g. in case of substituted drives (subst command) or a mapped network drive (net use command). Sure, it's probably (very) rare, but I don't think it's too far fetched to say that it will happen to someone eventually.

Nonetheless I vote for consistency with existing variables. Even if a drive root adds a backslash automatically I don't see that as a problem because a path like G:\\something is valid in Windows.

Regards
Dalai

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 11:40 UTC
by JOUBE
Dalai wrote: 2024-01-19, 11:14 UTCSure, it's probably (very) rare
And - additional - it is not a must to make use of this environnment var...


Dalai wrote: 2024-01-19, 11:14 UTCconsistency with existing variables.
That's the main point...

Joube

(K)I: nobody ≈ probably (very) rare ;-)

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 12:00 UTC
by Fla$her
JOUBE wrote: 2024-01-19, 10:18 UTC "drive root" nobody does that
%COMMANDER_EXE% /i=D:\my.ini
Why not?

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 18:07 UTC
by petermad
I agree that %COMMANDER_INI_PATH% should NOT end with a backslash - it is inconsistant with %COMMANDER_PATH%

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 20:35 UTC
by Fla$her
ghisler(Author) wrote: 2024-01-19, 07:58 UTC you can't use a backslash consistently when it's possible that the location is a drive root
And why can't? %COMMANDER_DRIVE% doesn't return "\". We can use %COMMANDER_DRIVE%\blabla. It's the same here.

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-19, 22:49 UTC
by JOUBE
Fla$her wrote: 2024-01-19, 20:35 UTC And why can't? %COMMANDER_DRIVE% doesn't return "\". We can use %COMMANDER_DRIVE%\blabla. It's the same here.
Finally this poster noticed it too...

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-20, 12:08 UTC
by Fla$her
JOUBE wrote: 2024-01-19, 22:49 UTC Finally this poster noticed it too...
I don't see this poster or anyone else noting this before. My question is posed differently...

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-23, 19:26 UTC
by JOUBE
Tc11.03RC2: Implemented. Perfect. Thanks.

Re: [Implemented in Tc11.03RC2] [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-23, 19:43 UTC
by Fla$her
21.01.24 Fixed: Removed trailing backslash from environment variable %COMMANDER_INI_PATH% (except in root) (32/64)
But why?
%COMMANDER_INI_PATH% = C:\TC
%COMMANDER_INI_PATH%\file.ext = C:\TC\file.exe ✅

%COMMANDER_INI_PATH% = D:\
%COMMANDER_INI_PATH%\file.ext = D:\\file.ext ⚠️

Re: [Implemented in Tc11.03RC2] [Tc11] Suggestion: COMMANDER_INI_PATH

Posted: 2024-01-23, 19:47 UTC
by JOUBE
Fla$her wrote: 2024-01-23, 19:43 UTC
21.01.24 Fixed: Removed trailing backslash from environment variable %COMMANDER_INI_PATH% (except in root) (32/64)
%COMMANDER_INI_PATH% = D:\
%COMMANDER_INI_PATH%\file.ext = D:\\file.ext ⚠️
Oh, not perfect for working with.

2ghisler(author)
It is true, has the root folder has really the name "letter:\" (other than all other folders). But in this case is "letter:" better for handling with the env var. Please change it.