CD-Ripper 1.2

Discuss and announce Total Commander plugins, addons and other useful tools here, both their usage and their development.

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

Another bug:
I've got a CD and I've downloaded descriptions from CDDB.
Unfortunately the titles was like here: "Artist / Title" - with "/" sing inside.
Trying to rip the track it's of course impossible to create the file with "/" in the name of it and plugin (and whole TC) crashes :-(. It shoud only say that it's impossible to create such a file and give me possibility to rename it.
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
User avatar
SCHMaster
Member
Member
Posts: 199
Joined: 2003-02-08, 00:39 UTC
Location: Ukraine
Contact:

Post by *SCHMaster »

2djk
Ok. Fixed in next update
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

BTW: Add "last modification date" to Translation files at your site. Just to know there is something new :-). You now, I'm waiting for corrected Polish translation :-)
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

Another bug: While you convert a file and during conversion you press "in background" - it starts to covert the file form the beginning :-(

I've written about the bug with "/" sing inside the file name. The same if you have "?" inside.

Request: There could be an option to display report after finished convertion. Why? Because if there was an error during conversion - the conversion just stops - just like after successful convertion so now I must check if there are really all files.
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
User avatar
SCHMaster
Member
Member
Posts: 199
Joined: 2003-02-08, 00:39 UTC
Location: Ukraine
Contact:

Post by *SCHMaster »

... it starts to covert the file form the beginning
Yes while this so. Possible in the future I this treason
I've written about the bug with "/" sing inside the file name.
Fixed in next update
Already soon
There could be an option to display report after finished convertion
Ok.
User avatar
SCHMaster
Member
Member
Posts: 199
Joined: 2003-02-08, 00:39 UTC
Location: Ukraine
Contact:

Post by *SCHMaster »

Now updated ...
CD-Ripper 1.6

[*] Digital reproduction CD-Audio
[+] Possibility CD drive ignore
[*] Small change and corrections[/b]

Download ALLFILES or PLUGINFILE only
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

Thanks for a new version :-)
Some bugs:
  • WMA settings - it still doesn't keep the bitrate (http://www.ghisler.ch/board/viewtopic.php?p=6709#6709). I mean, when I change the bitrate eg. to 192, press OK and run settings again, I still see 128 :-( but when I try to convert the files, the files are converted with 192 bitrate.
  • Let's suppose I have a file: track1.mp3 and convert it into track1.wma. So now I have to files: track1.mp3 and track1.wma.
    Now I again try to convert the mp3 file into wma and TC asks me:
    "Overwrite: \Convert\track1.mp3 -1 Byte 2107-15-31 31:63:62
    With file: E:\mp3\test\track1.mp3?"
    First: what does it mean: "-1 Byte 2107-15-31 31:63:62"?
    Second: While does it show me the destination name as mp3? it should show wma.
  • If you run settings - the default button is: "Cancel" - IMHO - OK would be better, cause usually I run settings, change any parameter and press ENTER. Instead of changing the settings - it does nothing ;-(
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
User avatar
SCHMaster
Member
Member
Posts: 199
Joined: 2003-02-08, 00:39 UTC
Location: Ukraine
Contact:

Post by *SCHMaster »

2djk
WMA settings - it still doesn't keep the bitrate ...
If you run settings - the default button is: "Cancel" ...
Ok. Fixed Link - OLD
Let's suppose I have a file: track1.mp3 and convert it into track1.wma...
Problem in this:
In function FsFindFirst and FsFindNext plugin must return the structure TWIN32FINDDATA
with description of the file, but since AUDIO-Sd track is not an usual file of the
file system, that, accordingly, plugin can not get the attributes of the file for
transmission them in structure TWIN32FINDDATA. On this plugin aproximately calculate
the size of the future file (WIN32FINDDATA.nFileSizeLow) but parameter ftCreationTime.dwHighDateTime,
ftCreationTime.dwLowDateTime and ftLastWriteTime.dwHighDateTime and ftLastWriteTime.dwLowDateTime
is assigned importance $FFFFFFFE. (Refer to. the help Writing file system plugins for Total Commander).


Reason in that that at copying (convert) TC call function
FsPutFile(LocalName,RemoteName:pchar;CopyFlags:integer)
where LocalName:= track1.mp3 and (in this instance) RemoteName:=track1.mp3 that is to say
LocalName = RemoteName. Hereinafter plugin changes extension of the file, checks,
there is already exists file and if there is, that reports TC about this
(result:=FS_FILE_EXISTS) whereupon you see
"Overwrite: \Convert\track1.mp3 -1 Byte 2107-15-31 31:63:62
With file: E:\mp3\test\track1.mp3?" - TC does not be aware of that that plugin
has changed the filename. Here is in than reason.
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

The settings of bitrate for WMA works properly now. :-)
Thanks for the explanation of the second problem. I willl try to understand... ;-)
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
VadiMGP
Power Member
Power Member
Posts: 672
Joined: 2003-04-05, 12:11 UTC
Location: Israel

Post by *VadiMGP »

SCHMaster wrote:Hereinafter plugin changes extension of the file, checks,
there is already exists file and if there is, that reports TC about this
(result:=FS_FILE_EXISTS) whereupon you see
"Overwrite: \Convert\track1.mp3 -1 Byte 2107-15-31 31:63:62
With file: E:\mp3\test\track1.mp3?" - TC does not be aware of that that plugin
has changed the filename. Here is in than reason.
I suggest you to check it again. It should work. You can change LocalName and TC take it in account in messages for user. In my Event Log plugin i did it.
User avatar
forka2k
New Member
New Member
Posts: 1
Joined: 2003-02-08, 16:03 UTC
Location: Ruse, Bulgaria
Contact:

Post by *forka2k »

I just try CD-Ripper 1.6 and when I click on the icon I got this error (take a look at the picture)
http://www.eic.rousse.bg/temp/cdrip.jpg
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

forka2k wrote:I just try CD-Ripper 1.6 and when I click on the icon I got this error (take a look at the picture)
http://www.eic.rousse.bg/temp/cdrip.jpg
I've also found this message but only once :-(
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
User avatar
SCHMaster
Member
Member
Posts: 199
Joined: 2003-02-08, 00:39 UTC
Location: Ukraine
Contact:

Post by *SCHMaster »

2forka2k and
2djk.
Ups ... Sorry ... I have wrong adjusted ASPack... Better in general without it... Fixed. Link - OLD
User avatar
nicol
Junior Member
Junior Member
Posts: 48
Joined: 2003-02-11, 13:33 UTC

Post by *nicol »

i discovered recently cd-ripper , what about the same features WAV to MP3 and MP3 to WAV for disk files ?

thanks

christian NICOL
User avatar
SCHMaster
Member
Member
Posts: 199
Joined: 2003-02-08, 00:39 UTC
Location: Ukraine
Contact:

Post by *SCHMaster »

2nicol
discovered recently cd-ripper , what about the same features WAV to MP3 and MP3 to WAV for disk files ?
Forgive, did not understand - that means " ... disk files"
You have in view of files on CD-Rom disk?
Post Reply