Ctrl-U and RAR archives

[mslav]

Another bug found when working with RAR archives. When you open the archive in the LEFT panel and then press Ctrl+U (swap panels) it displays the error message and exits the archive content:

mslav.intense.ru/1-before-Ctrl-U.png
mslav.intense.ru/2-after-Ctrl-U.png

Amazing thing that when you open the archive in the RIGHT panel, it swaps without error! But if you press Ctrl+U again (when the archive moves to the LEFT panel) it again displays the error message and exits the archive content.

Maybe the problem with displaying file time and the problem with panels swapping are connected somehow? I am a programmer and from my professional experience I know, that such sort of problems very often caused by incorrect stack usage. For example, your write:

void ShowRAR(wchar_t* archive_name)
{
wchar_t file_name[MAX_PATH];
FILETIME file_time;

....
}

And if somehow you copy to file_name more than MAX_PATH chars, you can destroy the value of file_time structure. But on some computers/systems it will not happened due to stack alignment etc. When I encounter such strange and not reproducing bugs in my programs first of all I check usage of all stack variables.

UPDATE:

I have tested panel swapping with ZIP file and also found a bug but a slight different one. When you open ZIP archive in the LEFT panel and then press Ctrl+U it swaps panels without error message but clear the list of files inside the archive:

mslav.intense.ru/3-before-ZIP-Ctrl-U.png
mslav.intense.ru/4-after-ZIP-Ctrl-U.png

Again, amazing thing that when you open ZIP archive in the RIGHT panel, it swaps without problem! But if you press Ctrl+U again (when ZIP archive moves to the LEFT panel) it again clear the list of files inside the archive.

P.S. Sorry I still cannot paste full URLs due to forum restrictions.

[mod]Thread split from Incorrect file time display in RAR archive.

Hacker (Moderator)[/mod]

[Clo]

2mslav

Hello !

…Amazing thing that when you open the archive in the RIGHT panel, it swaps without error! But if you press Ctrl+U again (when the archive moves to the LEFT panel) it again displays the error message and exits the archive content.

• I can confirm this, that's (at least) an oddity I never noticed before…

…I have tested panel swapping with ZIP file and also found a bug but a slight different one. When you open ZIP archive in the LEFT panel and then press Ctrl+U it swaps panels without error message but clear the list of files inside the archive: …

• Here, I get the same error message than with RAR, then the ZIP is shown “as is” (closed) in the right panel… XP-Pro SP1.

 KR
Claude
Clo

[mslav]

…Amazing thing that when you open the archive in the RIGHT panel, it swaps without error! But if you press Ctrl+U again (when the archive moves to the LEFT panel) it again displays the error message and exits the archive content.

• I can confirm this, that's (at least) an oddity I never noticed before…

Thanks to God, I'm not alone in this world who have this problem

…I have tested panel swapping with ZIP file and also found a bug but a slight different one. When you open ZIP archive in the LEFT panel and then press Ctrl+U it swaps panels without error message but clear the list of files inside the archive: …

• Here, I get the same error message than with RAR, then the ZIP is shown “as is” (closed) in the right panel… XP-Pro SP1.

Different behavior proves my version about stack problems. It often causes different behavior on different computers/systems.

[Clo]

2mslav

Again…

- I updated my reply, please F5…

 KR
Claude
Clo

[mslav]

2mslav

Again…

- I updated my reply, please F5…

 KR
Claude
Clo

Thanks! I updated my previous post too

[Clo]

2mslav

Again-again…

• I checked that in TC 7.04a, that works perfectly as expected !
- Hence, we may now call it A BUG

I'll report this elsewhere, hoping it will be fixed soon…
- Thank you for that find !

 KR
Claude
Clo

[mslav]

• I checked that in TC 7.04a, that works perfectly as expected !
- Hence, we may now call it A BUG

I'll report this elswhere, hoping it will be fixed soon…
- Thank you for that find !

Thank you too!

And yes, I forgot to mention that TC 7.04a swaps panels with these archives without any problems. So it's definitely TC 7.50 bug.

[petermad]

I can confirm the Ctrl-U bug.

But I get the same "Error in packed file" for both ZIP and RAR files.

EDIT: I have now testet a little more. Sometimes I get the Error message and sometimes the blank file list - for the same archive type, but different files.

I have testet the following archive formats: ARJ, ZIP, RAR, LZH, TAR, AES, CHM, 7Z, SQX, LST, JAR - the bug occurs with them all one way or the other.

[mslav]

I can confirm the Ctrl-U bug.

EDIT: I have now tested a little more. Sometimes I get the Error message and sometimes the blank file list - for the same archive type, but different files.

I have tested the following archive formats: ARJ, ZIP, RAR, LZH, TAR, AES, CHM, 7Z, SQX, LST, JAR - the bug occurs with them all one way or the other.

Good work! The random behavior of the bug is yet another proof of internal data corrupt.

[StatusQuo]

When you open ZIP archive in the LEFT panel and then press Ctrl+U it swaps panels without error message but clear the list of files inside the archive

I can confirm the Ctrl+U bug on RAR files (error message with archive left, but not on right panel). But I get the same behaviour with ZIP archives here (error message, archive not opened). Win2k SP4 and XP SP3.

TC 7.04a swaps panels with these archives without any problems.

Yes, 7.04a works like expected here, too.

[petermad]

To Moderators

Could one of you please split this thread as from this post: http://www.ghisler.ch/board/viewtopic.php?p=186039#186039

[ghisler(Author)]

Thanks, I could reproduce the problem.

[StatusQuo]

Fixed in TC 7.50a final (tested ZIP RAR ARJ LHA UC2 ACE TAR GZ TGZ).

[karlchen]

Fix in T.C. 7.50a Final confirmed.

Total Commander 7.50a (24-Sept-2009)
Windows Vista Home Premium, 32bit

Karl

[petermad]

Confirmed fixed in TC 7.50a