Drop-down button bar (subbar) problem

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Vochomurka
Power Member
Power Member
Posts: 814
Joined: 2005-09-14, 22:19 UTC
Location: Russia
Contact:

Drop-down button bar (subbar) problem

Post by *Vochomurka »

1) Icons are overlaying. Change icon size does not solve the problem. Neither do switching to "Small icons";
2) The tooltip text does not fit to the subbar width;
3) "-2" command (line break) does not work;
4) Open some multiline toolbar (for example, by Shift+Click). Line breaks work: this subbar takes several lines. Then execute the OPENBAR command with no-line-break bar. Oops! All lines, but the first one, remain on the screen, and are empty.

All the above applies to the subbar only. If to execute "Change button bar...", then "Button bar", and load it below menu (horizontally), everything is all right.
Single user license #329241
PowerPro scripts for Total Commander
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for your report!

1) Unfortunately I cannot reproduce it, it all looks OK here. Can you send me a screenshot (JPG or PNG) to beta at ghisler dot com, and also your settings (wincmd.ini)?
2. What tooltip do you mean?
3. This is a known limitation of Lazarus, no solution yet
4. I don't uderastand your report, starting with "Then execute". Where do I have to put that OPENBAR command?
Author of Total Commander
https://www.ghisler.com
User avatar
Vochomurka
Power Member
Power Member
Posts: 814
Joined: 2005-09-14, 22:19 UTC
Location: Russia
Contact:

Post by *Vochomurka »

1) http://powerpro.wincmd.ru/pack.zip
2) Last field in the button properties;
3) I see;
4) I execute it through a hotkey (user command)
Single user license #329241
PowerPro scripts for Total Commander
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

The only problem I can see is less menu width for x64 (almost after text), also height is some pixels less too. It is strange... Does Lazarus draws own context menus instead of using Windows ones?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2Vochomurka
1. Ah, you are using large icons - I tested with small icons only
4. Sorry, I still don't get it - you try to open some menu while another menu is shown?
Author of Total Commander
https://www.ghisler.com
User avatar
Vochomurka
Power Member
Power Member
Posts: 814
Joined: 2005-09-14, 22:19 UTC
Location: Russia
Contact:

Post by *Vochomurka »

2ghisler
1) I've said in my first post: 'Neither do switching to "Small icons"'. I've just re-tested it: when checking [X] "Small icons" and setting size "22", icons are very close to each other. If more than 22, they start overlaying. On 7.56 this does not happen.
2) Here is a part of my usercmd.ini:
[em_LoadDefaultBar]
cmd=OPENBAR %COMMANDER_PATH%\Default.bar
menu=Load Default Button Bar [F10]
Add it to yours, and assign some hotkey to it (I use F10). Then load any multiline bar and press your shortcut key. You should see your default bar and some empty lines below.
Thank you for your effort anyway.
Single user license #329241
PowerPro scripts for Total Commander
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

1. I tried with 16x16 icon only, sorry. I will try to add support for larger icons
2. Thanks, I will try that!
Author of Total Commander
https://www.ghisler.com
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hello, Christian.

Problem reproduced in Total Commander 8.0 beta1 64-bit on Server 2008 R2 with classic theme.
Problem solved in Total Commander 8.0 beta2 64-bit on Server 2008 R2 with classic theme. Here the subbar lines have exactly the same height as in Total Commander 8.0. beta1/2 32-bit. No more overlapping icons.

Hence: problem solved. :)

Cheers,
Karl
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Great, thanks!

2Vochomurka
All 4 problems should be solved, some by modifying the component library. Can you confirm the fixes too?
Author of Total Commander
https://www.ghisler.com
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

[Solved] 1) Icons are overlaying.

Post by *karlchen »

Hello, Christian.

Sorry, for causing confusion or for being confused myself. :oops:
Had not noticed that Vochomurka reported 4 problems.
Rescanned the thread content only superficially and recognized the problem which I had noticed about buttonbar submenus, too:
Vochomurka wrote:1) Icons are overlaying. Change icon size does not solve the problem. Neither do switching to "Small icons";
In T.C. 8.0ß1 64-bit the height of each subbar line was too small. As a result the subbar menu items partially overlapped.
This problem has definitely been fixed in Total Commander 8.0ß2 64-bit.

I am not sure about the other 3 problems, though.
So Vochomurka's reply is needed.

Karl
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

[Solved] 2) Tooltip text does not fit to the subbar width

Post by *karlchen »

Hello, Christian.

Reported issue #2
Vochomurka wrote:2) The tooltip text does not fit to the subbar width;
can be reproduced in T.C. 8.0ß1 64-bit using my own main bar and its subbar. Some tooltips which are displayed as menu text when the subbar is displayed as a submenu are clipped at the end.

This issue seems to be fixed in T.C. 8.0ß2 64-bit as well. All tooltip strings are displayed unclipped, i.e. completely, when the subbar is opened as a submenu.

Total Commander 8.0ß2 64-bit
Server 2008 R2, classic theme

Cheers,
Karl
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

[Can't repro] 3) "-2" command (line break) does no

Post by *karlchen »

Hello, Christian.

Cannot reproduce issue #3 though you stated it were a Lazarus limitation and it could not work. It does work here in T.C. 8.0ß1 64-bit.
3) "-2" command (line break) does not work;
I created a long sub-buttonbar and randomly inserted pseudo button which only held the command -2.
When this subbar is opened as a buttonbar, the linebreaks are executed as expected. As a result the buttonbar covers 3 lines.

This works fine in both
+ Total Commander 8.0ß1 64-bit and
+ Total Commander 8.0ß2 64-bit
on Windows 2003 Std SP2 64-bit, classic theme.

Does this mean
+ that I have missed the point of issue #3?
+ that the issue has been solved (though not reproduced in beta1)?
+ that the issue never existed?

Cheers,
Karl
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

[Can't repro] 4) All lines but the first 1, remain on screen

Post by *karlchen »

Hello, Christian.

What I stated for issue #3 is true for issue #4 as well. :?
Vochomurka wrote:4) Open some multiline toolbar (for example, by Shift+Click). Line breaks work: this subbar takes several lines. Then execute the OPENBAR command with no-line-break bar. Oops! All lines, but the first one, remain on the screen, and are empty.
I simply cannot reproduce it in Total Commander 8.0ß1 64-bit.
I used the multi-line sub-buttonbar which I created for issue #3. The last item in this buttonbar is to re-open the one-line only main.bar buttonbar.
What ca I say. Using this button loads the button bar. I covers only 1 line. 2 two additonal lines needed by main2.bar are gone.

This is true for
+ Total Commander 8.0ß1 64-bit
+ Total Commander 8.0ß2 64-bit

Does this mean
+ that I have missed the point of issue #4?
+ that the issue has been solved (though not reproduced in beta1)?
+ that the issue never existed?

Cheers,
Karl
User avatar
Vochomurka
Power Member
Power Member
Posts: 814
Joined: 2005-09-14, 22:19 UTC
Location: Russia
Contact:

Post by *Vochomurka »

ghisler(Author) wrote:All 4 problems should be solved, some by modifying the component library. Can you confirm the fixes too?
Yes, as far as I can see, everything is all right. Thank you!
Single user license #329241
PowerPro scripts for Total Commander
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Nice to hear that, thanks for letting me know!
Author of Total Commander
https://www.ghisler.com
Post Reply