Forum notifications marked as spam

[gulikoza]

Not really TC related but couldn't find a better place to post this.

Forum notification e-mails (topic reply notification...) are marked as spam by spamassassin. The failing rule is: TO_NO_BRKTS_MSFT To: misformatted and supposed Microsoft tool. This seems as if e-mail brackets are missing in To: addresses. Just thought to post this if somebody is interested

[ghisler(Author)]

Hmm, is there a rule that e-mail addresses must be in <> in the "To:" field? This is quite odd. Anyway, I have modified smtp.php now to the following code:

Code: Select all

	if ( strpos($mail_to, '<') !== false )
		fputs($socket, "To: $mail_to\r\n");
	else
		fputs($socket, "To: <$mail_to>\r\n");  

Could you watch this thread and check whether it helps or not, please?

[gulikoza]

This notification passed the spam filter without being marked as spam. I did some quick googling apparently there is some confusion regarding the angle brackets. Obviously they have to be there if name is also specified, but they should not be required when only e-mail is specified. There's an interesting (similar) bug report here:

Lack of brackets in recipient email addresses may confuse hotmail

I've checked some other forum notifications and they mostly contain e-mail inside the angle brackets even when no name has been specified.

[ghisler(Author)]

OK, then I will keep the above code. Thanks for your quick test!