Total Commander

Suggestion for verify after copy feature:

Check if file size is correct before checking CRC.

Unfortunately file size is not stored in CRC files.

MVV wrote:Unfortunately file size is not stored in CRC files.

I know, but file size can be detected when copying a file. I wasn't suggesting this for the Verify Checksums feature.

Sorry, you're right, I thought about regular CRC calculation.

I will consider it. But TC shouldn't check the checksum anyway when the copy function stops in the middle...

ghisler(Author) wrote:I will consider it. But TC shouldn't check the checksum anyway when the copy function stops in the middle...

TC should also not check after appending, except after appending to a 0 byte file. But this behavior is very convenient for testing, so I suggest to fix this later.

I join to such a suggestion.

Christian,
If if the file sizes are equal, I would suggest to compare

1. the first few bytes of the files
2. the last few bytes of the files
3. the middle few bytes of the files
4. and perhaps a few bytes from a random location in the files

Shouldn't increase the comparison noticeably if files are equal but should decrease the duration of the verify operation by quite a lot if they are not.

Roman

If if the file sizes are equal, I would suggest to compare

I think such actions should only be performed in case of large files.

white wrote:TC should also not check after appending, except after appending to a 0 byte file. But this behavior is very convenient for testing, so I suggest to fix this later.

HISTORY.TXT wrote:01.10.13 Fixed: Verify after copy not working correctly when appending to existing file (32/64)

It seems now the appended part is checked for CRC errors. Nice!

I noticed a difference in verifying after appending and after normal copying. If something is appended to the file during verify, verify after copy does not report a CRC error, but verify after appending does. Perhaps the offset for verifying after appending is calculated using file size?

Unfortunately it's currently not possible to handle the case of appending a partial file, so you will get an error, sorry.

Support.
It would be good to check CRC only when filesize is correct.
CRC would be wrong anyway if size becomes diffrent.

MaxX wrote:Support.
It would be good to check CRC only when filesize is correct.
CRC would be wrong anyway if size becomes diffrent.

I think it has already been added.

HISTORY.TXT wrote:01.10.13 Fixed: Verify after copy: Warn if file size wrong (32/64)

Yes indeed.