TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Please report only one bug per message!

Moderators: sheep, Hacker, Stefan2, white

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *petermad » 2019-11-21, 00:37 UTC

The new style of the color preview in the Color configuration dialog is hard to read especially for text with colored background compared to the old color preview:

See: https://madsenworld.dk/tcmd/colorpreviewnew.png and https://madsenworld.dk/tcmd/colorpreviewold.png

1. The color bars behind the text are lower, so the bottom of the text is almost cut off. They are also lower than the actual bars in the file panels.
2. The text is not bold anymore. But since the default font is not bold any longer maybe thats understadable, but it would nice if the font style (bold/normal) resembled the configured Font style.
3. The text is smaller than in the old color preview.

This also applies to the other color previews under "Others:"
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *ghisler(Author) » 2019-11-21, 10:38 UTC

The new preview uses the dialog box font configured by the user.
The old was using some default font which was tiny on high DPI devices.
I will not go back to the old font.

Any suggestions?
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *petermad » 2019-11-21, 12:05 UTC

The new preview uses the dialog box font configured by the user.
How about using the file panel font (including bold if chosen) instead?

And at least make the fields (color bars) higher, so they look like the color bars / cursor in the file panel.

Can I also suggest to put the title of the Preview ("Lister:", "Compare by contents:" etc.) over the preview box (where it now says Example (in the 32bit version) - As it is now it can be difficult to distinguish the default preview and the preview for "Synchronize directories" and "Hint windows:"
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Flint
Power Member
Power Member
Posts: 3249
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *Flint » 2019-11-21, 22:28 UTC

I support the idea of using the file panel font, and fixing the line height. Basically, the idea is, that the example box should resemble the file panel (which we are configuring) as close as possible.

Of course, for other previews it would be logical to use the respective fonts of the particular tools that are being configured/previewed.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.22a / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *ghisler(Author) » 2019-11-22, 15:33 UTC

OK, I will use the listbox font for the primary color preview, and the main window font for the title bar preview. for the others I will use the dialog box font, though.
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3249
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *Flint » 2019-11-27, 21:46 UTC

Confirm the correct file panel font in 9.50β7.

However, the line height is still too small, so the lines look squished (especially the cursor ones).
Here is the comparison of the preview box, and the actual file panel (with icons turned off): link
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.22a / Win7 x64 SP1, Win10 x64

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *petermad » 2019-11-27, 22:26 UTC

And at least make the fields (color bars) higher, so they look like the color bars / cursor in the file panel.
However, the line height is still too small, so the lines look squished (especially the cursor ones).
Here is the comparison of the preview box, and the actual file panel (with icons turned off): link
I agree on that - this applies to File panel view, Syncronize directories view, and Hint windows view.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *ghisler(Author) » 2019-11-28, 11:36 UTC

However, the line height is still too small, so the lines look squished (especially the cursor ones).
The preview use the font height in pixels retrieved via the GetTextMetrics function. The main window also considers the icon size, which may be larger.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *petermad » 2019-11-28, 14:12 UTC

The main window also considers the icon size, which may be larger
Could you maybe adjust for that, at least for a standard 16x16 icon size?
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *ghisler(Author) » 2019-11-29, 15:46 UTC

OK, I can do this, but it may make the preview larger than the available space.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *petermad » 2019-11-29, 20:54 UTC

but it may make the preview larger than the available space
Then a bit less - it was a fine height in the old preview.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *petermad » 2019-12-04, 20:43 UTC

01.12.19 Fixed: Configuration - Options - Color: Made items in the various color previews a bit higher (32/64)
Looks fine now in TC 9.5b8 :-)


02.12.19 Fixed: Configuration - Options - Color: Show preview also for synchronize dirs (32/64)
Nice, but the text color for "Selection - background" for equal files [=] is not shown correct - see: https://madsenworld.dk/tcmd/syncdircolorspreview.png - where the text should have been white.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Flint
Power Member
Power Member
Posts: 3249
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *Flint » 2019-12-04, 23:00 UTC

petermad wrote:
2019-12-04, 20:43 UTC
Looks fine now in TC 9.5b8 :-)
Not quite. In the preview the text in the cursor frame is positioned 1 pixel higher, than in the actual TC panel.
It's most noticable on the capital letters ("C" in "Cursor", for example): in file panel they are centered within the cursor frame, while in preview they are visibly closer to the top border.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.22a / Win7 x64 SP1, Win10 x64

User avatar
DrShark
Power Member
Power Member
Posts: 1400
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *DrShark » 2019-12-05, 08:21 UTC

ghisler(Author) wrote:
2019-11-22, 15:33 UTC
OK, I will use the listbox font for the primary color preview, and the main window font for the title bar preview. for the others I will use the dialog box font, though.
For hints preview, file lists font is used instead of dialog box font. And anyway, maybe it's better to use the font defined by [<currentresolution>] Font*Tip parameters here?
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b6 - Color examples in configuration hard to read and not conformed with chosen font

Post by *ghisler(Author) » 2019-12-05, 16:00 UTC

the text should have been white
I cannot reproducer this here. Please send me your ini settings to support at ghisler dot com.
Not quite. In the preview the text in the cursor frame is positioned 1 pixel higher
I don't care, this is just a color preview.
Author of Total Commander
http://www.ghisler.com

Post Reply