TC9.50B7 "File comments" called from "Change Attributes..."

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: sheep, Hacker, Stefan2, white

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-11-27, 21:13 UTC

1. Cursor on file with file comment
2. Files > Change Attributes... > Change plugin attributes: More attributes > Plugin: tc > Property: comment
    Load from file under cursor: From active panel (source) (1) > click on ">>"

Dark mode:
TC9.50ß7 x64: File comments are truncated at approximately 500 characters
TC9.50ß7 x86: File comments are displayed with 0 characters

Normal mode:
TC9.50ß7 x64: File comments are truncated at approximately 500 characters
TC9.50ß7 x86: File comments are truncated at approximately 500 characters

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *ghisler(Author) » 2019-11-28, 11:39 UTC

Not confirmed. Which Windows version? Theme enabled or classic theme?
Author of Total Commander
http://www.ghisler.com

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-11-28, 16:15 UTC

ghisler(Author) wrote:
2019-11-28, 11:39 UTC
... Which Windows version? Theme enabled or classic theme?
Windows 10 Pro (x64) Version 1909 (OS build 18363.476)

Themes ... Current theme: Custom -> Background: img1 = Windows 10 Pro picture, Colour: Automatic
Colours:     Custom, Choose your default Windows mode: Dark, Choose your default app mode: Light.

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *petermad » 2019-11-28, 18:26 UTC

I can confirm this under Windows 10 1090 build 18363.476, but not under Windows 7 and 8.1 - with 32bit TC 9.5x

The text is displayed fine in the "Value:" field. It is in the "File comment" dialog box, that pops up when clicking the [>>] button, that the text is not displayed.

I am testing with a file under the cursor that has a comment of 4032 bytes (the max I could set), and it is truncated to 1017 bytes, when collected with the [From active panel (source) (1)] button.

I can reproduce it with all beta versions of TC 9.5
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-11-28, 22:38 UTC

1. Cursor on file with file comment in the right panel
2. TAB (left panel active)
3. Cursor on file or folder
4. Files > Change Attributes... > Change plugin attributes: More attributes > Plugin: tc > Property: comment
    Load from file under cursor: From target (2) > click on ">>"

Dark mode:
TC9.50ß7 x64: File comments are truncated at approximately 500 characters
TC9.50ß7 x86: File comments are displayed with 0 characters

Normal mode:
TC9.50ß7 x64: File comments are truncated at approximately 500 characters
TC9.50ß7 x86: File comments are truncated at approximately 500 characters

Windows 10 Pro (x64) Version 1909 (OS build 18363.476)

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *ghisler(Author) » 2019-11-29, 15:43 UTC

I was able to reproduce it on Windows 10 1903 now. It happens because I added the function to make the scrollbar dark. This somehow recreated the control with no content.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *petermad » 2019-12-04, 21:08 UTC

Seems to be fixed in TC 9.5b8 :-)
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-12-04, 21:10 UTC

Code: Select all

04.12.19 Release Total Commander 9.50 beta 8
29.11.19 Fixed: Dark mode: "Edit comment" dialog called from "Change attributes" 
always had empty comment field on Windows 10 1903 (32)
Yes, but...

Dark mode:
TC9.50ß8 x64: File comments are truncated at approximately 500 characters | From active panel (source) (1) AND From target (2)
TC9.50ß8 x86: File comments are truncated at approximately 500 characters | From active panel (source) (1) AND From target (2)

Normal mode:
TC9.50ß8 x64: File comments are truncated at approximately 500 characters | From active panel (source) (1) AND From target (2)
TC9.50ß8 x86: File comments are truncated at approximately 500 characters | From active panel (source) (1) AND From target (2)

Additionally:
- End TC 9.50ß8 x64 with dark mode
- Start TC 9.50ß8 x86, switch off dark mode
- Perform the above test with file comments "From active panel (source) (1)" OR "From target (2)":
--> the scrollbar is still black (comments field: white background) <--
OR
- Switch off dark mode in TC 9.50ß8 x64 and close TC
- Start TC 9.50ß8 x86
- Perform the above test with file comments "From active panel (source) (1)" OR "From target (2)":
--> the scrollbar is still black (comments field: white background) <--

Windows 10 Pro (x64) Version 1909 (OS build 18363.476)

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *petermad » 2019-12-04, 21:35 UTC

I can confirm that the file comment gets truncated when copied to the "Value" field with the function "From active panel (source)" - but here it gets truncated at a little more than 1000 characters.

I am using "Plain text+UTF16" for the descript.ion file format - and the actual description file I tested with was saved as Plain text (the comment is the first 4082 bytes from the history.txt file (TC 9.5b8).
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-12-04, 21:50 UTC

For me it was this:

File comments - preferred type: Unicode UTF16
[X] DOS charset

descript.ion ...

opened with Notepad2-mod (64-bit) 4.2.25 r998 (62db550)
File - encoding: Unicode

opened with EmEditor Pro 64 bit
UTF-16LE with Signature

opened with Notepad++ v7.8.1 64 bit
Encode in UCS-2 LE-BOM

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *ghisler(Author) » 2019-12-05, 16:11 UTC

It's truncated on purpose due to official line length restrictions in descript.ion standard. 500 chars is for Unicode UTF-16 descript.ion.
Author of Total Commander
http://www.ghisler.com

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-12-05, 17:46 UTC

I take note of this statement but do not understand the following facts:

Since 08.06.16 Release Total Commander 9.0 beta 1 (32/64)
I have as setting Unicode UTF16 (at that time that was the default value)
and I have not changed that value since then.

Concerning the one file descript.ion (UTF-16LE with Signature)
I had among other 9 files with file comments in 1 folder,
and the file comments have partially exceeded the limit of 511 characters much(!).

It is possible
- to change or delete these file comments using Ctrl+Z, e.g. 2075 characters *)
- at least partially (due to the number of characters) to view the content of the tooltips

*) It was NOT possible to do the same via menu "Files" - "Change Attributes..."
    because only about 500 characters were displayed here.

Is there another format for file comments that you can recommend
and that may exceed the 511 character limit,
so that one can complete such a test case successfully?

User avatar
petermad
Power Member
Power Member
Posts: 8984
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *petermad » 2019-12-05, 20:36 UTC

Is there another format for file comments that you can recommend
Well, as I wrote: my setting is "Plain text+UTF16", and since there was no non-ansi characters in the description I tested with, I had around 1000 characters - so I guess if you choose the "Plain text" setting you should be sure to always have that amount available.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
tuska
Power Member
Power Member
Posts: 1758
Joined: 2007-05-21, 12:17 UTC

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *tuska » 2019-12-06, 12:02 UTC

Yes, but nevertheless I do not understand something here.

1. I set "Plain text+UTF16"
2. Add a comment with 4087 characters to a file (more is not possible here) and save it with "F2 OK" *)
3. With Ctrl+Z I open the comment window - now only 4074 characters are displayed (a few characters are missing)
4. I open the file comment via "Change file attributes ..." and only 1022 characters are displayed

*) In the help is something like this: "The comment is (new) limited to 4095 characters.

Window title: File comment

Code: Select all

Edit comment for: –           --> English menu language
Edit comment for: HISTORY.TXT --> German menu language
My guess is that the text is cut off at 1022 characters because there are scroll arrows ∧∨,
but the scroll bar that you could use to drag does not exist.

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50B7 "File comments" called from "Change Attributes..."

Post by *ghisler(Author) » 2019-12-06, 16:25 UTC

Ah, sorry, I was wrong - the maximum is 4kBytes per line including the name, extra fields, and CRLF at the end.

The limitation in "Change attributes" is a limitation of the plugin interface, which supports only up to 1 kByte of parameter length.
Author of Total Commander
http://www.ghisler.com

Post Reply