[solved/unchanged] TC 9.5b12a - Outline problems with specific layout settings

Please report only one bug per message!

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 9186
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

[solved/unchanged] TC 9.5b12a - Outline problems with specific layout settings

Post by *petermad » 2020-01-12, 14:03 UTC

This is seen in both Normal and Dark mode, but the screenshots are in Dark mode, because it is easier to see the problems.
With outline I mean a line surrounding a layout element in TC's main screen.

To reproduce the problems:
  1. Start with setting TC's layout like this: https://madsenworld.dk/tcmd/layout.png
  2. Adjust the width of TC so there would NOT be room for the "free space on drive" info to the right of the drive buttons - like: https://madsenworld.dk/tcmd/layoutbasic.png - Save TC's position (size).
  3. Now disable the "drive combobox" - it will look like: https://madsenworld.dk/tcmd/layoutnocombo1.png - as expected (32bit TC will look like step 4).
  4. Resize TC, so it is not as wide, just a little bit - it will look like: https://madsenworld.dk/tcmd/layoutnocombo2.png - there is now an outline around the "free space on drive" - NOT expected?
  5. Restart TC - the outline around the "free space on drive" is now gone.
  6. Resize TC again to get the outline around the "free space on drive" again.
  7. Now enable "Flat icons" for the drive buttons - the outline around the "free space on drive" disapears - like: https://madsenworld.dk/tcmd/layoutnocomboflatdrive.png - but there is now a line between the "free space on drive" and the "curent directory" bar - NOT expected! (also reported here: viewtopic.php?f=14&t=56959)
  8. Now re-enable the "drive combobox" - there is now a line between the "drive buttons" bar and the "free space on drive" - like: https://madsenworld.dk/tcmd/layoutpluscomboflatdrive.png - NOT expected.
  9. Now disable the "Flat icons" again - the line between the the "free space on drive" and the "drive buttons" bar disappears - like: https://madsenworld.dk/tcmd/layoutpluscombonoflatdrive.png (we are back to the start at step 2) and things look like it should, in my opinion.
NOTE:
In Normal mode the outline around the "free space on drive" is always present for step 3, 4 and 5 - as it is for 32bit TC in Dark mode.

if TC is wide enough (step 2 omitted), step 3 will look like: https://madsenworld.dk/tcmd/layoutnocombo3.png

Tested under Windows 7 and Windows 10 1909 with both 32bit and 64bit TC.

Note2: If I perform step 3 and press "Apply" in the configuration dialog, the outline around the "free space on drive" is not seen, but it appears wnen I press "OK".
Last edited by petermad on 2020-01-16, 18:19 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b13 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Usher
Power Member
Power Member
Posts: 704
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b12a - Outline problems with specific layout settings

Post by *Usher » 2020-01-12, 21:12 UTC

@ghisler(Author) has mentioned some time ago that only some layout elements have their own borders defined, some other are outlined by their neighbourhood. If there are any changes in the panel, only changed elements are redrawn. It means that elements without border may cover and hide borders of other elements. There are at least three possible solutions:
- define borders for all elements;
- draw aside adjacent elements or change their sizes to avoid overlapping;
- always redraw any element and its neighbourhood in the same order (which leads to redrawing of the whole layout).

IMHO only the first way is easy to implement.
Regards from Poland
Andrzej P. Wozniak

User avatar
petermad
Power Member
Power Member
Posts: 9186
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b12a - Outline problems with specific layout settings

Post by *petermad » 2020-01-13, 01:42 UTC

@ghisler(Author) has mentioned some time ago that only some layout elements have their own borders defined, some other are outlined by their neighbourhood. If there are any changes in the panel, only changed elements are redrawn. It means that elements without border may cover and hide borders of other elements.
I am not sure this is the case for the 3 problems I have shown here above.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b13 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38717
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12a - Outline problems with specific layout settings

Post by *ghisler(Author) » 2020-01-13, 11:07 UTC

Resize TC, so it is not as wide, just a little bit - it will look like: https://madsenworld.dk/tcmd/layoutnocombo2.png - there is now an outline around the "free space on drive" - NOT expected?
The outline is intentional - the volume+free/total space are part of the drive buttonbar, and uses its border settings.
Restart TC - the outline around the "free space on drive" is now gone.
This is indeed a bug. I will fix it.
Now enable "Flat icons" for the drive buttons - the outline around the "free space on drive" disapears - like: https://madsenworld.dk/tcmd/layoutnocomboflatdrive.png - but there is now a line between the "free space on drive" and the "curent directory" bar - NOT expected!

This line is intentional.
Now re-enable the "drive combobox" - there is now a line between the "drive buttons" bar and the "free space on drive" - like: https://madsenworld.dk/tcmd/layoutpluscomboflatdrive.png - NOT expected.
This line is also intentional.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9186
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b12a - Outline problems with specific layout settings

Post by *petermad » 2020-01-13, 14:09 UTC

ghisler(Author) wrote:
2020-01-13, 11:07 UTC
Now enable "Flat icons" for the drive buttons - the outline around the "free space on drive" disapears - like: https://madsenworld.dk/tcmd/layoutnocomboflatdrive.png - but there is now a line between the "free space on drive" and the "curent directory" bar - NOT expected!

This line is intentional.
Now re-enable the "drive combobox" - there is now a line between the "drive buttons" bar and the "free space on drive" - like: https://madsenworld.dk/tcmd/layoutpluscomboflatdrive.png - NOT expected.
This line is also intentional.
But what is the intention? What is the need for those two lines just because "Flat drive bar icons" is chosen - Actually one would think that if the user choose flat buttons, he wants as few outlines as possible. If "flat drive bar icons" is disabled the lines are not there.

There is now always a line around the "Current directory bar" and also around the "Tab headers", so there is no need for the line below the "free space on drive" ± the "Drive button bar" anymore in case of enabled "Flat drive bar icons".

Also noticed another issue: https://madsenworld.dk/tcmd/layoutleftfrespacebox.png - the left "free space on drive" box extrudes further to the right than the width of the left panel, when the Vertical buttonbar is enabled. This is not the problem when the Vertical buttonbar is turned off.

Also the calculation of when the "free space on drive" box is wrapped to a separate row is not optimal. Considerable cut-off of the content occurs before the wrapping occurs: https://madsenworld.dk/tcmd/layoutfreespacecutoff.png - it is less pronounced with a non-bold font for the Main window though.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b13 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38717
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12a - Outline problems with specific layout settings

Post by *ghisler(Author) » 2020-01-14, 09:14 UTC

The intention of the lines is to show the user where the buttons end, since they don't have a border themselves.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9186
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b12a - Outline problems with specific layout settings

Post by *petermad » 2020-01-16, 18:19 UTC

Resize TC, so it is not as wide, just a little bit - it will look like: https://madsenworld.dk/tcmd/layoutnocombo2.png - there is now an outline around the "free space on drive" - NOT expected?
Restart TC - the outline around the "free space on drive" is now gone.
Confirmed fixed in TC 9.5b13 - there is now always an outline around the "free space on drive" (I would have preferred the opposite)
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b13 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

Post Reply