Quickpreview (native mediaplayer) not in sync with selected file

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

adoeller
Junior Member
Junior Member
Posts: 82
Joined: 2011-05-23, 09:47 UTC

Quickpreview (native mediaplayer) not in sync with selected file

Post by *adoeller »

When using custom fields, the preview is not in sync with the selected file.

Video
When comparing the file names, you see the difference.

Used custom fields.

I could reproduce the behavior every time.

Alex
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *petermad »

I cannot reproduce this.

I have tested with TC 10 b10 32bit and 64bit under Windows 7 and Windows 10. I even set up the same Custum columns as you show here: https://www.dropbox.com/s/aarae7pxx9ee66r/2021-05-15%2021_17_28-total%20commander%2010.00%C3%9F10.png?dl=0
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *Usher »

@adoeller
Which custom fields cause problems - from tc or from tcmediainfo?
Where is your mouse cursor located - on active panel, outside of TC window, in other place?
Andrzej P. Wozniak
Polish subforum moderator
adoeller
Junior Member
Junior Member
Posts: 82
Joined: 2011-05-23, 09:47 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *adoeller »

Hi,

I did a new video capture.

whenever pressing up or down fast serveral times, it misses some files for the quick preview, but the file selection is correct.

I did a clean start of TC and left clicked one file initially and then only used the keyboard.
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *petermad »

I can confirm, that if I switch quickly between video files with the keyboard, a video might start loading and not stop doing that when switching fast to the next file. It does not happen if I hold the up or down arrow for a little while and then release it, but it happens sometimes with repeatedly fast presses on the up or down key.

It does not matter whether I have a Custom Columns View or Full View.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *Usher »

So it looks like a known problem with fast reloading LAVfilters on file change, mostly fixed in TC10b7 and earlier betas:
Total Commander 10.00 public beta 7 wrote: 22.04.21 Fixed: AutoPitch.dll: Reduced audio lag when playing tracks with more than 2 channels (32/64)
19.04.21 Fixed: Separate quick view window (Ctrl+Shift+Q): Closing it while playing video continued to play the sound (32/64)
See also viewtopic.php?f=35&t=74400&p=400467#p400467
Andrzej P. Wozniak
Polish subforum moderator
adoeller
Junior Member
Junior Member
Posts: 82
Joined: 2011-05-23, 09:47 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *adoeller »

yes, may be related to the fix of the author. although the descriptions do not match my finding.

To be precise with my report, it is the wrong video that is played with perfect sound. no audio lag etc.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *Usher »

I mean - it's possibly related to the same piece of code, not to the same fix. There were more fixes in the new player…

Can you test some TC10 betas older than 7 and report whether they work better or worse?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *petermad »

I tried with TC 10 b6 - it seems equally easy to reproduce the problem as it is in b10.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *ghisler(Author) »

The new player loads videos asynchronously in a background thread. If I wouldn't do this, TC would become unusable. While a video is loading, another cannot be loaded, so when you quickly jump to the next file, it wouldn't be played. Currently I don't see an easy solution for that. I could freeze the interface until the video plays, but that would be horrible.
Author of Total Commander
https://www.ghisler.com
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *Hacker »

Christian,
Could you perhaps upon playback start check if the same file is focused?

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
adoeller
Junior Member
Junior Member
Posts: 82
Joined: 2011-05-23, 09:47 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *adoeller »

i would suggest that TC starts quick preview - at least for video - a certain time after file selection was moved. e.g. wait 75 ms (customizable) and then start preview. when the selection was changed meatime, restart the 75 ms timeout. would come handy for other time consuming preview addons as well, e.g. the outside in technology lister.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *ghisler(Author) »

I found a better solution: When quick view is busy and the user changes to a different file, I will now start a thread which checks every 100 ms whether quick view is still busy. If not, it will post a refresh message to the window. This way we get the correct video in the end, although it may be delayed a bit.
Could you perhaps upon playback start check if the same file is focused?
I'm already doing this. When you click on the same file which is already playing, it will not restart.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *Usher »

2ghisler(Author)
Maybe you should add some explanation about delay to TC Help?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Quickpreview (native mediaplayer) not in sync with selected file

Post by *ghisler(Author) »

The user will not really notice it, he will just see a switch between videos.
Author of Total Commander
https://www.ghisler.com
Post Reply