TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *Slavic »

The ability to change a picture zoom in Lister is limited by 0.1-1000% in the size dialog, but the upper limit may be increased far beyond reasonable values if we use the numeric "+" or Ctrl+wheel. The lower limit, however, is set correctly 0.1%.
Please fix the upper limit to 1000% as in the dialog.
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *ghisler(Author) »

Thanks for your suggestion. I wonder what you and others think about these limits. Are they too large/small? Or not enough?
Author of Total Commander
https://www.ghisler.com
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Re: TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *Slavic »

From my point, the default limits are OK, maybe the lower limit is a bit too small. But I'd suggest to change the multiplier and use the fixed scale instead. Currently, as I guess, Lister always uses the multiplier (or divider) 1.1, which results in non-integer values except of original 100%, if we use key/mouse. For example, it's not possible to get 200%, the nearest values are 194.8 and 214.3%.

Chrome browser, when zooming the web page, uses this percentage scale:
25, 33, 50, 67, 75, 80, 90, 100, 110, 125, 150, 175, 200, 250, 300, 400, 500.

I think such approach may be used in Lister too, even the same, because the multipliers are not protected by copyright.
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *ghisler(Author) »

Sounds like a good idea - I may even make the steps configurable via wincmd.ini.
Author of Total Commander
https://www.ghisler.com
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Re: TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *Slavic »

Fixed in TC10.50b2, zooming by key/mouse looks good, thanks!

I still cannot say whether the lower limit is OK or too low, better to ask other people's opinions.

However, I think that lower limit should not be decreased too much, if the picture would be invisible because width or height would be less than 1px on next step. For example, for 16x16 *.ico file, scale down should be stopped at 5% because the next value 3.2% makes the image invisible. But it's another suggestion, I can write in separate thread if need.
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *ghisler(Author) »

I'm now using your list 25, 33, 50, 67, 75, 80, 90, 100, 110, 125, 150, 175, 200, 250, 300, 400, 500 plus 750 and 1000
plus the first 13 divided by 10 and by 100:
2.5, 3.3, 5.0, 6.7, 7.5, 8.0, 9.0, 10.0, 11.0, 12.5, 15.0, 17.5, 20.0
.25, .33, .50, .67, .75, .80, .90, 1.00, 1.10, 1.25, 1.50, 1.75, 2.00

I'm deliberately adding so many steps so you can zoom even very large images.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC10.50b1: In Lister, limit the upper picture zoom by key/mouse

Post by *ghisler(Author) »

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply