[TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *petermad »

To reproduce.

1. Turn off "Show drive buttons" in TC's Layout configuration.
2. Close the Configuration dialog.
3. Open the configuration dialog again.
4. Turn "Show drive buttons" in TC's Layout configuration.
5. Open the Icons configuration - the "Extra drive space" option is not visible
6. Click on Apply - the "Extra drive space" option is still not visible.
7. Open the Layout configuration.
8. Open the Icons configuration . now the "Extra drive space" option is visible.

To be fair - if I click Apply after step 4, then the "Extra drive space" option shows up in step 5.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
yong
Member
Member
Posts: 110
Joined: 2009-05-20, 07:23 UTC

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *yong »

Confirmed.

Actually I think there are two issues with this "extra drive space" option:
1. this option should be always visible regardless of the visibility of the drive button bar, and
2. the two drop down lists for H and V values could be further narrowed down to leave more space for the H and V labels, since many languages - even Chinese - require more space to display a proper translation.
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *petermad »

2yong
As you can se here: https://www.ghisler.ch/board/viewtopic.php?p=412501#p412501 I can only agree with you on your first point.

And I also agreee the the drop-down lists does not have to be so wide.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *funkymonk »

For TC10.50b3 (x86 darkMode), the appearance of the extra drive space combo boxes still depends on whether the drive buttons are activated or not.

Even more strange:
If I (1st) de/select the buttons in layout, (2nd) press apply, and (3rd) go to icons, the combo boxes are visible or not as expected. Ok.
But: If I (1st) de/select the buttons in layout and (2nd) go to icons, the combo boxes visibility is not yet adjusted. Even if I (3rd) press apply then, they still stay as they were before, even if that is incorrect according to whether the drive buttons are activated or not.

My suggestion is still to keep them visible independent from any other option in the configuration.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *ghisler(Author) »

This is intentional and will not be changed, sorry.
To be fair - if I click Apply after step 4, then the "Extra drive space" option shows up in step 5.
That's because the drive buttons aren't actually shown until you click Apply.
People would complain about non-functioning comboboxes if I just disabled them instead of hiding them...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *petermad »

People would complain about non-functioning comboboxes if I just disabled them instead of hiding them
Hmm, according to that logic big parts or all of the "Tabstop/Data formats" and the "Folder Tabs" dialogs should be blank when tabstops and Folder Tabs are disabled.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *white »

ghisler(Author) wrote: 2022-04-28, 08:04 UTC This is intentional and will not be changed, sorry.
...
People would complain about non-functioning comboboxes if I just disabled them instead of hiding them...
This thread is not about disabling instead of hiding. It's about options being hidden when they should be visible and working. And visible and working when they should be hidden.

And I agree the behavior is wrong.
yong
Member
Member
Posts: 110
Joined: 2009-05-20, 07:23 UTC

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *yong »

white wrote: 2022-04-28, 10:05 UTC
ghisler(Author) wrote: 2022-04-28, 08:04 UTC This is intentional and will not be changed, sorry.
...
People would complain about non-functioning comboboxes if I just disabled them instead of hiding them...
This thread is not about disabling instead of hiding. It's about options being hidden when they should be visible and working. And visible and working when they should be hidden.

And I agree the behavior is wrong.
May I suggest a solution to this problem in this thread, if it is not off topic?

The three options at the bottom of the Icons page ("Show drive icons from Explorer", "Set default icon library", and "Extra drive space") could be removed from this page and moved to a new secondary dialog box which in turn is invoked by a new button added to the right of "Show drive buttons" option in the Layout page. TC already has such an arrangement - in Folder Tabs page there is option "Show icons on tabs" with an associated >> button which opens a secondary dialog box to choose which icons are shown.
User avatar
jinsight
Senior Member
Senior Member
Posts: 299
Joined: 2003-02-25, 19:47 UTC
Location: Wooster, Ohio, USA

Re: [TC 10.50b3] Extra drive space not shown right after enabeling drive buttons

Post by *jinsight »

Support ++ the suggestion of yong. It seems consistent with other behavior in Configuration and doesn't appear to break anything.
License #1945
Windows 10 Pro x64
Version 22H2 (OS Build 19045.3930)
TC 11.00 x64 and x86, Everything 1.5.0.1366a x64, QAP 11.6.3.1 x64
Post Reply