Lister: the problem of colors in the media bar

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Lister: the problem of colors in the media bar

Post by *Fla$her »

Win 7, classic theme.
1. If there is a BgColor key in the [Lister] section, the background color for the media bar = the background color of the Lister itself and does not match the color of the buttons, menus and borders.
2. The Lister font color has a light shade ([Lister] > FgColor). As a result, the glyphs (of buttons, elapsed time and duration) in the media bar are poorly distinguishable and almost merge with the color of the buttons. Please make separate keys (normal/dark theme) for these glyphs.
3. It would also be nice to add sane button margins from the left (the edge of the left button overlaps the border) and bottom borders. In height, they should be centered similarly to the volume bar.
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

The coloring of the media bar is intentional and also happens when using other themes. I don't know how this could be improved. If I stop coloring the bar, other people will certainly start to complain too. :(
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: โ†‘2022-04-28, 08:06 UTCI don't know how this could be improved.
Why is that? I suggested above to make separate keys for coloring these elements.
MediaBarBgColor=-1 buttonface color (like without BgColor key); -2 Lister background color (like BgColor); 0+ (any color)
MediaTimeFgColor=-1 (by default like without FgColor key); 0+ (any color)
PlaybackButtonsFgColor=-1 (by default like without FgColor key); 0+ (any color)
Then there will be no reason to complain. And don't forget about the margins.
It shouldn't look so unsightly.
Overquoting is evil! ๐Ÿ‘Ž
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

2ghisler(Author)
I see new options in b4. Thanks. But, unfortunately, this is is a half-solution, since the problem of fusion text with the color of buttons, which for some reason does not change, has not been solved. If the color of the text matches the background of the buttons, then we will not see glyphs on the buttons at all. That's why I suggested 3 keys. Two is not enough. Please add one more option.
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Sorry, I don't understand what you mean. The panel background and button faces use the same color, and are both changed together.

Here is a screenshot with dark red text and a slightly brighter gray background:
https://www.ghisler.ch/control_colors.jpg
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: โ†‘2022-05-04, 22:13 UTCand are both changed together.
Only in dark mode, not in normal (as in my screenshot above).
Fla$her wrote: โ†‘2022-04-28, 05:25 UTCWin 7, classic theme.

Code: Select all

[Lister]
MediaFgColor=13160660
MediaBgColor=0
Result

And what about the margins (3.)? Can something be done about it?
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

My screenshot isn't from dark mode.
Are you using Windows classic theme?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Lister: the problem of colors in the media bar

Post by *white »

ghisler(Author) wrote: โ†‘2022-05-05, 16:26 UTC Are you using Windows classic theme?
He said so twice. And underlined it for emphasis the second time.
Fla$her wrote: โ†‘2022-04-28, 05:25 UTC Win 7, classic theme.
Fla$her wrote: โ†‘2022-05-05, 03:34 UTC
Fla$her wrote: โ†‘2022-04-28, 05:25 UTCWin 7, classic theme.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

Sorry, I really missed it, I tried to look for "Windows" with Ctrl+F and didn't find anything.
Anyway, I can reproduce it with TC 32-bit and classic theme, but it works fine with TC 64-bit.
I will add some simple manual drawing of the buttons.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: โ†‘2022-05-06, 14:02 UTCsimple manual drawing
What is meant by this?
Overquoting is evil! ๐Ÿ‘Ž
User avatar
white
Power Member
Power Member
Posts: 4594
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Lister: the problem of colors in the media bar

Post by *white »

Fla$her wrote: โ†‘2022-05-06, 15:48 UTC
ghisler(Author) wrote: โ†‘2022-05-06, 14:02 UTCsimple manual drawing
What is meant by this?
It means ghisler(Author) is not afraid of manual labor. He will come to your house, take out his crayon kit and draw the border directly onto your screen. :D
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

2white
Friday. Alcohol. Good mood. The time of humor. Yeah, who doesnโ€™t happen to? ;)


2ghisler(Author)
A very strange thing happened. After I changed the font color to the background color, in the main application menus for disabled items, the font color became the same, i.e. it is not visible until you set the cursor on such an element. The same applies to the text of the main menu of inactive applications. And this applies to all simplified (contrasting) themes. Replacing the color and restarting Explorer didn't help. :(
Overquoting is evil! ๐Ÿ‘Ž
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

TC 10.50b5: Now the color of the buttons is changing. The 3D shadow has been removed.
Fla$her wrote: โ†‘2022-04-28, 05:25 UTC 3. It would also be nice to add sane button margins from the left (the edge of the left button overlaps the border) and bottom borders.
No fixed.
Overquoting is evil! ๐Ÿ‘Ž
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: the problem of colors in the media bar

Post by *ghisler(Author) »

As I wrote, I created a very simple solution for the 32-bit version in classic theme: I draw the buttons manually:
- no border when not focused
- simple text color border when focused or clicked

Since Windows 7 is out of support, I will not put any more effort in this because it works fine with regular themes.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Lister: the problem of colors in the media bar

Post by *Fla$her »

ghisler(Author) wrote: โ†‘2022-05-12, 08:05 UTC- no border when not focused
You probably didn't understand. I wrote about margins, not borders. They are not in Aero themes too, and they do not look regular. The classic theme is more than ordinary.
Overquoting is evil! ๐Ÿ‘Ž
Post Reply