F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
JOUBE
Power Member
Power Member
Posts: 1472
Joined: 2004-07-08, 08:58 UTC

F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *JOUBE »

If starting the copying within the F5 Dialog (with "Counting files and folders in F5 copy dialog" enabled) by pressing the [ok] button, before counting has finished, then the total percentage part in copying info window leaves black.

It seams, that counting after pressing ok is disables in this configuration ('CountMarkedInDialog=1'), but - because of counting before is not finished - there are in this case no informations about the total . That's unfortunate. How to handle this? I do not know.

Fixed/changed in beta2 or beta3?

Joube
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *ghisler(Author) »

Which beta did you try? It should be fixed in beta 3.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1472
Joined: 2004-07-08, 08:58 UTC

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *JOUBE »

ghisler(Author) wrote: 2022-04-29, 10:29 UTC Which beta did you try? It should be fixed in beta 3.
beta 1. If I have free time to test it, I will try it in beta 3. Until that, I will leave "CountMarkedInDialog=0".
JOUBE
Power Member
Power Member
Posts: 1472
Joined: 2004-07-08, 08:58 UTC

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *JOUBE »

ghisler(Author) wrote: 2022-04-29, 10:29 UTC ... fixed in beta 3.
I am interested how do you fixed it?
- disabling the OK Button until counting has finished.
- pressing ok while counting: Message dialog: "If you really what OK now, the total percentage will not been shown in copy box".
- pressing ok while counting: Information: "counting was not finished, so the old routines will run now: please wait..."
- pressing ok while counting: No Information but the old routines will run..."
- ?
- ?

Joube
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *ghisler(Author) »

No, the counting continues in a background thread when you close the dialog - that thread was started when you opened the F5 copy dialog and keeps running until the counting is done or the user cancels the F5 dialog or the progress dialog later.

The problem was only the communication between that background thread and the dialog.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1472
Joined: 2004-07-08, 08:58 UTC

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *JOUBE »

You use that, which I described under:

Code: Select all

pressing ok while counting: Information: "counting was not finished, so the old routines will run now: please wait..."
...but without the information. Is that right?

This is - in my opinion - the only way to handle it technically.

But I think the user needs an information about the handling in this case.. Otherwise the user will not understand and even get angry why the counting routine starts a second time. Especially when this happens at large copy/move actions.

If you provide this information, the user will learn, that it is always a good idea to wait until the question marks *) have disappeared from the F5 main copy dialog.

JO" *) new implemented in beta 4: very good"UBE
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *ghisler(Author) »

pressing ok while counting: Information: "counting was not finished, so the old routines will run now: please wait..."
No, you will get the copy progress dialog which shows a counting progress until counting is done, but I'm not stopping the background counting dialog!
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: F5 [TC 10.50b] F5 "Counting files and folders in F5 copy dialog"

Post by *ghisler(Author) »

JO" *) new implemented in beta 4: very good"UBE

Moderator message

Moved to fixed bugs. Please submit a new bug report if there are still problems.
Author of Total Commander
https://www.ghisler.com
Post Reply