[TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

[TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *AntonyD »

If I will open some file w/o any Plugins - Menu "Plugins" will still show the first <internal> option as checked and selected - which is obviously not the true. Because viewer's mode "w/o any Plugins" uses only "2. Binary" or "1. Text only" variants of rendering of file's content.
And also NB! https://www.ghisler.ch/board/viewtopic.php?p=413313

IF I chosen Option 4 - Image/Multimedia/LS-plugins for viewing of file - only THEN it has a logic to select at least <Internal> variant of a viewer's capabilities.

Btw - WHY this option in help file Option has the truncated name? Only "4. Image" but in the reality it is equal to: "4. Image/Multimedia".
And even also WHY it does not highlight the full essence of its capabilities? with help of such name like: "4. Image/Multimedia/LS-plugins"?

Also help for Lister menu has wrong naming for:
"2. Binary" but should be "2. Binary (fixed line length)"
"5. HTML-Text" but should be "5. HTML-Text (strip tags)"
"7. UTF8" but should be "7. UTF-8"
"ANSI (Windows)" but should be "ANSI (Windows charset)"
"ASCII (DOS)" but should be "ASCII (DOS charset)"
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *ghisler(Author) »

"Internal" option is always checked when not using any plugins, which means that Total Commander is handling the file internally. I agree that it's a bit ambiguous, it could also be interpreted as using the internal "tc" plugin...

I will check your reports about the help, thanks.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *AntonyD »

"Internal" option is always checked when not using any plugins
But why? For which reasons? In my scenario - when I will open for ex. JPG file as-is (in Binary mode) this option - yes, it will be checked - BUT!!! it will NOT be used! I must AGAIN! click on it - AGAIN activate it in order to re-render JPG file as a picture with help of this mentioned option - with help of "the internal "tc" plugin"!
Thus all that actions show what the "always checked" state for this option - is not a good decision, imho!

In other words, it's an option that doesn't have a real "used/not used" state because the checkmark next to it is always enabled. And it is simply impossible to understand whether it works now or not!

P.S. And don't you think that "4. Image/Multimedia/LS-plugins" - is indeed a fully qualified name for this Lister mode? Against of the current one: "4. Image/Multimedia". Pls, consider specifying just such a full name for this option in the final release of the TC.
Last edited by AntonyD on 2022-05-05, 11:40 UTC, edited 2 times in total.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *petermad »

I agree that the "Internal" menu option should only have a checkmark if TC's internal "plugin" (Mediaplayer / GDI+ / DirectShow / MCI / IrfanView | XnView) is in use, not when Lister mode 1,2,3,5,6,7 is in use.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *Usher »

2petermad
But Lister mode 1-8 is already displayed in Lister "Options" menu. For me "Plugins" menu should display additional info, if available:
  • "Internal" for modes available by default in a fresh install, if there are no other option.
  • "Internal / additional info" - for modes with more options, practically only for mode 4. For example:
    - "Internal / RTF",
    - "Internal / LAVfilters"
    - "Internal / system media filters"
    - "Internal /Old Media Player"
    - "Internal / IrfanView"
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *ghisler(Author) »

For now I will check "Internal" for one of the two internal media players and for RTF. I will not do it for Irfanview, because it converts the image to BMP and TC handles that directly.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *ghisler(Author) »

This was confirmed fixed in a different thread, so I'm moving it to fixed bugs.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 10.50b4] Strange logic for Lister's <Internal> option and naming errors

Post by *AntonyD »

Agree - it's indeed fully fixed :)
#146217 personal license
Post Reply