[TC10.50b4] Click on Configuration/Options/Color activates Apply button

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4617
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *white »

  • Go to Configuration/Options
  • On the left, click Color
  • The Apply button is enabled.
This doesn't happen if you use the keyboard or first click Font and then Color.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *Usher »

Now it tries to change Background 2 color. That's explains why "Apply" button goes active now. But it was working the same way also in TC 10.0, and there were no visible color changes there.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *petermad »

It also happens if the dialog is opened directly with cm_ColorConfig
This doesn't happen if you use the keyboard or first click Font and then Color.
But it still happens if I first click any item listed AFTER Color.


2Usher
Now it tries to change Background 2 color.
How do you deduct that?

But what I see is that if I already have a non-standard color configured for Background 2, then if I click on the [>>] button, the configured color is NOT displayed, but it displays 255,255,255 - did not do so in TC 10.00.

Same thing if I click the button at Background 2 and enter a color and click OK. If I click the [>>] button again it shows color 255,255,255

But it was working the same way also in TC 10.0
Confirmed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *ghisler(Author) »

The Apply button is enabled.
Confirmed. Delphi is a bit stupid here, it triggers the "changed" notification even when I change a value programmatically, not only when the user changes it.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *Usher »

petermad wrote: 2022-05-05, 09:47 UTC 2Usher
Now it tries to change Background 2 color.
How do you deduct that?
Oh, it was just a quick look, without any testing. I use Background 2 color almost the same as Background, other colors are too distracting for me. But I can see you have already found the reason - you can change any color and it goes white, also in dark mode.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *ghisler(Author) »

The color reading code was damaged when I added the code for the two additional colors for the media player controls. I will fix it in the next beta.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4617
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *white »

Apply button no longer gets enabled using TC10.50b5.
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *petermad »

history.txt wrote:06.05.22 Fixed: Configuration dialog: Jumping directly to Colors page would activate "Apply" by mistake (32/64)
Confirmed fixed in TC 10.50b5 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4617
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *white »

petermad wrote: 2022-05-05, 09:47 UTC But what I see is that if I already have a non-standard color configured for Background 2, then if I click on the [>>] button, the configured color is NOT displayed, but it displays 255,255,255 - did not do so in TC 10.00.

Same thing if I click the button at Background 2 and enter a color and click OK. If I click the [>>] button again it shows color 255,255,255
Is that fixed as well?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *ghisler(Author) »

It should be, as well as the following which is essentially the same color lookup bug:
https://www.ghisler.ch/board/viewtopic.php?t=76543
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *Usher »

Confirmed fixed both "Apply" button and color lookup bugs in TC10.50b5.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
white
Power Member
Power Member
Posts: 4617
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.50b4] Click on Configuration/Options/Color activates Apply button

Post by *white »

Moderator message from: white » 2022-05-13, 07:31 UTC

Moved to Fixed bugs
Post Reply