[Fixed][10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Max33Verstappen
Junior Member
Junior Member
Posts: 23
Joined: 2019-10-21, 18:19 UTC

[Fixed][10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *Max33Verstappen »

Copying/Moving multiple files to a single file by pressing "Enter" or by clicking "OK" brings up a warning Msg Box -- "you cannot move or copy more than one file to a single file!".
But doing so by pressing "F2" or by clicking "Queue" freezes TC and it can only be terminated forcefully.

E.g. Copying multiple files to "c:\a" (without trailing back slash), where "a" doesn't exist.
Last edited by Max33Verstappen on 2022-05-11, 22:38 UTC, edited 1 time in total.
User avatar
white
Power Member
Power Member
Posts: 4614
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *white »

Confirmed for Dark mode only.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48070
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *ghisler(Author) »

Unfortunately this cannot be fixed, see:
https://www.ghisler.ch/board/viewtopic.php?t=76287

The only solution would be to remove the warning completely. :(
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4614
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *white »

Couldn't you check if the target is a single file before closing the copy dialog and sending it to the background transfer manager?
Max33Verstappen
Junior Member
Junior Member
Posts: 23
Joined: 2019-10-21, 18:19 UTC

Re: [10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *Max33Verstappen »

The actual problem is one can sometimes forget to put the trailing backslash and the purpose is to copy/move to that folder.
With the trailing backslash, like "C:\a\", TC creates it if it doesn't exist.

I think a practical fix is that when multiple files are selected and the target is a single file, it should be treated as a folder -- like what TC does when the folder exists -- and created if not there.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48070
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *ghisler(Author) »

Couldn't you check if the target is a single file before closing the copy dialog and sending it to the background transfer manager?
That's a good idea, I will do this. Additionally I will show the normal (not dark) message box when the main thread is busy as in this case.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4614
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [Fixed][10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *white »

Tested using TC10.50b6 32bit and 64bit dark mode.

I get a dark error message saying multiple files cannot be copied to a single file. After I click OK, the background transfer manager is closed and all is OK.

So seems to be fixed.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48070
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Fixed][10.50 B4] Copying/Moving multiple files to a single file using "F2"(Queue) freezes TC

Post by *ghisler(Author) »

There was a related bug caused by this fix in beta 5:
https://www.ghisler.ch/board/viewtopic.php?t=76606
But it looks like both are fixed now. Thanks for your tests!

Moderator message from: ghisler(Author) » 2022-05-19, 08:14 UTC

Moved to fixed bugs.
Author of Total Commander
https://www.ghisler.com
Post Reply