Page 1 of 2

TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-17, 01:04 UTC
by Usher
1. Run any older Windows which don't support native dark mode.
2. Run TC with fresh ini. Don't change any settings, just accept proposed ones.

3. Go to any non-empty directory and:
a) Try to delete any subdirectory or file with F8 or Delete. You should hear a sound and see message "Do you really want to delete..." provided with an icon of question mark "?".
b) Press Escape and now try to delete up-dir item [..]. You should hear another sound (different from the previous one) and see message "No files selected!" provided with an icon of "i" (as info). Press Escape once again.

4. Now run Configuration -> Dark<->Normal from the main menu and switch TC to dark mode.
5. Repeat the same operations as described in p.3. Now you should:
a) NOT hear any sound when trying to delete a subdirectory or file.
b) Hear proper sound, but see wrong icon ("?" instead of expected "i") when trying to delete up-dir [..].

The problem exists from the very beginning of dark mode in both 32- and 64-bit TC. Tested in Windows XP and Windows 7.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-17, 07:48 UTC
by ghisler(Author)
I can confirm that the "i" icon isn't shown in dark mode. Seems like the custom dialog box I use only supports question and exclamation. I will add it.
Regarding the sounds I don't plan to make any changes, any change will certainly upset another group of people...

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-23, 02:16 UTC
by Usher
Exclamation mark is fixed in TC 10.50 RC3.
There is still no warning sound in dark mode when deleting. Stop disabling it, please. Let users configure sounds on their own. Did you disable other sounds in dark mode?

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-23, 08:22 UTC
by ghisler(Author)
The MessageBox function makes a sound by itself when you open it with one of the icons like question, exclamation etc. My dark mode dialog box doesn't currently play a sound. In some places, I call MessageBeep before MessageBox because in very old Windows versions the MessageBox didn't play a sound.

If I added a sound to my own dark mode MessageBox now, I fear that I will get a lot of complaints from people who don't want sound there in dark mode (at night), but want sound in normal mode (daytime). I really don't know how to resolve this dilemma and don't get a ton of hate either way.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-23, 12:44 UTC
by Dalai
ghisler(Author) wrote: 2022-06-23, 08:22 UTCI really don't know how to resolve this dilemma and don't get a ton of hate either way.
Although I don't care for this in any way: You could make it configurable. But I can see why you wouldn't want to add an option for this tiny thing.

Regards
Dalai

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-23, 16:56 UTC
by Usher
2ghisler(Author)
You allowed sound for non-important "i" info message and DISABLED sound for IMPORTANT "?" message.
On the contrary, only IMPORTANT messages should make sound.

But @Dalai is right - there should be configuration for sounds in dark mode added to "Misc." under "Custom sounds", for example:

Code: Select all

Disable sounds in dark mode for:
[v] "i" info messages     [ ] "?" warning messages  [ ] "!" error messages

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-24, 09:10 UTC
by ghisler(Author)
You allowed sound for non-important "i" info message
??? Where?

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-26, 16:35 UTC
by Usher
in point 3b) Delete [..]

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-27, 09:30 UTC
by ghisler(Author)
I hear the same sound for 3b in dark and normal mode.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-27, 22:38 UTC
by Usher
But you did declare that there should be NO SOUND AT ALL IN DARK MODE - for any message type.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-28, 08:43 UTC
by ghisler(Author)
No, when TC calls MessageBeep before MessageBox, there will be a sound. As I explained above, in some places, I call MessageBeep before MessageBox because in very old Windows versions the MessageBox didn't play a sound.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-28, 09:44 UTC
by AntonyD
So maybe it's worth making everything consistent - wherever it is expected, make support for both sound and dark mode?
We should not use the concept
in some places
;)
To turn off the sound of windows - as it was suggested - you can make an options in the settings. ALTHOUGH I don't see any logic at all in linking the fact of using a dark theme and the night time of the day, when it is desirable to make the sounds quieter.
people who don't want sound there in dark mode (at night), but want sound in normal mode (daytime)
Usually the dark mode is turned on simply because it is so convenient to read information. And they work. During the day. That is, when all sounds are completely resolved and logical.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-28, 11:05 UTC
by Usher
2AntonDudarenko
That's exactly what I think. It's completely inconsistent now.

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-28, 12:17 UTC
by white
ghisler(Author) wrote: 2022-06-23, 08:22 UTC The MessageBox function makes a sound by itself..

Re: TC 10+ dark mode - wrong icons and sounds for delete messages

Posted: 2022-06-29, 09:00 UTC
by ghisler(Author)
Yes, on newer Windows versions the MessageBox function makes a sound by itself when it is shown with one of the icons (question mark, (i), exclamation mark).