Wrong icon shown when opening a button bar as menu

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
BenderBey
Junior Member
Junior Member
Posts: 4
Joined: 2022-04-17, 15:20 UTC

Re: Wrong icon shown when opening a button bar as menu

Post by *BenderBey »

You can add a completely transparent icon. But all this complicates a simple process.
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *petermad »

You can add a completely transparent icon. But all this complicates a simple process.
Yest but that looks weird in bar mode when "Flat icons" is disabled for the button bar.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *ghisler(Author) »

1. Use a command which does nothing, like
CM_WAIT 0
2. If you don't want an icon, use a transparent icon
https://www.totalcommander.ch/win/tools/transparent.ico
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Wrong icon shown when opening a button bar as menu

Post by *funkymonk »

Sure, I also use a transparent icon as a workarount, but as petermad pointed out:
petermad wrote: 2022-08-27, 21:16 UTC Yest but that looks weird in bar mode when "Flat icons" is disabled for the button bar.
Apart, if the bar file is *not* opened as a dropdown menu but as a regular (horizontal) bar, the transparent icon occupies the same space as any other icon. This also looks strange.
In this case, it should show as a separator (in the best case with the corresponding tooltip).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *ghisler(Author) »

The problem is that I can't fix it easily because the bar and menu share the same icon cache file when the icon size is the same. Therefore the bar and menu can't have different numbers of icons. Entries which appear as separators in the bar can't suddenly appear with their own icons in the menu. This caused the original bug where the entries had the icon of the command below them.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *petermad »

ghisler(Author) wrote: 2022-08-28, 06:31 UTC 1. Use a command which does nothing, like
CM_WAIT 0
2. If you don't want an icon, use a transparent icon
https://www.totalcommander.ch/win/tools/transparent.ico
That is what I use in my Laguagebar - and it works fine for the bar as a menu: https://madsenworld.dk/tcmd/menubar1.png, but not so well as a bar: https://madsenworld.dk/tcmd/menubar2.png - when flat icons are disabled.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *ghisler(Author) »

I could show entries with no command but with a hint text as text without an icon (ignore the icon field). This could be done with very minor changes.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *petermad »

2ghisler(Author)
I could show entries with no command but with a hint text as text without an icon (ignore the icon field). This could be done with very minor changes.
Sounds good for menu mode, but what would be displayed in bar mode - with and without Flat icons enabled?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Wrong icon shown when opening a button bar as menu

Post by *funkymonk »

ghisler(Author) wrote: 2022-08-28, 10:57 UTC I could show entries with no command but with a hint text as text without an icon (ignore the icon field). This could be done with very minor changes.
I guess that would be a (first) improvement.

If I interpret it correctly, it would be like this:

In menu mode the tooltip would be displayed as a regular entry (which can be used as "named separator") but without icon.
In bar mode a regular separator (vertical line) would be displayed. Could this regular separator display the tooltip on mouse over?

Right?
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *petermad »

In bar mode a regular separator (vertical line) would be displayed.
Vertical lines are only shown when Flat icons are enabled - otherwise an extra space is shown - and that would be OK with me too when used with a Tooltip only.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *ghisler(Author) »

In menu mode the tooltip would be displayed as a regular entry (which can be used as "named separator") but without icon.
Yes, that's the idea of my suggestion.
In bar mode a regular separator (vertical line) would be displayed.
Yes, that's the current behaviour. I will not change it.
Could this regular separator display the tooltip on mouse over?
No, I don't think that it's a good idea, only use it for the dropdown menu.
Vertical lines are only shown when Flat icons are enabled - otherwise an extra space is shown - and that would be OK with me too when used with a Tooltip only.
Yes, that's the current behaviour when not using flat icons. I will not change it.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Wrong icon shown when opening a button bar as menu

Post by *funkymonk »

:D Sounds good for rc4
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *ghisler(Author) »

I found another combination which can be used:
If there is a button with
- no icon
- a command
- a hint
it is currently shown as a separator in both bar mode and menu mode. It could be shown as a command without icon in menu mode.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Wrong icon shown when opening a button bar as menu

Post by *funkymonk »

ghisler(Author) wrote: 2022-08-28, 17:07 UTC I found another combination which can be used:
If there is a button with
- no icon
- a command
- a hint
it is currently shown as a separator in both bar mode and menu mode. It could be shown as a command without icon in menu mode.
That sounds good. (Hiding a button with a command would sound odd to me.)
But why hide it in bar mode? What about implicitly displaying a "transparent" icon in bar mode?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Wrong icon shown when opening a button bar as menu

Post by *ghisler(Author) »

Sorry, bar mode is meant to be used with icons, by default there are no bar button borders (flat view). It would be difficult to use with multiple buttons without icons and borders.
Author of Total Commander
https://www.ghisler.com
Post Reply