Move/rename error dialogs

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
browny
Senior Member
Senior Member
Posts: 287
Joined: 2007-09-10, 13:19 UTC

Move/rename error dialogs

Post by *browny »

Windows 10 21H2, TC 10.51RC4 (probably any version).

Left pane: an executable file or a cabinet (.cab) opened as an archive.
Right pane: several files unpacked from the left pane
Now select file(s) in the right pane, press F6 and see a dialog.

One file selected: caption "Total Commander", text "Function not supported"
Two or more files: caption is .cab/.exe name, text "Too many files!"

The first message is good enough, but the second message is inconsistent and baffling.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Move/rename error dialogs

Post by *ghisler(Author) »

Total Commander checks a few conditions before packing. There are archive types which support multiple file packing, a single file (e.g. .gz), and no files. When multiple files are selected, TC first checks whether an archive supports multiple files or not, and shows error "Too many files!" if not. Then it checks whether the archive supports packing at all. Currently this happens in different functions, so I cannot simply change it. So while this may be annoying, it doesn't really cause any harm...
Author of Total Commander
https://www.ghisler.com
browny
Senior Member
Senior Member
Posts: 287
Joined: 2007-09-10, 13:19 UTC

Re: Move/rename error dialogs

Post by *browny »

Thanks for the explanation.
ghisler(Author) wrote: 2022-09-01, 09:54 UTC When multiple files are selected, TC first checks whether an archive supports multiple files or not
This check implies that files could be packed, does it not?
Logically, an ability to pack should have been checked first.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Move/rename error dialogs

Post by *ghisler(Author) »

It would indeed be better, but it's not so easy to rearrange these checks, sorry.
Author of Total Commander
https://www.ghisler.com
browny
Senior Member
Senior Member
Posts: 287
Joined: 2007-09-10, 13:19 UTC

Re: Move/rename error dialogs

Post by *browny »

Too late for the 10.51 release I guess, but might be done in the next version.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Move/rename error dialogs

Post by *ghisler(Author) »

I have changed this error message in TC 10.52 release candidate 1 and later, please check it!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4593
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Move/rename error dialogs

Post by *white »

Tested OK using TC 10.52rc2 32-bit and 64-bit.

"Function not supported!" is now displayed regardless of how many files/folders are selected when trying to copy or move to a .cab file.

Moderator message from: white » 2022-10-12, 08:12 UTC

Moved to Fixed bugs.
Post Reply