[TC 10.52] Things go wrong if adding more than 32 custom columns

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *white »

With no custom columns views, I added the custom columns view "test" with 32 empty columns.
The section [CustomFields] in wincmd.ini:
[CustomFields]
Widths1=80,30,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80
Headers1=\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n
Contents1=\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n
Options1=-1|0|96
AutoLoad=0
Titles=test
Now I add 1 more column. The last column is now very wide instead of 80.
The section [CustomFields] in wincmd.ini:
[CustomFields]
Widths1=80,30,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,3445401
Headers1=\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n
Contents1=Œ\n
Options1=-1|0|96
AutoLoad=0
Now I add 1 more column. The last 2 columns are very wide and when I open the dialog to edit the custom columns, value "\" is shown for first custom column.
The section [CustomFields] in wincmd.ini:
[CustomFields]
Widths1=80,30,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,80,3445401,3445401
Headers1=\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n
Contents1=Œ\Œ\n
Options1=-1|0|96
AutoLoad=0
Titles=test
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *petermad »

TC is not guaranteed to support more than 29 custom columns:
Help wrote:Custom column configurations:
Lists all configured custom columns views. A maximum of 29 views can be configured.
history.txt wrote:02.11.04 Added: TC now supports a maximum of 29 custom view modes, only the configured modes with a name are listed in the menu!

https://ghisler.ch/board/viewtopic.php?t=40490
https://ghisler.ch/board/viewtopic.php?t=34652

https://ghisler.ch/board/viewtopic.php?t=50149
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *white »

petermad wrote: 2023-01-16, 12:14 UTC TC is not guaranteed to support more than 29 custom columns:
Help wrote:Custom column configurations:
Lists all configured custom columns views. A maximum of 29 views can be configured.
history.txt wrote:02.11.04 Added: TC now supports a maximum of 29 custom view modes, only the configured modes with a name are listed in the menu!
You are confusing views with columns. The limit of 29 views was raised to 99, but the help still erroneously says 29 (bug). Creating 99 custom columns views works fine (except for the titles) and trying to create one more is handled nicely.
The same confusion exists in this thread.
Ghisler's answer wasn't very elaborately formulated and a lot have time has passed and having this amount of columns is no longer as extreme as it once was.
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *petermad »

You are confusing views with columns.
I see now that you were talking about columns in a single view, not the number of custum column views.

I think the number of columns in a single custum colums view is limited by the number of characters in the ContentsX or HeaderX lines (probably 4096), but that would not be the cause in the case you described.
Last edited by petermad on 2023-01-16, 19:13 UTC, edited 2 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
funkymonk
Senior Member
Senior Member
Posts: 408
Joined: 2013-12-04, 09:56 UTC

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *funkymonk »

From my observations the character limit of ContentsX lines is 1024 (not 4096). I actually find this quite limiting in some cases.
See also this thread: viewtopic.php?p=418060&hilit=columns#p418060

But this limit does not seem to be the problem in you case...
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *petermad »

2funkymonk
From my observations the character limit of ContentsX lines is 1024 (not 4096)
Thank you for the correction.

I still doesn't explain White's observation, his longest string is 118 characters.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *ghisler(Author) »

Maybe his ini section was exceeding 64k characters?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *white »

white wrote: 2023-01-16, 11:44 UTC With no custom columns views, I added the custom columns view "test" with 32 empty columns.
The section [CustomFields] in wincmd.ini:
ghisler(Author) wrote: 2023-01-18, 15:03 UTC Maybe his ini section was exceeding 64k characters?
wtf? It was 290 bytes and less.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *ghisler(Author) »

No idea then, I will have to check it in the debugger.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *ghisler(Author) »

This should be fixed in TC 11 beta, please test it. The maximum of 32 columns should be enforced now even when you edit the ini yourself.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 10.52] Things go wrong if adding more than 32 custom columns

Post by *white »

Tested OK using TC 11.00b1 32-bit and 64-bit.

Moderator message from: white » 2023-05-04, 19:56 UTC

Moved to Fixed bugs.
Post Reply