solved [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

solved [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *petermad »

history.txt wrote:03.05.23 Added: New internal command OPENBARMENU opens the passed .bar file as a dropdown menu. Only works when there is a top button bar (32/64)
When OPEMBARMENU is used in a button it was expected that the button icon get the little arrow down overlay, to indicate that it opens as a menu.
Last edited by petermad on 2023-05-10, 16:02 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 2248
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *Fla$her »

2petermad >>>
ghisler(Author) wrote: 2023-05-03, 19:49 UTC OPENBARMENU is NOT meant to be used from a button. It's meant for use from hotkey or starter menu, or for scripting, because OPENBAR already has a checkbox "Show as menu".
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *petermad »

because OPENBAR already has a checkbox "Show as menu".
It only has that checkbox if the barfile is put in the cmd field, not if it is put in the param field - so the OPENBARMENU is also to accomodate that.

And history.txt does not mention that OPENBARMENU should not be used in a button.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *ghisler(Author) »

It's not that it shouldn't be used, just that it wasn't meant to be used there. That's why the menu doesn't open below the button either. I will check whether I could add the overlay in both cases.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *petermad »

history.txt wrote:04.05.23 Fixed: New OPENBARMENU command now works properly on a button in the button bar: Show popup overlay icon, open bar below the button (32/64)
Almost fixed, it works when the barfile name is put in the command field, but not with the barfile name is put in the Parameters field
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *ghisler(Author) »

That's also the case for OPENBAR, it doesn't show the "show as menu" checkbox then. Sorry, currently this isn't planned.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *petermad »

That's also the case for OPENBAR, it doesn't show the "show as menu" checkbox then.
Yes I reported that for OPENBAR at some time.

I still think that OPENBARMENU should support filename in the Parameters field properly.

On the other hand, with the current implementation the menu opens in the upper left corner of source side of TC when the file name is in the Parameters field, but at the button when it is in the Command field - that could be considered a feature ;-)

So OK - Confirmed fixed in TC 11.00b2 :)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: solved [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *ghisler(Author) »

The problem is the following:
Currently I'm checking whether the command field contains .bar in addition to OPENBAR or OPENBARMENU, because the user may want to launch a program named openbar. I could also add this for the parameters field, but then there is a problem: The parameters field may contain something lik %P%N instead of the actual name.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14741
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: solved [TC 11.00b1] OPENBARMENU missing overlay arrow on menu icon

Post by *petermad »

because the user may want to launch a program named openbar
Aha, that's the reason.
I could also add this for the parameters field, but then there is a problem: The parameters field may contain something lik %P%N instead of the actual name.
Please add it anyway (the check for .bar in the Parameters field). The user can use %P%O.bar instead of %P%N
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply