✅ Support for parameters when binding commands to hotkeys

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

Fla$her
Power Member
Power Member
Posts: 2298
Joined: 2020-01-18, 04:03 UTC

✅ Support for parameters when binding commands to hotkeys

Post by *Fla$her »

Already wrote:
Fla$her wrote: 2023-05-04, 15:18 UTC Or somehow add on the Misc. page the ability to specify an internal command along with a parameter. It would be even better, given the number of such commands.
We have already accumulated 70 internal commands that support parameters. Some of them are in demand exclusively when creating hotkeys. At the moment, this is only possible after creating custom em_ commands. It would be great to save time and space in usercmd.ini if there was support for parameters with an additional field on the Misc. page.
Last edited by Fla$her on 2023-10-19, 01:17 UTC, edited 2 times in total.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Support for parameters when binding commands to hotkeys

Post by *petermad »

Support ++ if feasible - and also for the ability to use commands with parameters in the .mnu file
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
jinsight
Senior Member
Senior Member
Posts: 299
Joined: 2003-02-25, 19:47 UTC
Location: Wooster, Ohio, USA

Re: Support for parameters when binding commands to hotkeys

Post by *jinsight »

Support++
License #1945
Windows 10 Pro x64
Version 22H2 (OS Build 19045.3930)
TC 11.00 x64 and x86, Everything 1.5.0.1366a x64, QAP 11.6.3.1 x64
Fla$her
Power Member
Power Member
Posts: 2298
Joined: 2020-01-18, 04:03 UTC

Re: Support for parameters when binding commands to hotkeys

Post by *Fla$her »

05.05.23 Added: Hotkeys defined via Configuration - Options - Misc now support commands with parameters (32/64)
At last! 😃 Thank you, Christian! 👍
Overquoting is evil! 👎
User avatar
AntonyD
Power Member
Power Member
Posts: 1246
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Support for parameters when binding commands to hotkeys

Post by *AntonyD »

2petermad
Dont' you know the LANG new ID for this text resource? String "&Parameters:"?
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Support for parameters when binding commands to hotkeys

Post by *petermad »

2AntonyD
5375="&Parameter:"
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
AntonyD
Power Member
Power Member
Posts: 1246
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Support for parameters when binding commands to hotkeys

Post by *AntonyD »

huge thanks!
#146217 personal license
sa16
Senior Member
Senior Member
Posts: 217
Joined: 2021-09-10, 07:15 UTC

Re: Support for parameters when binding commands to hotkeys

Post by *sa16 »

A little remark. In the list of currently defined hotkeys, the command with the parameter is shown twice in the line. For example, - > cm_EditNewFile cm_EditNewFile 1.
It is also desirable to make the Parameters field unavailable for commands that do not support parameters.
User avatar
AntonyD
Power Member
Power Member
Posts: 1246
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Support for parameters when binding commands to hotkeys

Post by *AntonyD »

It is also desirable to make the Parameters field unavailable for commands that do not support parameters.
I would treat it even as a bug((( - i mean current situation - when there is no such check.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Support for parameters when binding commands to hotkeys

Post by *petermad »

the command with the parameter is shown twice in the line. For example, - > cm_EditNewFile cm_EditNewFile 1.
Not only twice in the line but also in two lines: https://tcmd.madsenworld.dk/keywithpatameter.png
It is also desirable to make the Parameters field unavailable for commands that do not support parameters.
Support+++ if feasible.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Support for parameters when binding commands to hotkeys

Post by *ghisler(Author) »

the command with the parameter is shown twice in the line. For example, - > cm_EditNewFile cm_EditNewFile 1.
Confirmed, thanks!
Not only twice in the line but also in two lines: https://tcmd.madsenworld.dk/keywithpatameter.png
Seems to depend on the hotkey. I get it for F12 alone, but not for Ctrl+1.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Support for parameters when binding commands to hotkeys

Post by *petermad »

Seems to depend on the hotkey. I get it for F12 alone
Then it was a lucky strike that it was F12 I tested it with :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
sa16
Senior Member
Senior Member
Posts: 217
Joined: 2021-09-10, 07:15 UTC

Re: Support for parameters when binding commands to hotkeys

Post by *sa16 »

14.05.23 Fixed: Configuration - Options - Misc: Hotkeys with parameters were shown incorrectly with command name doubled, e.g. cm_exit cm_exit 1 (32/64)
Thanks!
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Support for parameters when binding commands to hotkeys

Post by *petermad »

sa16 wrote: 2023-05-17, 19:03 UTC
14.05.23 Fixed: Configuration - Options - Misc: Hotkeys with parameters were shown incorrectly with command name doubled, e.g. cm_exit cm_exit 1 (32/64)
Thanks!
Yes, confirmed fixed in TC 11.00b3 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 2298
Joined: 2020-01-18, 04:03 UTC

Re: Support for parameters when binding commands to hotkeys

Post by *Fla$her »

2ghisler(Author)
And what about the support of commands like LOADLIST[0], SAVETABS[2|L/R], etc.?
If you specify a path like "%COMMANDER_PATH%\Lists\test.txt", then writes an error or does nothing. Moreover, the quotes in the dialog are not displayed when the keys are selected again.
Overquoting is evil! 👎
Post Reply