[11.00b1] ZIP packing: memory leak

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

[11.00b1] ZIP packing: memory leak

Post by *Flint »

Reposting from the Russian forum.

1. Open TC 11.00b1 32- or 64-bit, check the current memory consumption.
2. Pack a big ZIP archive with many files. I experimented with packing a directory containing ~38000 files with total size of ~1.2 Gb.
3. Compare the memory consumption after the operation finishes.

Here are the screenshots from Process Hacker for the 64-bit version of TC: before and after packing.
With the 32-bit version the growth is a bit slower, but also present.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48074
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b1] ZIP packing: memory leak

Post by *ghisler(Author) »

I will check it, thanks.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [11.00b1] ZIP packing: memory leak

Post by *Flint »

Seems fixed in b2.
It's a bit hard to tell, since memory consumption goes up and down, but I could not detect any consistent growth after performing several packing operations.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [11.00b1] ZIP packing: memory leak

Post by *white »

Moderator message from: white » 2023-05-11, 01:46 UTC

Moved to Fixed bugs.
(If later you again experience a memory leak, create a new bug report)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48074
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00b1] ZIP packing: memory leak

Post by *ghisler(Author) »

Indeed Beta 1 was allocating memory for the read and write buffers of the old pack function, but wasn't releasing them. They are not needed for the new function, which uses its own buffer for writing, and memory mapped access for reading.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4615
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [11.00b1] ZIP packing: memory leak

Post by *white »

Moderator message from: white » 2023-06-20, 19:32 UTC

New report about memory leak split to new topic.
Post Reply