[Implemented in Tc11.03rc3] [Tc11] Suggestion: COMMANDER_INI_PATH

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *ghisler(Author) »

I can change it, but the problem is that you can't use a backslash consistently when it's possible that the location is a drive root, e.g. on a USB flash drive.
Author of Total Commander
https://www.ghisler.com
User avatar
beb
Senior Member
Senior Member
Posts: 435
Joined: 2009-09-20, 08:03 UTC
Location: Odesa, Ukraine

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *beb »

ghisler(Author) wrote: 2024-01-19, 07:58 UTC ...problem is that you can't use a backslash consistently when it's possible that the location is a drive root...
Then the same will occur in case of the %COMMANDER_PATH%, won't it?
Nevertheless, %COMMANDER_PATH% does not include the terminal backslash.
So, regarding consistency, my vote goes, for one of the variables.
In other words, let them variables, %COMMANDER_PATH% and %COMMANDER_INI_PATH%, behave the same way.
Edit:
%COMMANDER_DRIVE% as well.
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *ghisler(Author) »

I will not change %COMMANDER_DRIVE% and %COMMANDER_PATH% because it would break existing configurations.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *JOUBE »

ghisler(Author) wrote: 2024-01-19, 09:51 UTC I will not change %COMMANDER_DRIVE% and %COMMANDER_PATH% because it would break existing configurations.
Of course, that shouldn't change under any circumstances. But %COMMANDER_INI_PATH% should look like %COMMANDER_PATH% otherwise there will just be endless stress...

[edit]
ghisler(Author) wrote: 2024-01-19, 07:58 UTC I can change it, but the problem is that you can't use a backslash consistently when it's possible that the location is a drive root, e.g. on a USB flash drive.
"drive root" nobody does that
[/edit]
Last edited by JOUBE on 2024-01-19, 10:53 UTC, edited 1 time in total.
User avatar
beb
Senior Member
Senior Member
Posts: 435
Joined: 2009-09-20, 08:03 UTC
Location: Odesa, Ukraine

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *beb »

2ghisler(Author)
Lol. I didn't imply changing %COMMANDER_DRIVE%, %COMMANDER_PATH%.
On the contrary, my idea is that %COMMANDER_INI_PATH% dealing with a similar entity is expected to follow the syntax of the two.
I.e. %COMMANDER_INI_PATH% is one to be changed.

%COMMANDER_DRIVE%, %COMMANDER_PATH% are going without trailing backslash -- %COMMANDER_INI_PATH% should follow the conception (to go without trailing backslash).
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10
User avatar
Dalai
Power Member
Power Member
Posts: 9393
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *Dalai »

JOUBE wrote: 2024-01-19, 10:18 UTC"drive root" nobody does that
Says who? You might not even realize that it's the drive root, e.g. in case of substituted drives (subst command) or a mapped network drive (net use command). Sure, it's probably (very) rare, but I don't think it's too far fetched to say that it will happen to someone eventually.

Nonetheless I vote for consistency with existing variables. Even if a drive root adds a backslash automatically I don't see that as a problem because a path like G:\\something is valid in Windows.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *JOUBE »

Dalai wrote: 2024-01-19, 11:14 UTCSure, it's probably (very) rare
And - additional - it is not a must to make use of this environnment var...


Dalai wrote: 2024-01-19, 11:14 UTCconsistency with existing variables.
That's the main point...

Joube

(K)I: nobody ≈ probably (very) rare ;-)
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *Fla$her »

JOUBE wrote: 2024-01-19, 10:18 UTC "drive root" nobody does that
%COMMANDER_EXE% /i=D:\my.ini
Why not?
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *petermad »

I agree that %COMMANDER_INI_PATH% should NOT end with a backslash - it is inconsistant with %COMMANDER_PATH%
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *Fla$her »

ghisler(Author) wrote: 2024-01-19, 07:58 UTC you can't use a backslash consistently when it's possible that the location is a drive root
And why can't? %COMMANDER_DRIVE% doesn't return "\". We can use %COMMANDER_DRIVE%\blabla. It's the same here.
Overquoting is evil! 👎
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *JOUBE »

Fla$her wrote: 2024-01-19, 20:35 UTC And why can't? %COMMANDER_DRIVE% doesn't return "\". We can use %COMMANDER_DRIVE%\blabla. It's the same here.
Finally this poster noticed it too...
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *Fla$her »

JOUBE wrote: 2024-01-19, 22:49 UTC Finally this poster noticed it too...
I don't see this poster or anyone else noting this before. My question is posed differently...
Overquoting is evil! 👎
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *JOUBE »

Tc11.03RC2: Implemented. Perfect. Thanks.
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [Implemented in Tc11.03RC2] [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *Fla$her »

21.01.24 Fixed: Removed trailing backslash from environment variable %COMMANDER_INI_PATH% (except in root) (32/64)
But why?
%COMMANDER_INI_PATH% = C:\TC
%COMMANDER_INI_PATH%\file.ext = C:\TC\file.exe ✅

%COMMANDER_INI_PATH% = D:\
%COMMANDER_INI_PATH%\file.ext = D:\\file.ext ⚠️
Overquoting is evil! 👎
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Implemented in Tc11.03RC2] [Tc11] Suggestion: COMMANDER_INI_PATH

Post by *JOUBE »

Fla$her wrote: 2024-01-23, 19:43 UTC
21.01.24 Fixed: Removed trailing backslash from environment variable %COMMANDER_INI_PATH% (except in root) (32/64)
%COMMANDER_INI_PATH% = D:\
%COMMANDER_INI_PATH%\file.ext = D:\\file.ext ⚠️
Oh, not perfect for working with.

2ghisler(author)
It is true, has the root folder has really the name "letter:\" (other than all other folders). But in this case is "letter:" better for handling with the env var. Please change it.
Last edited by JOUBE on 2024-01-23, 19:54 UTC, edited 5 times in total.
Post Reply