[TC 11.00b2] TC is termnated by creating a zip file with encryption

[cpp64]

TC is terminated by creating a zip file with one more file and using "internal zip packer and zip-nt 2.0.1" with encryption.

Maybe the new zip packer is the problem.

OS: Windows 11 x64 22h2
TC: 11.00b2 64bit

[Horst.Epp]

Not here.
Tested with ZIP 2.0 and AES256

May be only with certain files.
Did you test a few simple files ?

[cpp64]

Not here.
Tested with ZIP 2.0 and AES256

May be only with certain files.
Did you test a few simple files ?

The crash occurs in the internal zip packer and zip-nt 2.0.1 with one more file.

Try with "totalcmd folder" that includes more files.

[white]

Tested OK with b1, confirmed with TC 11.00 b2 64-bit and one of the AES encryption options.

32-bit shows an error:

---------------------------
Total Commander 11.00b2
---------------------------
Fatal error in zip thread, aborting!
Access violation at address E5518253. Read of address E5518253
Windows 11 Professional 10.0 (Build 22621), base: 00400000

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
E5518253

Raw:
0042376C 0041FC17 0041FC3B 00422FF3 00403440 00402229
>00419C69 0040369C
Press Ctrl+C to copy this report!
---------------------------
OK
---------------------------

[petermad]

In TC 11.00b2 32bit I get this error:

---------------------------
Total Commander 11.00b2
---------------------------
Fatal error in zip thread, aborting!
Access violation at address EFFD4C07. Read of address EFFD4C07
Windows 7 SP1 Professional 6.1 (Build 7601), base: 00400000

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
EFFD4C07

Raw:
004236F9 00423702 0041FC17 0041FC3B 00422FF3 00403440
00402229 >00419C69 0040369C
Press Ctrl+C to copy this report!
---------------------------
OK
---------------------------

In TC 11.00b2 64 bit I get a Windows error message saying tha Total Commander had stopped working.

It is only if one of the 3 AES encryptions are seleceted - not with the Zip 2.0 encryption.

Enabling zip-nt 2.0.1 does not seem to change things. AFAIK that setting is only for using an external packer, not the internal.

I do not see the bug in TC 11.00 beta1 - so maybe this fix is causing it:

09.05.23 Fixed: Small memory leak (16kBytes) each time when using the new ZIP packer (32/64)

[ghisler(Author)]

I can reproduce it, but only with large files (several MB). What file size did you pack?

[petermad]

I can reproduce it, but only with large files (several MB). What file size did you pack?

Just small files, it happens when for example packing WCMD_DEU.INC and WCMD_DEU.MNU

I am using "maximum compression (9)" in the Zip Packer setup, and one of the 3 AES encryption options. It can be reproduced with a clean ini file.

Tested under Windows 7 and 10, 32bit and 64bit TC 11.00b2

[white]

2k works. 12k fails.

[ghisler(Author)]

I found it, I was indeed using the buffer for regular ZIP packing which I no longer allocated in beta 2. It's only for 10 bytes checksum, so I can use a small buffer on the stack instead.

[white]

Tested OK using TC 11.00b3 32-bit and 64-bit.

[petermad]

17.05.23 Fixed: Packing with new ZIP packer and AES encryption caused access violation (32/64)

confirmed fixed in TC 11.00b3