[TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

[TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *AntonyD »

https://ibb.co/GCTKwCJ
If I select my RU LANGUAGE and not the internal English (with which I could make this screen) - I will lose all shortcuts notifications.
Like this: https://ibb.co/C5N3ypr
that's just some end of "translation???" for one shortcut is left. "+Вправо" is exactly equal to "+Right"

Probably because of that:

Code: Select all

24.05.23 Added: History context menu: Moved most hotkeys to strings 2115 ff, so they can be translated individually (32/64)
but this LANG resource 2115 already has a proper translation for 2115="&Show all entries"
So HOW we should now translate this?
#146217 personal license
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *Sir_SiLvA »

just wait for a fix for 2115 - 2117, which was allready reported broken
here http://ghisler.ch/board/viewtopic.php?p=432364#p432364
and here http://ghisler.ch/board/viewtopic.php?p=432390#p432390
Hoecker sie sind raus!
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *petermad »

2AntonyD
You have to add the shortcuts to the strings:

Code: Select all

2115="&Show all entries\tAlt+Shift+Down"
2116="&Open in new tab\tShift+Enter"
2117="Open in other &panel\tCtrl"
2118="Open in &new tab in other panel\tControl+Shift+Up"
2119="&Copy as path\tControl+C"
2120="&Remove directory from history\tShift+Delete"
Notice string 2117 only has \tCtrl - the last part (+Right or +Left) is taken from string 1644 (TC converts it to Title case)
Last edited by petermad on 2023-05-24, 20:57 UTC, edited 2 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *Sir_SiLvA »

petermad wrote: 2023-05-24, 19:49 UTC TC converts it to Title case
my 1664 inlcudes (LEFT)|(RIGHT) yet in the Directory list its shown as (left) and (right)?
(IMHO its a bug as it should be displayed as what the USER wants)
Hoecker sie sind raus!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *ghisler(Author) »

They should be shown as Left and Right, not left and right.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *AntonyD »

Notice string 2117 only has \tCtrl - the last part (Right or Left) is taken from string 1644 (TC converts it to Title case)
can I say very smoothly and quietly? 'that's veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeery strange decision'....
I REALLY hope it will be changed. IF we have the ability to translate all shortcuts for 2115-2120 - this must means ALL)))
1664 has another meaning and 'sub' translations let's say. So IF a completely NEW strings were introduced - so and translation must be new)))

P.S. grrrrr. ok, i found the explanations.
No there isn't. It depends on which side the list is shown, so I can't include LEFT and RIGHT there.
LEFT and RIGHT are taken from string 1644.
but this does not resolve MY problems now((( at all....
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *petermad »

Maybe it would be better with two strings:

Code: Select all

2117="Open in other &panel\tCtrl+Left"
2130="Open in other &panel\tCtrl+Right"
Maybe in some languages it is not proper with Title case or Lower case - so two strings would be better.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *ghisler(Author) »

No, then translators will use different hotkeys for the two - what a nightmare. :(
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *AntonyD »

No, then translators will use different hotkeys for the two - what a nightmare.
And here it is possible in more detail?
This is essentially two different actions - for which you need two different hot keys.
And in fact they are. Well, we're translating it. What's so terrible?
#146217 personal license
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3278
Joined: 2003-05-06, 11:46 UTC

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *Sir_SiLvA »

ghisler(Author) wrote: 2023-05-24, 20:53 UTC They should be shown as Left and Right, not left and right.
NO, they should be shown as LEFT and RIGHT because I wrote them like this

Code: Select all

EINF|DEL|POS1|ENDE|BILD-HOCH|BILD-RUNTER|SPACE|BackSpace|TAB|+|-|*|/|ENTER|ESC|(LEFT)|(RIGHT)|(UP)|(DOWN)"
Displaying a text from the lng-file as anything else as whats written down (with the exception of the one word banned "thanks" to "BIGHARD")
is in my book a bug.
ghisler(Author) wrote: 2023-05-24, 20:53 UTC No, then translators will use different hotkeys for the two - what a nightmare.
Unless you are forced to test every language file for TC by yourself I dont see why that is bad after all its just a hotkey in a popupmenu :D
Hoecker sie sind raus!
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *petermad »

This is essentially two different actions - for which you need two different hot keys.
I think Ghisler is referring to the &p hotkey, which should be the same in both strings, because they are newer used at the same time.
then translators will use different hotkeys for the two
I don't think so, maybe put an instruction in the new1100.txt file about it in the upcoming difres110.zip
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *ghisler(Author) »

How about this:

Code: Select all

2117="Open in other &panel"
2130="Ctrl+Left|Ctrl+Right"
This way there is no risk of different hotkeys.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1231
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *AntonyD »

How about this:
Looks optimistic! Can be used, imho.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *petermad »

ghisler(Author) wrote: 2023-05-25, 10:13 UTC How about this:

Code: Select all

2117="Open in other &panel"
2130="Ctrl+Left|Ctrl+Right"
This way there is no risk of different hotkeys.
Looks like a good idea, also makes the Dglrange.txt a little simpler.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14742
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b4] we losing shotkeys combos in context menu after LANG changing

Post by *petermad »

Confirmed fixed in TC 11.00b5 with the new string:
2130="Ctrl+Left|Ctrl+Right"

:-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply