White thick frame around lister context menus

[white]

• right-click in the open lister window = context menu appears -> with thick frame in dark mode!

The 64-bit version doesn't look too good. Screenshot
It's also very cramped and I prefer the Ctrl+Shift+C notation (I understand the reason with Shift was put in front).

[petermad]

Ctrl+Shift+C notation

It is only with the internal English - with the External wcmd_eng.lng file it is Ctrl+Shift+C

I will make a separate bug report about this.

[ghisler(Author)]

Moderator message

Split to its own thread

[ghisler(Author)]

I can confirm the problem, it has been like that for a long time.

[white]

Tested using TC 11.00b9 64-bit dark mode.
* Internal language fixed - OK.
* Thick border removed - OK.
* Window size has become even smaller instead of bigger. Screenshot

[AntonyD]

Shouldn't the keyboard shortcuts be aligned on the right side of the menu?
And be significantly separated from the actual text of the menu items themselves?
Now it's just an unreadable mess of characters in Dark mode.
In short - now everything looks correct and understandable only for normal mode.

[ghisler(Author)]

The shortcuts are all right aligned, they just don't have their own column.
It looks like that both in normal and dark mode.

[white]

The shortcuts are all right aligned, they just don't have their own column.

That's OK, but the window size is too small.

It looks like that both in normal and dark mode.

Did you use 64-bit TC?

[AntonyD]

2ghisler(Author)

It looks like that both in normal and dark mode.

https://ibb.co/6JRHtHK
this is TC32
https://ibb.co/g3cNdhS
and this is TC64

I give a hint - the menu looks correct and logical in 32-bit Total.
All you have to do is change the background color and font color.
But on the contrary, in 64-bit Total, only the color is correct.
The rest is completely misrepresented.

[ghisler(Author)]

Both use the TContextMenu control.
32-bit TC uses a standard context menu drawn by Windows.
64-bit uses the Lazarus context menu control, which uses owner-drawn menu items even when there are no icons. Unfortunately it seems that Lazarus does the measuring like this in all its context menus. You can see the same also in other TContextMenu controls, e.g. in Synchronize dirs. I will have to dig through the Lazarus sources to find a solution.

[white]

02.07.23 Fixed: Popup menus didn't use separate columns for text and shortcuts, e.g. in Lister (64)

It's looking a lot better, but is it possible to move the shortcuts a bit more to the right in dark mode? And can the line height be increased in dark mode?
Screenshot Lister context menu, normal mode and dark mode ( TC 11.00b10 64-bit )

[ghisler(Author)]

Strange, I thought it was using the same code for normal and dark mode. I will check it.

[ghisler(Author)]

I have checked it, normal mode uses theme services to determine the menu item dimensions. Dark mode is not drawn by the theme, so it uses a different function. I will use theme services for the dimensions also in dark mode.

[AntonyD]

Looks like it's fixed now at TC11.00RC1

[white]

Yes, looks much more the same using TC 11.00rc1.
The only differences I see now are that for the 32-bit version, the windows are wider, and for the 64-bit version, the shortcuts are a bit more to the left in normal mode compared to dark mode. Screenshot