[Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Schultheis
Member
Member
Posts: 117
Joined: 2004-03-04, 14:56 UTC
Location: Germany

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Schultheis »

ghisler(Author) wrote: 2023-07-10, 07:46 UTC Try without parameters, e.g. just
Editor=C:\Program Files\Emacs\emacs-28.2\bin\runemacs.exe
Does work!
DolusIctis
New Member
New Member
Posts: 1
Joined: 2023-07-11, 08:08 UTC

Error dialog when attempting to create-and-edit new file (external editor)

Post by *DolusIctis »

TC Version: 11.00b10

Description
When creating-and-editing a new file with Shift+F4 and an external editor has been defined, an error dialog pops up showing the following error message (the paths may be different):

File not found!
:\Program Files\Notepad++\notepad++.exe" "C:\Temp\test.txt"
"There are no more files."


Note: It seems as if the path of the external editor is truncated at the beginning, missing the double-quotes and drive letter: "C
Note 2: The file is created. Editing that file with F4 does work (opening the external editor with the file).

The external editor line in wincmd.ini is:
Editor=""C:\Program Files\Notepad++\notepad++.exe" "%1""

This feature was not broken in an earlier beta version of 11.00. It broke after an updating to 11.00b10.

Steps to reproduce
  • Clean install of TC
  • Set-up an external editor: Configuration > Options > Operation:Edit/View > Editor for F4 > Browse to Notepad++ executable
    Field should show something like:
    "C:\Program Files\Notepad++\notepad++.exe" "%1"
  • Click OK
  • In a writable folder, press Shift+F4
  • In the Enter filename to edit: enter: test.txt
  • Press Enter / click OK
-> Error message pops up (see above, "File not found...")

Expected behavior
New (empty) file is created and opened in external editor.

Observed behavior
New file is created but error message pops up. Editor is not started.
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: Error dialog when attempting to create-and-edit new file (external editor)

Post by *JOUBE »

[Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.
ghisler(Author) wrote: 2023-07-07, 09:46 UTC I can confirm that the editor name with double quotes is parsed incorrectly. I will fix it in the next beta. Sorry for the troubles.
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Error dialog when attempting to create-and-edit new file (external editor)

Post by *white »

Moderator message from: white » 2023-07-11, 09:22 UTC

DolusIctis wrote: 2023-07-11, 08:31 UTC
Topic merged with this thread.
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *AntonyD »

Looks like it's fixed now at TC11.00RC1
#146217 personal license
Jyte
Junior Member
Junior Member
Posts: 8
Joined: 2003-09-01, 08:04 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Jyte »

New file is created but error message pops up. Editor is not started even when using TC11.00RC1.
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *JOUBE »

Fixed in TC11.00RC1.

2Jyte:
Really no %1 or such things on the line?
ghisler(Author) wrote: 2023-07-10, 07:46 UTC Try without parameters, e.g. just
Editor=C:\Program Files\Emacs\emacs-28.2\bin\runemacs.exe
And with Tc11Rc1 is possible: Editor="C:\Program Files\Emacs\emacs-28.2\bin\runemacs.exe"
And even: Editor=""C:\Program Files\Emacs\emacs-28.2\bin\runemacs.exe""
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *AntonyD »

2Jyte
I have triggered the call of both the editor and the creation of the file with any sets of elements of the path to the exe file. Including "%1"
#146217 personal license
User avatar
Stefan2
Power Member
Power Member
Posts: 4159
Joined: 2007-09-13, 22:20 UTC
Location: Europa

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Stefan2 »

Jyte wrote: 2023-07-13, 05:13 UTC New file is created but error message pops up. Editor is not started even when using TC11.00RC1.

Please open your WINCMD.INI
search for the "Editor="-Line
and copy&paste that line to here.

I have this
Editor=TOOLs\NotePad2\notepad2.exe "%1"




 
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *ghisler(Author) »

2Jyte
RC1 uses again WinExec to open the editor on Shift+F4 and should behave exactly as TC 10.52. There must be an error in your editor configuration. Please let me know what exactly you have defined as editor in Configuration - Options - Edit/View.
Author of Total Commander
https://www.ghisler.com
Jyte
Junior Member
Junior Member
Posts: 8
Joined: 2003-09-01, 08:04 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Jyte »

original from wincmd.ini

Code: Select all

Editor=""C:\Program Files (x86)\Notepad++\notepad++.exe" "%1""
tested also following

Code: Select all

Editor=""C:\Program Files (x86)\Notepad++\notepad++.exe""
Editor=C:\Program Files (x86)\Notepad++\notepad++.exe
copied notepad++ to another directory

Code: Select all

Editor=C:\APPS\Tools\Notepad++\notepad++.exe
Editor=""C:\APPS\Tools\Notepad++\notepad++.exe""
If functionality works nicely for everyone else, I can continue with this :)

update, tested also using without positive result

Code: Select all

Editor=""C:\PROGRA~2\NOTEPA~1\NOTEPA~1.EXE" "%1""
Editor=""C:\PROGRA~2\NOTEPA~1\NOTEPA~1.EXE""
Editor=C:\PROGRA~2\NOTEPA~1\NOTEPA~1.EXE
Jyte
Junior Member
Junior Member
Posts: 8
Joined: 2003-09-01, 08:04 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Jyte »

Update: Works when using "filename.extension", but when trying to create file without extension then issue is seen.
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *AntonyD »

but when trying to create file without extension then issue is seen.
not confirmed(((
Do you see EXACTLY the same error? Could you please make a short video?
Btw. IF you create a button with appropriate command for editor call - will it work for you?
#146217 personal license
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *JOUBE »

Jyte wrote: 2023-07-13, 15:03 UTC Update: Works when using "filename.extension", but when trying to create file without extension then issue is seen.
Confirmed, But the issue is seen not within Tc but in npp: Messagebox: Can not open file "path\zzz.").

The problem for npp may be the point (zzz.) at the end of the pathname?

Wasn't that bug already fixed in Tc11 beta xx?
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6496
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: [Tc11b10] Shift+F4 (edit new file, a basic function of Tc) does not work.

Post by *Horst.Epp »

JOUBE wrote: 2023-07-13, 15:57 UTC
Jyte wrote: 2023-07-13, 15:03 UTC Update: Works when using "filename.extension", but when trying to create file without extension then issue is seen.
Confirmed, But the issue is seen not within Tc but in npp: Messagebox: Can not open file "path\zzz.").

The problem for npp may be the point (zzz.) at the end of the pathname?

Wasn't that bug already fixed in Tc11 beta xx?
The problem looks like npp specific.
PSPad configured as Editor has no such problems
and creates a file with no extension.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
Post Reply