[TC 11.00rc1] Pressing space when button on a buttonbar has focus

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

ghisler(Author) wrote: 2023-07-19, 13:25 UTC Since showing the right click menu within the overflow menu closes it, I prefer not to handle it via keyboard for now.
So you have to use the mouse for that? Suppose you have a subbar which is shown as menu, with the mouse you can enter the subbar and right-click on a button to make changes to the button. But you can't do that using the keyboard.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

I can confirm that the context menu for any button (submenu or not) in the overflow menu can not be opened with the keyboard.

Also when opening the context menu for any button in a submenu or in the overflow menu, the submenu/overflow menu is closed, leaving the context menu floating unattached - it can even be outside of the boundary of TC's main window for buttons that was far down in the submenu.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

The problem is that both the button bar menu (showing a .bar file) and the overflow menu are actual context menus, and Windows doesn't allow to show a context menu as a context menu of a menu item. So the only way to show it is to close the current context menu and open a new one.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

But how abot this part:
the context menu for any button (submenu or not) in the overflow menu can not be opened with the keyboard.
can that be fixed, so it opens the free floating context menu, as when using the mouse?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

I have checked this now:
1. Shift+F10 can be intercepted, strangely it creates a WM_SYSKEYDOWN message, not WM_KEYDOWN
2. Spacebar can also be intercepted, it creates a WM_CHAR message and also no WM_KEYDOWN
3. The special context menu key does nothing while a menu is open - no message is sent to the menu. Even calling GetKeyState or GetAsyncKeystate report that the key isn't being pressed although it's down during the call.

In summary, only the first two can be supported.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

history.txt wrote:23.07.23 Fixed: Button bar, show subbar as menu: Couldn't open item context menu via Shift+F10 or Space (the context menu key can't be used inside a context menu) (32/64)
Confirmed fixed in TC 11.00rc3 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

petermad wrote: 2023-07-26, 20:26 UTC Confirmed fixed in TC 11.00rc3 :-)
Confirmed, but when pressing space, there is a beep sound when using 32-bit TC.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *petermad »

white wrote:there is a beep sound when using 32-bit TC.
Confirmed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *ghisler(Author) »

The beep sound is created by Windows, so far I could not find a way to prevent it.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Pressing space when button on a buttonbar has focus

Post by *white »

HISTORY.TXT wrote: 27.07.23 Fixed: Button bar, show subbar as menu: Prevent beep when opening context menu with space (32)
Tested OK using TC 11.00 32-bit final.
Post Reply