[TC 11.00rc1] Crash when using Help > Index > Keyword

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *AntonyD »

2ghisler(Author)
Could you try the latest help recompiled by me with the option Compatibility=1.1, please?
I did it and can confirm - there is no crash with that version of chm file!
And .chw file does create now!
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *ghisler(Author) »

Do you also set the window type?
No, I just call
HtmlHelpA(0, helpFileName, HH_DISPLAY_TOC,0)
or
HtmlHelpA(0, helpFileName, HH_DISPLAY_TOPIC, topic)
or
HtmlHelpA(0, helpFileName, HH_HELP_CONTEXT, context)
I did it and can confirm - there is no crash with that version of chm file!
Great, then I will use that.
Author of Total Commander
https://www.ghisler.com
brahman
Senior Member
Senior Member
Posts: 204
Joined: 2006-04-26, 13:27 UTC

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *brahman »

ghisler(Author) wrote: 2023-07-25, 07:38 UTC 2brahman:
Could you try the latest help recompiled by me with the option Compatibility=1.1, please?
https://www.totalcommander.ch/help/totalcmd_chm.zip
The only thing I changed was setting Compatibility=1.1. Since the crash doesn't happen here any more on any system, it would ber helpful if you could check it.
Beautiful! No crash!
Regards, Brahman
Win10 & 11 Pro x64
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *Usher »

ghisler(Author) wrote: 2023-07-24, 09:53 UTC it should work with Compatibility=1.1.
The changed help also works on Windows 98, and the old one didn't work on Windows 95 (the user gets a message to download and install the HLP files), so there shouldn't be any new compatibility issues.
For Windows 95 there should be problems only with Internet Explorer 4.0 or 4.01installed as they come with HTML Help 1.0. IE4.01sp1 comes with HH 1.1, IE4.01sp2 - with HH 1.2 (this version I've just checked myself).
Andrzej P. Wozniak
Polish subforum moderator
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *white »

Moderator message from: white » 2023-07-26, 09:19 UTC

Off-topic posts moved to new topic.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *ghisler(Author) »

I have included the new help files now in RC3, please check whether you still get any crashes!
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *JOUBE »

You want feedback. Here is one: Help has never crashed here (w10/w11), and now it doesn't either (neither in w10 nor in w11).
But a small window pops up briefly when you press Enter in the search field. I didn't notice that before. If this was the case before? I do not know. It looks a bit strange.
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6498
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *Horst.Epp »

2JOUBE
That doesn't happen here, no pop-up or anything else.
For me, there were also never be any crashes with the help file.

Nevertheless, I use Dark mode.
I like the latest dark mode version from this thread, which supports single click.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *white »

HISTORY.TXT wrote: 24.07.23 Fixed: Help files: Changed "Compatibility" option to 1.1 to prevent help system crashes on some systems when searching the index (32/64)
The thing that solves the problem is using a binary index. Using a binary index is the default, but is not used when the "Compatibility" option is set to 1.0.
Perhaps this is a better text:
24.07.23 Fixed: Help files: Use Binary index instead of Sitemap (and use "Compatibility" option 1.1 which is needed for that) to prevent help system crashes on some systems when searching the index (32/64)

Horst.Epp wrote: 2023-07-26, 16:40 UTC Nevertheless, I use Dark mode.
I like the latest dark mode version from this thread, which supports single click.
Not in this thread anymore, I split this thread up.
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *petermad »

2brahman and 2AntonyD could you please crash-test https://tcmd.madsenworld.dk/totalcmdDark7.2.zip which is is based on totalcmd.chm from TC 11.00rc3 - just put TotalcmdDark.chm in TC's program directory and switch to Dark mode to test with F1.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
brahman
Senior Member
Senior Member
Posts: 204
Joined: 2006-04-26, 13:27 UTC

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *brahman »

petermad wrote: 2023-07-26, 17:46 UTC 2brahman and 2AntonyD could you please crash-test https://tcmd.madsenworld.dk/totalcmdDark7.2.zip which is is based on totalcmd.chm from TC 11.00rc3 - just put TotalcmdDark.chm in TC's program directory and switch to Dark mode to test with F1.
I can confirm that it doesn't crash. Great work!
ghisler(Author) wrote: 2023-07-26, 14:24 UTC I have included the new help files now in RC3, please check whether you still get any crashes!
No crashes! Thanks so much to you and everyone for your help in solving this problem! :)
Regards, Brahman
Win10 & 11 Pro x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *ghisler(Author) »

Thanks for confirming the fix! I will update the history as suggested by white.

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *AntonyD »

2petermad
It's a little late (already moved to fixed section) - but since you asked for help,
I answer - yes, everything is OK, no crashes and strange pop-up windows.
Everything works adequately!
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *petermad »

2AntonyD
Thanks
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc1] Crash when using Help > Index > Keyword

Post by *ghisler(Author) »

Thanks to everyone who helped finding and fixing this problem!
Author of Total Commander
https://www.ghisler.com
Post Reply