Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *ghisler(Author) »

I was informed via e-mail that the files TCMDLZMA.DLL and TCLZMA64.DLL were still based on the older version 22.1 of the LZMA SDK, while the 7-zip dlls were already updated to 23.1. I have now also updated these two dlls. They are used for ZIP compression method 10 in Alt+F5, available only when setting LzmaAllowed=1 in wincmd.ini, [packer] section. They are also used to unpack ZIP archives packed with the XP and Brotli methods.

Please check ZIP-LZMA compression and decompression if you used it before.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *funkymonk »

Out of curiosity: Which LZMA settings are used by TC with compression rate 10?

((BTW: The ZipType content plugin (V2.0.1.0) crashes when used with an LZMA compressed zip (compression rate 10) created by TC.
https://ibb.co/4N6fLkM
It works with other LZMAs created with various settings by, e.g., 7z.
But that seems to be a problem of the plugin.))
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *ghisler(Author) »

I'm not setting any parameters at all, so it should be using default parameters. I'm calling
LzmaEnc_Create(AllocProc);
LzmaEncProps_Init(@props);
LzmaEnc_SetProps(lzma_enc,@props);
Then I write the header like this:
res:=LzmaEnc_WriteProperties(lzma_enc,@lzma_header[4],headerSize);
lzma_header[0]:=4;
lzma_header[1]:=32;
lzma_header[2]:=headerSize;
lzma_header[3]:=0;
end;
if res=0 then
Lzma_OutStreamWrite(lzma_out,pchar(@lzma_header),4+headerSize);
Is there anything wrong about that? Both WinRAR and 7zip can unpack them just fine without complaints.
Could you send me a small LZMA packed ZIP which doesn't crash that plugin?
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *funkymonk »

ghisler(Author) wrote: 2023-07-27, 09:08 UTC Could you send me a small LZMA packed ZIP which doesn't crash that plugin?
Sure, I will send an email.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *ghisler(Author) »

Thanks for the files. However, the only file where ziptype doesn't crash doesn't even use LZMA:
"test1_7zip2301 x32 - LZMA CR9 -ZipType works.zip"
when I open this file with Enter in TC and look at the file properties with Alt+Enter, the file is just stored.
7zip does this when the compressed file isn't smaller than the uncompressed file.
Try compressing a file which can be compressed well, like a txt or html file.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *funkymonk »

Ah, I have just seen as well that the only working file just stores the pdf inside, sorry.
Well, I can try to create another example (but probably only during the weekend).

But as written in my E-Mail:
"Ich vermute, dass ZipType ein generelles Problem mit LZMA-komprimierten zip-Dateien hat. [...] Dass es tatsächlich am TC liegt glaube ich eher nicht."
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *ghisler(Author) »

I have now installed the plugin and created a true LZMA-compressed file with 7zip, and it also crashes the plugin. So you are right, the plugin crashes with any LZMA-compressed ZIP archive. Therefore there is no (known) problem with LZMA-compressed ZIP archives generated by Total Commander.
Author of Total Commander
https://www.ghisler.com
User avatar
funkymonk
Senior Member
Senior Member
Posts: 416
Joined: 2013-12-04, 09:56 UTC

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *funkymonk »

ghisler(Author) wrote: 2023-07-28, 07:32 UTC I have now installed the plugin and created a true LZMA-compressed file with 7zip, and it also crashes the plugin. So you are right, the plugin crashes with any LZMA-compressed ZIP archive. Therefore there is no (known) problem with LZMA-compressed ZIP archives generated by Total Commander.
I have also invested a bit more time and just like you I'm pretty sure that it's not a problem with TC.
I will try to inform the plugin author about the issue.

Thank you for your time!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Bug report via e-mail: Outdated TCMDLZMA.DLL and TCLZMA64.DLL

Post by *ghisler(Author) »

Since the crash in the ZipType plugin is unrelated, I'm moving this thread to fixed bugs now.

Moderator message

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply