[11.00] Can't view certain BMP files

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Horst.Epp
Power Member
Power Member
Posts: 6495
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: [11.00] Can't view certain BMP files

Post by *Horst.Epp »

Except the PhotoViewer plugin
all other x64 configurations and image plugins display this bmp's correctly.
TC x86 without any additional settings like IrfanView doesn't work.
I guess not a real problem for most of us.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [11.00] Can't view certain BMP files

Post by *AntonyD »

2JOUBE
Not really, because, for example, a plugin that I'm very familiar with handles it quite correctly. So, searching for a reason...
I'm sorry, but your answer does not fall at all into the topic of my explanation of the situation and your incorrect statement that the BitMap file signature is the first four bytes - BMHX. No - only the first two: BM. That's why I used the phrase "you'll be surprised"... Because this new info is slightly at odds with your current knowledge;) Well, for control, I prepared links for you, where you can see - WHAT takes the first two bytes of a file of this format.
And yes - you don't need to look for anything else - the author quite accurately noted that now he will just have to work with a structure of a different size.
#146217 personal license
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [11.00] Can't view certain BMP files

Post by *AntonyD »

2Horst.Epp
I guess not a real problem for most of us.
I Agree. And it's especially true - when nearest new TC release will correctly handle such files )))
#146217 personal license
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [11.00] Can't view certain BMP files

Post by *JOUBE »

By the way: I just tested this issue by chance:

My standard image editing program is Paint Shop Pro version 4.12 from 28 Jan 1997. *)

When I try to open the "PIC_6.bmp" file with it, I get the following error message and the picture is not displayed: "This is not a valid BMP/DIB/RLE file."

Something has obviously changed in the specification of BMP files since then. (Perhaps as a note to ghisler(author)) Or other programs simply ignore the error in it. **)

Joube

*) Really my standard image editing program in many cases (I am not a graphic designer...)
**) As I said above: But a Plugin, I am familiar with, can handle e.g. "PIC_6.bmp" well.
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3299
Joined: 2003-05-06, 11:46 UTC

Re: [11.00] Can't view certain BMP files

Post by *Sir_SiLvA »

JOUBE wrote: 2023-08-17, 14:15 UTC My standard image editing program is Paint Shop Pro version 4.12 from 28 Jan 1997. *)
Why use the 4.12 if I may ask? (I myself have been using the 5.03 the last 24 years)
Hoecker sie sind raus!
User avatar
Gral
Power Member
Power Member
Posts: 1467
Joined: 2005-01-26, 15:12 UTC

Re: [11.00] Can't view certain BMP files

Post by *Gral »

I'm a big fan of Paint Shop Pro and have tried versions 1.0 to 11.20 and some higher, while I've been sticking with 7.04 for long time which is really good especially for some vector edits that were missing in earlier versions.
I sometimes use 9.01 and 10.10 which support AVIF and WEBP (with plugins)

On Paint Shop Pro versions 1.0 - 10.10 and even Paint Shop 2 and 3, this error message looks exactly the same.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00] Can't view certain BMP files

Post by *ghisler(Author) »

Something has obviously changed in the specification of BMP files since then.
Possible, but it's not mentioned in the description of the bitmapinfoheader structure I already linked in my first reply.
Or other programs simply ignore the error in it.
Maybe there were other developers who didn't read or understand the specifications and created such files with invalid header...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [11.00] Can't view certain BMP files

Post by *white »

HISTORY.TXT wrote:15.08.23 Fixed: Support bitmaps which contain an invalid header size field (including the size of the color table) (32)
Tested OK using TC 11.01 rc1 32-bit.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00] Can't view certain BMP files

Post by *petermad »

Confirmed fixed in TC 11.01rc1 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [11.00] Can't view certain BMP files

Post by *white »

Moderator message from: white » 2023-08-22, 08:27 UTC

Moved to Fixed bugs.
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [11.00] Can't view certain BMP files

Post by *JOUBE »

petermad wrote: 2023-08-22, 08:20 UTC Confirmed fixed in TC 11.01rc1 :-)
Fixed? It wasn't a bug. ;-) It's an extension, an additional feature... Thanks for extended support for invalid bitmaps. :-)
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [11.00] Can't view certain BMP files

Post by *petermad »

2JOUBE

Well, the history says: "15.08.23 Fixed: ..." not Added ;-) - maybe it should be changed to:
15.08.23 Added: Support bitmaps which contain an invalid header size field (including the size of the color table) (32)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: [11.00] Can't view certain BMP files

Post by *JOUBE »

petermad wrote: 2023-08-22, 10:05 UTC 2JOUBE

Well, the history says: "15.08.23 Fixed: ..." not Added ;-) - maybe it should be changed to:
15.08.23 Added: Support bitmaps which contain an invalid header size field (including the size of the color table) (32)
;-) I think that's over...
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [11.00] Can't view certain BMP files

Post by *ghisler(Author) »

Actually I changed it from Added to Fixed myself when gathering the changes for the announcement, because I thought that it was more like a correction than an addition...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [11.00] Can't view certain BMP files

Post by *white »

Any way, it fixed the issue ;)
Post Reply