Thumbnail view is broken with certain folder names

[Carnu41]

I am using Total Commander version 11.01 - 32-bit

It seems that thumbnail performance is poor with folders that are named a certain way. The folders are all empty and I have disabled all thumbnail loading options. It does not make a difference.

I have recorded an example video that shows the folder where the problem occurs: https://files.catbox.moe/5mkg28.mp4

I show the folder with a size field below the thumbnail (calculated using Everything) and then without that field. In both cases the performance is very poor.

These are the folder names so you can try to reproduce the issue:

Spoiler

Code: Select all

[1] 家家家家家 家家家 [AAAAAA (AAAAA AAAA)] [30A] [1A]
[2] 家家 [30A] [4A]
[3] 家家家 [AAA (AAAAAA AA AAAAAAA)] [42A] [1A]
[4] 家家家家家 [AAAAAA (AAAAAAA)] [30A] [4A]
[5] 家家 家家家家 [2A (AAAA AAAAAAAA)] [30A-12A] [3A]
[6] 家家家家家家家 [AAAAA-A AAAAA AAAA AAAA] [44A]
[7] AA家家家家家家家家家 [AAA (AAAAAA)] [30A] [1A]
[8] AA家家家家家家家家家家家家 [AAA (AAAAAA)] [30A] [2A]
[9] 家家家家 [AAAAAAAA AAAA-] [24A] [1A]
[10] 家家家家 [AAAA AAAAA-] [30A]
[11] 家家家家 [AAAAAA AAA AAAAA-] [30A] [1A]
[12] 家家家家 [AAAAAAA AAAAAAAA-] [50A-1A] [2A]
[13] 家家家家家家 [AAAAAAA AAAAA-] [22A] [1A]
[14] AA家家家家家家家家家 [AAA (AAAAAA)] [50A] [1A]
[15-] AAAA AAAA (AAAAAA) [46A]
[15] 家家 [AAAAAA-] [41A] [1A]
[16] 家家家家-家家 [AAAAAA (AAAA AAAA)] [30A] [1A]
[17] 家家 家家 [AAAAA (AAAAAAA AAAAAA)] [30A-30A] [1A]
[18] 家家家家 家家 [AAAAAA (AAAAA AAAAAAA)] [50A] [7A]
[19] 家家 家家家家家家家家家家 [AAAA - AAAAAAAAAAA AAAAA-]
[20] 家家家家家家 [AAAAA AAAAAAAA (AAAAAA AAAAA)] [45A-7A] [6A]
[21] 家家家家 [AAAAAA AAAA-] [40A] [3A]
[22] 家家家家家家家家家家家家家家 [AAAAAAAAAA-- AAAAAA AAAA AAAAAAAAAAA AAAAA--] [63A] [6A]
[23-] 家家家家家家家 [65A]
[23] 家家家 家 家家 [(AAAAAAA AA AAA AAAA)] [97A]
[24] 家家家家家家家家 [AAAAA AAAAAAAA - AAA (AAAA AAAAAA AAAA AA AAA AA AAAA)] [75A] [2A]
[25] 家家家家家 - 家家家家家 [AAA AAAAAA (AAA家AAAAAA)]
[26] 家家家家家家家2 [AAAAAAAA AAAAA (AAAAAAA AAAA 2)] [70A] [3A]
[27] 家家家家家家家 [AAAAA-A AAAAAAAAA AAAA] [75A] [3A]
[28] 家家家家 [AAAAAA AAAAAA (AAAA AAAAAA)] [95A-2A] [4A]
[29] 家家 [AAAAA AAAAA (AAAA AAAA AAAAA)] [89A-2A] [2A]
[30] 家家家家 [AAA AAAA AAAAAA] [90A-2A] [5A]
[31] 家家家家 [(AAAAAAA AA AAA AAAA)] [166A-2A] [5A]
[32] 家家家家家 家家 [AAAAAAA (AAAAAAA AAAAAA)]
[33] 家家 [AAA AAAA-] [65A-2A] [4A]
[34] 家家家家家家家 [AAAAAAA - AAA - AAA (AAAAAA)] [100A] [4A]
[35] 家家家家家家家 [AAAAA-A AAAAAAA AAAAAA] [100A]
[36] AA家家家家家家家家家家 [A AAAAAAAA AAAAA AAAA AAAA - AAA - AAA (AAAAAA)] [100A] [1A]
[37] 家家家家 [AAAAAAA (AAAAAAAAAA -AAAA)] [48A] [1A]
[38] 家家家 [AAAAA AAAAA-] [80] [2A]
[39] 家家家家家家家家 [AAAAA-A AAAAAA AAAAAA] [92A] [1A]
[40] 家家家家家家家 [AAAAA-A AAAAA AAAA AAAA] [106A] [2A]
[41] 家家家家 [AAAAAA AAAAAA AAAAA AAAA-] [81A-2A] [2A]
[42] 家家家 [AAAA A AAAAA-] [69A-2A] [4A]
[43] 家家家家 家家 [AAAAAAAAA AAAAAA-] [47A-2A] [3A]
[44] 家家家家家 [AAAAA-A AAAAA AAAA] [77A-2A] [3A]
[45] 家家家家家-家家 [AAAAAA AAAAAAA - AAAA - AAAAA (AAAAAAA AAAAAA)] [89A-2A] [4A]
[46] 家家家家家家家 [AAAAA-A AAAAAAAAAAAA AAAAAAA] [125A-2A] [2A]
[47] 家家家 [AAAAAAAAA AAAAA-] [91A-2A] [3A]
[48] 家家家家 [AAAAAAAAA-] [84A-2A] [3A]
[49] 家家家家 [AAAAAAAAA AAAAAAA] [85A-2A] [2A]
[50] 家家家家 [AAAAAAAA AAAAA] [83A-2A] [2A]
[51] 家家家家 家家家家 AAAA [AAAAAAAAA AAAA AAAAAA AAAA-] [93A-10A] [5A]
[52] 家家家家家家 [AAAAA-A AAAAA AAA AAAA] [77A] [2A]
[53] 家家家家家家家 [AAAAA-A AAAAAA AAAAAA] [73A-2A] [2A]
[54] 家家 [AAAAA AAA-] [78A-10A] [2A]
[55] 家家家家家家2 [AAAAA-A AAAAA AAA AAAA 2] [62A] [2A]
[56] 家家家家家家家 [AAAAA-A AAAAA AAAAAA] [77A-2A] [1A]
[57] 家家家家 [AAAA AAAAAA AAAAAA AAAAAA-] [77A-2A] [1A]
[58] 家家家 [AAAAAAAAAA AAAAA-] [75A-2A] [2A]
[59] 家家家家 [AAAAAAA AA AAA AAAA AAAA] [85A-2A] [4A]
[60] 家家家 [AAAA AAAA AA-] [83A-2A] [2A]
[61] 家家家家家家-家家家 [AAAAA (AAAAAAAAAA)] [71A-8A] [5A]
[62] 家家家家家家家 [AAAAA-A AAAAAAA AAAAAAAAAA] [86A-2A] [2A]
[63] 家家家 [AA AA AAAA-] [87A-2A] [2A]
[64] 家家家家 [AAAAA AAAAA AAAAAA] [88A] [2A]
[65] 家家家家 家家家 [AAA AAAA (AAAAAAAA AAAA)] [81A-8A] [1A]
[66] 家家家 [AAAAAAAAAAA-] [82A-2A] [2A]
[67] AAAAA 家家家 [AAAAA AAA AAAAAAA AA AAAAAAA] [75A-2A] [2A]
[68] 家家家 家家家 [AAAAAA (AAAAAAAA AAA)] [85A-2A] [2A]
[69] 家家家家-家家 [AAAAAA (AAAA AAAAAAA)] [78A] [1A]
[70] 家家家-家家 [AAAAA (AAAAAAAA AAA)] [73A] [1A]
[71] 家家家家-家家家 [AAAAA AAAAA - AAAAA AAAAAA-] [63A] [1A]
[72] 家家家-家家家家 [AAAA AAAAAAAA (AAAAAA AA AAAA)] [60A] [1A]
[73] 家家家家7-家家 [AAAA (AAAAA AAAAAAA AAA)] [55A]

[Horst.Epp]

For most files, TC itself doesn't create thumbnails.
So what are your Plugins
and how looks your config ?

[Carnu41]

I have now tested this on a vanilla install. You should be able to reproduce this by setting the option "GetDirSize=3" and creating a test folder with the folder names I provided. The performance should be poor. It does not matter if Everything is not installed or not.

[Carnu41]

To reproduce, try this: In a vanilla install, window maximized with all the folders visible in "Thumbnail View".

Loading the directory should take...
...about 1 second with "GetDirSize=0" (default)
...about 6 second with "GetDirSize=3" (does not matter if Everything is not installed or not)
...about 16 seconds with these options:

Code: Select all

[Configuration]
GetDirSize=3
...

[Layout]
DriveCombo=0

[AllResolutions]
FontName=Segoe UI

[ghisler(Author)]

I have tested this: It is happening because drawing these characters is exceptionally slow for unknown reasons.
In RC2, I'm now redrawing just the individual items when receiving a notification from the thumbnail thread, not the entire line. This makes loading of the thumbnails way faster, although it is still much slower than folders with English names...

[Carnu41]

Thank you. I can confirm that the performance is much improved in RC2. Additionally, of all the fonts on my system, SimSun is the fastest one I tried.

It's interesting that redrawing the characters causes this problem, given that TC initially draws them pretty much immediately.

[ghisler(Author)]

The reason was that TC was refreshing an entire line of thumbnails when just one of them changed. When using custom fields below the thumbnails, and for folders, this could result in 3 refreshes per item (icon, thumbnail, custom fields). Now it's refreshing just the changed item. When there are, for example, 10 thumbnails per line, it makes the refresh 10 times faster.

[JOUBE]

When using custom fields below the thumbnails, and for folders, this could result in 3 refreshes per item (icon, thumbnail, custom fields). Now it's refreshing just the changed item. When there are, for example, 10 thumbnails per line, it makes the refresh 10 times faster.

This seems to me to be a pretty significant change that impacts TCs thumbnails everywhere.

I had the impression - independent of this thread - that with 11.02RC1 or even with Tc11.02RC2 the display of the thumbnails had accelerated significantly. Apparently this impression was not wrong. May be this is the reason of it.

Very nice and important change.

Joube

[ghisler(Author)]

Moderator message

Moved to fixed bugs