[TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *white »

Typo:
HISTORY.TXT wrote: 13.10.23 Added: wincmd.ini [Configuration] SkipLineNumbers=1 skips all digits at the start of a line until the first non-digit (32764)
(32764) -> (32/64)
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *AntonyD »

typo 2:
Not SkipLineNumbers but CompareSkipLineNumbers!
omField DriveHints RemovableInTemp CompareCaseSensitive CompareFindLines CompareSkipFirstL CompareSkipFirstR CompareSkipLineNumbers CompareMaxLen CompareIgnoreRepSpace CompareIgnoreRepeatedLines CompareVertical CompareSaveOriginal CompareTwoLineList CompareDeleteBak Compa
partial quote from TOTALCMD.EXE
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *petermad »

It is correct (CompareSkipLineNumbers not SkipLineNumbers) in the Help:
Help wrote:CompareSkipLineNumbers=0 Compare by content:
1: Skip line numbers at the start of each line
But the description in the Help is misleading - line numbers are the numbers in front of each line. - the Help should use the description from the history:
1: Skip all digits at the start of a line until the first non-digit
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *ghisler(Author) »

What do you mean with misleading? The "numbers in front of each line" would be misleading because that's the numbers the compare tool itself shows. The numbers which get skipped are at the start of each line.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *white »

ghisler(Author) wrote: 2023-10-19, 08:58 UTC What do you mean with misleading?
It is misleading because "Skip all digits at the start of a line until the first non-digit" means any possible number is skipped, not only line numbers.
Perhaps change
Skip line numbers at the start of each line
into
Skip any number at the start of each line (meant for ignoring line numbers in a file)
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *petermad »

would be misleading because that's the numbers the compare tool itself
Exactly my point.

That's why the word "digits" should be use instead of "numbers" in the Help, just as it is in history.txt
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *ghisler(Author) »

OK, if you think that this is better, I will change it.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *petermad »

2ghisler(Author)

I think so. By using the word digits in the help for this parameter, there is much less risk of confusing it with "the numbers the compare tool itself shows".
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *white »

white wrote: 2023-10-18, 15:22 UTC Typo:
HISTORY.TXT wrote: 13.10.23 Added: wincmd.ini [Configuration] SkipLineNumbers=1 skips all digits at the start of a line until the first non-digit (32764)
(32764) -> (32/64)
AntonyD wrote: 2023-10-18, 17:33 UTC typo 2:
Not SkipLineNumbers but CompareSkipLineNumbers!
Tested OK using TC 11.02rc4.
petermad wrote: 2023-10-18, 18:03 UTC
Help wrote:CompareSkipLineNumbers=0 Compare by content:
1: Skip line numbers at the start of each line
But the description in the Help is misleading - line numbers are the numbers in front of each line. - the Help should use the description from the history:
1: Skip all digits at the start of a line until the first non-digit
Changed in TC 11.02rc4 as requested, except for the word "a", which is replaced by "each":
(Help - Ini File Settings part 1: Configuration A-M) wrote:1: Skip all digits at the start of each line until the first non-digit
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *ghisler(Author) »

I think that "each" is more clear than just "a". Why would you prefer "a"?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *white »

ghisler(Author) wrote: 2023-10-25, 13:27 UTC I think that "each" is more clear than just "a". Why would you prefer "a"?
The suggestion was to use the same wording you used in HISTORY.TXT:
history.txt wrote:13.10.23 Added: wincmd.ini [Configuration] CompareSkipLineNumbers=1 skips all digits at the start of a line until the first non-digit (32/64)
I was merely pointing out that it is different than suggested. I did not mean to imply that "a" is preferable to "each". The wording with "a" originates from you, so only you can answer your question.
TychoBarfy
Senior Member
Senior Member
Posts: 347
Joined: 2005-08-13, 15:13 UTC
Location: Berlin, Germany
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *TychoBarfy »

Only a small one in TC 11.02rc4: :mrgreen:
20.10.23 Fixed: Get directory sizes didn't work correctly on Windows 9x/ME (no recursion into subdirectories) (32)
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *petermad »

ghisler(Author) wrote: 2023-10-25, 13:27 UTC I think that "each" is more clear than just "a". Why would you prefer "a"?
I think "each" is better than "a".
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *ghisler(Author) »

Only a small one in TC 11.02rc4
See my fix to the online version:
https://www.ghisler.com/history1102.txt
I think "each" is better than "a".
OK, I will keep it like that.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.02rc3] HISTORY.TXT: typo (32764) -> (32/64)

Post by *white »

ghisler(Author) wrote: 2023-10-26, 08:54 UTC
Only a small one in TC 11.02rc4
See my fix to the online version:
https://www.ghisler.com/history1102.txt
Confirmed.

Moderator message from: white » 2023-10-26, 09:27 UTC

Moved to Fixed bugs.
Post Reply