File compare tool: Add keyboard shortcut to tooltip for the Save button

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *white »

* Select two files and choose menu option Files/Compare by Content
* Hover the mouse over the Save button
A tooltip is shown with the text "Save". I suggest including "(Ctrl+S)" to display the keyboard shortcut, similar to the tooltips for the Find and Find Next buttons.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *petermad »

Good idea. It is just a change to string 1612 in the .lng file - I don't think that string is used anywhere else, but Christian must know that.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *ghisler(Author) »

String 1612 is also used in the title of the dialog to save the selection when saving settings in "Synchronize dirs":
1. Select files
2. Synchronize dirs
3. Click on folder button
4. Choose "Add current directories and settings to list"
5. Enter name
6. Confirm dialog
-> dialog to save selection to file starts with string 1612.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *white »

So the suggestion is to solve that. For example by adding a separate string for the save selection dialog, or by adding a string for the keyboard shortcut.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *petermad »

or by adding a string for the keyboard shortcut.
I vote for that - it could be a new string 1489, just before the two related strings:
1490="Find (F7)"
1491="Find next (F3)"
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *ghisler(Author) »

Why would it need a new string? The hotkey could be appended programmatically.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *JOUBE »

ghisler(Author) wrote: 2023-11-15, 21:55 UTC The hotkey could be appended programmatically.
Oh, no. Don't do such things.
Last edited by JOUBE on 2023-11-15, 22:11 UTC, edited 1 time in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *ghisler(Author) »

Why not?
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *JOUBE »

ghisler(Author) wrote: 2023-11-15, 22:11 UTCWhy not?
- Translations... Some people e.g. in german language do not like Strg+S but Ctrl+S, or Ctrl-S... and want to change it themselfs for there needs/wishes in lng file.
- Hardcoding is against the TC rules, if soft configuring is possible
- This info about the shortcut is not a must at this button
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *ghisler(Author) »

Translations aren't an argument, the keys are translated in strings 5282..5284 and 5299.
Adding a string would be better than modifying an existing one which is already used for other things.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: File compare tool: Add keyboard shortcut to tooltip for the Save button

Post by *JOUBE »

Ever heard of SAA (Systems Application Architecture), CUA (Common User Access) and - following - Windows Keyboard shortcuts?

If someone - pointlessly - want to write down obvious shortcuts again, he make it clear that he have no interest in these similarities and no understanding of these common features of a user interface.

The Tc shouldn't do that to itself.

Joube
Post Reply