Minor visual issue in FTP dialog

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Minor visual issue in FTP dialog

Post by *wanderer »

FTP dialog, new connection -> The "local dir" textbox is 1 pixel left of all the others. Also, its right border is not visible because it's under the >> button.

Issue appears in both TC versions (x32 and x64).
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Minor visual issue in FTP dialog

Post by *ghisler(Author) »

Confirmed.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Minor visual issue in FTP dialog

Post by *ghisler(Author) »

This should be fixed in Total Commander 11.03 RC1, please check it!
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: Minor visual issue in FTP dialog

Post by *JOUBE »

No, sorry, textbox comes left 1 pixel but is still to long. So it ends still under the button (Windows Scale 150%)
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Minor visual issue in FTP dialog

Post by *wanderer »

JOUBE wrote: 2024-01-18, 16:12 UTC No, sorry, textbox comes left 1 pixel but is still to long. So it ends still under the button (Windows Scale 150%)
Confirmed. I have 100% Windows scale but in TC i have Font/DPI set to 120 and indeed "is still to long. So it ends still under the button". I also tried it with the default DPI but nothing changed, the same problem exists.

Also, the button is 1 pixel down and 1 pixel left from where it's supposed to be.

https://imgur.com/a/h6WyHdB

Above the red line: what exists now
Below the red line: what it should be
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Minor visual issue in FTP dialog

Post by *AntonyD »

Dark Mode has another issue: https://ibb.co/hFzbWrd

2wanderer
IMHO on your "slightly changed" view does not take into account that fact what the right-most border of editbox
for entering Local Dir does not exist - it's undercover by a button ">>" pressed very closely to it on the right side.

In my view for dark mode, you can see that this border is drawn - but even here this button is TOO tightly pulled.
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Minor visual issue in FTP dialog

Post by *ghisler(Author) »

Unfortunately this is caused by the option "Automatically adjust dialog boxes to larger fonts" or a different DPI value. In both cases, the dialog boxes get scaled, and there will always been small rounding errors which can move the button 1 pixel more to the left or the right. For example, the width of the edit box becomes just slightly larger than an integer value, and the left coordinate of the button just slightly smaller, so the distance becomes 1 pixel smaller.

I will therefore add one more pixel distance, but also move this thread to "will not be changed" because it will never be possible to fix this 100%.

Moderator message

Moved to will not be changed
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Minor visual issue in FTP dialog

Post by *AntonyD »

this is caused by the option "Automatically adjust dialog boxes to larger fonts"
If I have DPI unchanged from system default and this checkbox I UN-checked - does not it mean
that I should NOT face with such problem?
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Minor visual issue in FTP dialog

Post by *ghisler(Author) »

Here on Windows 11 it looks right when unckecking "Automatically adjust dialog boxes to larger fonts" and using 96DPI (100%) Windows font scaling.
Author of Total Commander
https://www.ghisler.com
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Minor visual issue in FTP dialog

Post by *wanderer »

OK, ball lost. We have talked about many different issues and variations of them. Let's wait for the next release and see what is shown with the changes Christian has made. IMO it should look as "proper" as possible in the normal 96DPI case in both Win10 and Win11. In other cases, understandably, issues should be expected.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
JOUBE
Power Member
Power Member
Posts: 1477
Joined: 2004-07-08, 08:58 UTC

Re: Minor visual issue in FTP dialog

Post by *JOUBE »

It not really a serious issue.
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Minor visual issue in FTP dialog

Post by *wanderer »

JOUBE wrote: 2024-01-19, 10:23 UTC It not really a serious issue.
Nobody said that it is, we just like things to look nice. :)
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
wanderer
Power Member
Power Member
Posts: 1578
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Re: Minor visual issue in FTP dialog

Post by *wanderer »

OK, the original issue with the textbox has been corrected (tested under Win10 and WinXP). Now it appears in the right position with the proper width, without any of its parts being cut.

The button however still has some visual issues. All of these have been checked with the default DPI settings.
- Under Win10, it seems to be 1 pixel down from where it's supposed to be, and its height is 1 pixel shorter.
- Under WinXP, it seems to be 1 pixel down from where it's supposed to be, but its height seems to be correct.

I noticed the above, so i mention them here for the shake of completeness. Really don't expect them to be "corrected".
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3
x64: Clients/Servers from Win7 to Win11 and Win2K12Srv to Win2K22Srv, mainly Win10 though.
User avatar
AntonyD
Power Member
Power Member
Posts: 1249
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Minor visual issue in FTP dialog

Post by *AntonyD »

As to me - now both modes (normal, dark) look pretty nice. Good job ;)
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Minor visual issue in FTP dialog

Post by *ghisler(Author) »

The problem is that the configured button dimensions don't always match what the theme draws.
Author of Total Commander
https://www.ghisler.com
Post Reply