+[8.50b1x32]Infinite loop with dialog asking for next volume

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

+[8.50b1x32]Infinite loop with dialog asking for next volume

Post by *MVV »

Try to open multivolume RAR (1st volume, password-protected w/o names encryption), TC asks for 2nd volume, if I click Cancel (or Close) TC asks for 2nd volume again and again. When I close TC instead, I see infinite blinking dialogs until I kill process.
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

2MVV
looks like unrar.dll problem. Try samlab's 5.0.7 version instead of internal 5.0.2.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Tried with UNRAR.dll from TC 8.01 - asks only twice, so it seems that it is really UNRAR.dll problem. Or maybe TC callback returns wrong error code?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48124
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I can reproduce the problem, thanks!
Author of Total Commander
https://www.ghisler.com
ollyhal
Junior Member
Junior Member
Posts: 6
Joined: 2013-08-29, 05:57 UTC

additional info

Post by *ollyhal »

only a little bit additional info:

it´s seems to happen with every multivolume RAR-archive if one part (except the first) is missing. In my case the archive was not password protected. I had only the first part.

In TC 8.01 I could see the contents of an archive if I open the first part. The other parts were not needed.

In TC 8.5 it keeps asking me for the other parts. I have to kill the task.

Regards, Olly

P.S.: Win 7/64, TC 8.5 Beta 64 Bit
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48124
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is unfortunately a misfeature of unrar.dll - I have to use that now instead of my own RAR name parser because the format is much more complex now with RAR5. I also need to do that to support encrypted file names. I will check whether I can find any solution.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Maybe you can make modified version of UNRAR.DLL w/o such bug? It is open-source anyway.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48124
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

It was a parameter error on my side: In the RarCallbackProc function, I need to return -1 as "Cancel", not 0 as it was with the old ChangeVolProc function.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Fixed in beta 2, thanks!
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Please move to fixed.
henrid
Junior Member
Junior Member
Posts: 2
Joined: 2013-12-07, 19:14 UTC

Post by *henrid »

The loop error has been solved, but I still can't open any part (while others are missing) displaying contents, like I could in TC 8.01.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

henrid,
I think this topic is for you: http://www.ghisler.ch/board/viewtopic.php?t=38202
henrid
Junior Member
Junior Member
Posts: 2
Joined: 2013-12-07, 19:14 UTC

Post by *henrid »

Okay thanks anyway. It's a hot topic I see, but I guess it will not be solved anymore. I used the option to enter a specific complete or even incomplete part to copy correct files out of it.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Strange, I downloaded WinRar, made an archive with volumes file.r00, file.r01, file.r02, file.rar. When I enter .rar, TC 8.50b12 shows full archive contents, in .rxx it shows only files from that volume.
Even if I move volumes to separate directories, I can see files (except partial ones). I press Enter on a volume, then press Cancel in ask for next volume dialog and click OK on bad archive error message, and TC shows partial volume contents.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48124
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

There is one difference between TC 8.01 and TC8.5 beta (using unrar.dll) handling multi-volume archives when the next part is missing: The older version showed all files starting in that archive part, also partial files. The new version shows all files which are completely contained in that archive part. This is what unrar.dll returns.
Author of Total Commander
https://www.ghisler.com
Post Reply