Modifications made to forum software

English support forum

Moderators: white, Hacker, petermad, Stefan2

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Modifications made to forum software

Post by *ghisler(Author) »

I have just made the following modification to the forum software: To avoid a desaster as with Norfie who deleted all his posts, I have limited the time you can edit a post to 8 days. Please keep this in mind when you post here! This modification should give the forum a bit more stability.

If you want something removed for any reason, you can contact a moderator or myself.

Please write your comments in this thread, e.g. if you find 8 days too short or too long.
Author of Total Commander
https://www.ghisler.com
User avatar
SanskritFritz
Power Member
Power Member
Posts: 3693
Joined: 2003-07-24, 09:25 UTC
Location: Budapest, Hungary

Post by *SanskritFritz »

Good idea! I think even one day is more than sufficient. I only deleted a post, when it was a double post, or someone was quicker than me, with the same answer. For this, one day should be enough ;-)
Thanks Christian!
I switched to Linux, bye and thanks for all the fish!
User avatar
van Dusen
Power Member
Power Member
Posts: 684
Joined: 2004-09-16, 19:30 UTC
Location: Sinzig (Rhein), Germany

Post by *van Dusen »

Don't know, if the forum's software allow this, but would be sensible IMO:

The first posting should be kept editable infinite for the originator of a thread. Would be useful for plugin authors, who like to give information about news about their software (new versions etc.). Would be useful for all other thread authors too, if they like to change the thread title (if problem is solved, for instance).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2van Dusen
That's a valid point - I will check whether that would be possible.

2SanskritFritz
I chose 8 days for those who visit the forum once a week, and notice when they come back that they made a big mistake a week before.
Author of Total Commander
https://www.ghisler.com
sjoerdve
Junior Member
Junior Member
Posts: 5
Joined: 2006-01-16, 20:37 UTC
Location: Switzerland

Feed

Post by *sjoerdve »

Hi, works fine with opera 8.51 as well. just click and go.
great work
Sjoerd
User avatar
X-Byte
Member
Member
Posts: 173
Joined: 2004-11-29, 09:34 UTC
Location: Hessen, Germany

Post by *X-Byte »

I just stumbled upon this "new feature".

I support van Dusen's suggestion to keep the first post editable. This is not only necessary for problem reports but for plugin/supplemental developers as well.
I'd like to keep my initial posting up to date, with current links and informations, followed by the postings discussing problems and suggestions for the more interested people.

I don't want to be forced to request an administrator to update my posting. :?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Please do this until I find a solution to this problem! Just append a message to the thread, e.g. new version available, urls: xyz (moderator: Please update first post).
Author of Total Commander
https://www.ghisler.com
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

[REQ forum] Remove 8 days rule...

Post by *icfu »

...because threads are starting to get polluted with superfluous update postings that make it more difficult to find the content one is interested in, not only in the threads itself but also by using the forum search! At least leave edit functionality active in the first posting of each thread so plugin/tools/script authors have a chance to correct content later.

norfie's amok run may sound like a good reason for the limit but if it means giving up freedom it's a very bad choice.

Edit: This posting has been a separate request before and been merged with this thread.

Icfu
Last edited by icfu on 2006-02-08, 20:29 UTC, edited 1 time in total.
This account is for sale
User avatar
Hacker
Moderator
Moderator
Posts: 13065
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

At least leave edit functionality active in the first posting of each thread so plugin/tools/script authors have a chance to correct content later.
That probably isn't as easy as it might seem.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

If it's not possible, the change should be reverted.

Icfu
This account is for sale
User avatar
Lesmo16
Senior Member
Senior Member
Posts: 380
Joined: 2005-02-07, 07:18 UTC
Location: Germany

Post by *Lesmo16 »

icfu wrote:If it's not possible, the change should be reverted.
Support!
Everyone believing in telekinesis, raise my hand!
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

Pass ?

Post by *Clo »

2Hacker

:) Hi Roman !

- What about a password on an "Edit time-out" message ? Each author of plugin ¦Tool etc could have his¦her one; there is stuff able to assign randomly the normal passwords to the users who lost it, maybe it could be used also in that way ?
- New authors would have to get one, but there, this no longer my biz…

:mrgreen: KR
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
User avatar
corny
Junior Member
Junior Member
Posts: 96
Joined: 2003-02-07, 10:06 UTC

Post by *corny »

Please take a look at this modification. It does exactly the opposite, only enables editing the last message in the topic, but I guess it is a minor change to get the wanted behaviour (only editing the first message).

btw, it also includes a restriction in the time posters have to edit a message, this can be ignored I think.
Regards,
Cornelis
User avatar
Hacker
Moderator
Moderator
Posts: 13065
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Clo,
What about a password on an "Edit time-out" message ?
I am no expert at phpBB or PHP on general, nor do I have an overview of what mods exist for phpBB, so I guess I can't help much here. Hopefully corny's link proves to be useful.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
corny
Junior Member
Junior Member
Posts: 96
Joined: 2003-02-07, 10:06 UTC

Post by *corny »

Good shot, few glitches in it.

$post_data['first_post'] is true or false, doesn't contain the post_id.
$lang['Cannot_edit_replied'] isn't available in the vanilla phpBB

I think code is as shown below:

Code: Select all

#
#-----[ OPEN ]------------------------------------------
#
posting.php
#
#-----[ FIND ]------------------------------------------
#
      $sql = "SELECT f.*, t.topic_id, t.topic_status, t.topic_type, t.topic_first_post_id, t.topic_last_post_id, t.topic_vote, p.post_id, p.poster_id" . $select_sql . "
#
#-----[ REPLACE WITH ]------------------------------------------
#
      $sql = "SELECT f.*, t.topic_id, t.topic_status, t.topic_type, t.topic_first_post_id, t.topic_last_post_id, t.topic_vote, p.post_id, p.post_time, p.poster_id" . $select_sql . "
#
#-----[ FIND ]------------------------------------------
#
      $post_data['poster_id'] = $post_info['poster_id'];
#
#-----[ AFTER, ADD ]------------------------------------------
#
//+MOD: Disallow editing certain posts for members

      if( $userdata['user_level'] != ADMIN && $userdata['user_level'] != MOD )
      {        
          // Only allow editing the first post of a thread or posts newer than 8 days.
          // 8 days timeout --> 60 seconds * 60 minutes * 24 hours * 8 days.
         if(!$post_data['first_post'] && (time() - $post_info['post_time']) > 300691200)
         {
            message_die(GENERAL_MESSAGE, $lang['Cannot_edit_oldposts']);      
         }         
      }

//-MOD: Disallow editing certain posts for members
#
#-----[ OPEN ]------------------------------------------
#
language/lang_english/lang_main.php
#
#-----[ FIND ]------------------------------------------
#
?>
#
#-----[ BEFORE, ADD ]------------------------------------------
#
//+MOD: Disallow editing old posts
$lang['Cannot_edit_oldposts'] = "Sorry, but you may not edit posts older than 8 days except the first post.";
//-MOD: Disallow editing old posts

#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM
Regards,
Cornelis
Post Reply