External compare tool, compare folders

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Sly
Junior Member
Junior Member
Posts: 10
Joined: 2006-08-02, 19:46 UTC

External compare tool, compare folders

Post by *Sly »

I'm using 7.0 RC1, have custom compare tool (Araxis Merge) defined with wincmd.ini. I run compare operation with keyboard shortcut.

There are have place following behavior:

I have two folders with same names but different paths present on both panels.

1) from the left panel: compare operation opens Merge and passes single folder name from the left panel (one folder passed to command line)

2) mark folders on both panels with selection and running compare brings the same result: Merge opened with left panel's folder name (one folder passed to command line)

3) mark two folders with selection on the same panel and running compare opens Merge which opens both folders for comparison (both selected folders passed to Merge command line)

I expect to have the same behavior for all three cases with folders, as described in case #3 (the same as for files)

Thanks.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

TC always passes both paths to the external compare tool. Maybe the combined names of compare tool, left and right path are just too long?
Author of Total Commander
https://www.ghisler.com
User avatar
sqa_wizard
Power Member
Power Member
Posts: 3867
Joined: 2003-02-06, 11:41 UTC
Location: Germany

Post by *sqa_wizard »

2Sly: Same behavior with WinMerge. (tried short paths without spaces)

But AFAIK the "CompareTool=" entry is for FILE compare only ... You are comparing folders !

I know "Araxis Merge" as well as "WinMerge" could compare Folders too...


2ghisler(Author): May the paths (and only the path, no filename) are not handled correctly in this case ?
#5767 Personal license
Sly
Junior Member
Junior Member
Posts: 10
Joined: 2006-08-02, 19:46 UTC

Post by *Sly »

TC always passes both paths to the external compare tool. Maybe the combined names of compare tool, left and right path are just too long?
I've checked the command line of started Winmerge with Sysinternals Process Explorer, the only one path passed (from active panel). also, I've checked with short folders names like d:\Install and e:\install on both panels, the same result (my wincmd.ini entry short enough: Comparetool=e:\Sly\Winutils\ARAXIS~1.5\Merge.exe).
But AFAIK the "CompareTool=" entry is for FILE compare only ... You are comparing folders !
it works nice if I have marked two folders on the same panel. if "CompareTool" parameter is for FILE compare only, it would be _very_ useful to have the same behavior for folders. IMHO: let users decide how to use this configuration key: if its compare tool does not support folders comparison -- user will never use compare of folders from TC. but if the tool can -- user would be happy to not enter paths manually to compare tool, started from TC.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Ah, sorry, I didn't notice that you want to compare folders! Currently the tool is only for comparing files. I will add comparison of folders too if one is selected in each panel.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14856
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I will add comparison of folders too if one is selected in each panel.
Why do they both have to be selected - couldn't it just be done if there are two folders with the same name, and the cursor is placed on one of these folders? - just as with files.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, that's what I meant too, it's almost the same function.
Author of Total Commander
https://www.ghisler.com
Sly
Junior Member
Junior Member
Posts: 10
Joined: 2006-08-02, 19:46 UTC

Post by *Sly »

Great, thank you!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This should work now, please check!
Author of Total Commander
https://www.ghisler.com
Sly
Junior Member
Junior Member
Posts: 10
Joined: 2006-08-02, 19:46 UTC

Post by *Sly »

quick check: it works.

thanks for fixing that!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Great, thanks for checking!
Author of Total Commander
https://www.ghisler.com
Post Reply