TC7 RC2 Access violation

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Reva
Junior Member
Junior Member
Posts: 29
Joined: 2003-02-12, 12:38 UTC

TC7 RC2 Access violation

Post by *Reva »

Minor Error

Step# 1: Create+save a large text file in any folder (ensure file is little large)
Step# 2: View file using tc lister (F3)
Step# 3: Scroll to the end of file in the lister
Step# 4: Now go back to tc and delete the file
Step# 5: back to lister try page up once or twice

After a friendly error message an AC occurs
User avatar
petermad
Power Member
Power Member
Posts: 9814
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad »

Confirmed :!:
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Post by *Alextp »

Lister should close ifself when it detects file was deleted...
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39940
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks, I could reprouce it. It's releated to cursor positioning, something which wasn't present in TC 6.56 or older...
Author of Total Commander
http://www.ghisler.com
User avatar
Hacker
Moderator
Moderator
Posts: 11810
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Alextp,
Lister should close ifself when it detects file was deleted...
No, absolutely not.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Post by *Alextp »

2Hacker
Ok, at last it should close currently opened file.
User avatar
Hacker
Moderator
Moderator
Posts: 11810
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Alextp,
If the currently opened file is the one that was deleted then again - not.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
petermad
Power Member
Power Member
Posts: 9814
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad »

2Hacker

By the time Lister finds out that the file is not there (after scrolling up) the data most likely isn't in memory anymore, hence it can't be retrieved for viewing - remember we are talking about big files - small files wil stay viewable in lister even if they are deleted (but you can not save a small file if it is deleted!)
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39940
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This should be fixed in RC3 now, please test!
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 9814
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad »

This should be fixed in RC3 now, please test
It is - but I don't think to the liking of Hacker ?
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39940
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Lister doesn't close itself when it cannot read a file. It may be a temporary network outage, or something else which can be fixed...
Author of Total Commander
http://www.ghisler.com
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

[TC7 rc3] Deleting the file that is currently viewed in lister still causes an access violation.
This seems to NOT happen while viewing the beginning of the file.

To reproduce:
- open a large file in internal lister (in my case a log-file in text format, size 2.5 MB)
- turn cursor on
- scroll down to about the middle of the file (PageDown-key or use scrollbar with mouse)
- delete the viewed file
- scroll down a few more pages in lister, until TC pops up the dialog "File not found!" with the viewed filename
- confirm the popup
=> the access violation occurs:
Screenshot 1

If cursor is not turned on (F6) it is a bit different:
- first no access violation occurs, instead the screen keeps empty, the scrollbar keeps in its old place (movable, but jumps back to its position after releasing the left mouse button).
- clicking into the empty text-window with left mouse button produces a similar access violation (same violation address, other read address, probably because of other file position)
Screenshot 2

Edit: Occurs under W2k SP4 & XP SP2.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

No crash here

Post by *Clo »

2StatusQuo

:) Hello !

• I cannot confirm here under Win XP-Pro SP1

• I followed your steps scrupulously, all is OK till I confirm the error message,
but then Lister displays an empty page - that seems normal- and TC does not crash at all.

• Tested with a 2.6 MiB text file (I'd to make it, because I'd not any so big)

:mrgreen: KR
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
User avatar
petermad
Power Member
Power Member
Posts: 9814
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad »

I can confirm it under Win XP SP2 with TC7rc3

Try the following:

1. make a copy of the current TC history.txt file (300435 bytes)
2. open the file in Lister with cursor turned on
3. scroll down to 50%
4. delete history.txt
5. scroll further down using the PgDn key
6. when the "File not found" error box pops up klick the OK key

7. This box pops up

---------------------------
Total Commander
---------------------------
Access violation at address 005B434D. Read of address 00C97DE3.
Please report this error to the Author,
with a description of what you were doing when this error occured!
Continue execution?
---------------------------
Ja Nej
---------------------------


The read of adress may vary, but the violation seems to happen at the same address every time.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 9814
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad »

If cursor is not turned on (F6) it is a bit different:
- first no access violation occurs, instead the screen keeps empty, the scrollbar keeps in its old place (movable, but jumps back to its position after releasing the left mouse button).
- clicking into the empty text-window with left mouse button produces a similar access violation (same violation address, other read address, probably because of other file position)
This is what I get if I use a 6.3Mb text file - but here it doesn't matter whether the cursor is on or off.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply