[8.0ß2-x64] Hotkeys in Lister menu right-aligned

[Flint]

Probably, related to this bug.

In the main menu of the Lister window all hotkeys are right-aligned, not left-aligned (like in top-level menu of the main window, or in 32-bit TC's Lister menu).

[ghisler(Author)]

Actually right-aligned is correct for Windows Vista and 7 with visual styles. I have changed that now in beta 3 main menu.

[karlchen]

Hello, Christian.

I can confirm that the hotkeys in the lister menus are right-aligned in Total Commander 8.0ß3 64-bit.
They are left aligned in Total Commander 8.0ß3 32-bit.
Look at the position of "W" and "F6" in the Option menu and compare them to the 64-bit version, please. => tc8b3-x32-vs-x64-lister-.png

Not that I care too much about the difference. But others may do so. And, as a matter of fact, left-aligned looks better, in particular for hotkey names like F1, F2 ... F12, i.e those which consist of more than a single letter.

Server 2008 R2, classic theme, english
Total Commander 8.0ß3 32-bit and 64-bit
lister using the default fonts

Note:
Below the screenshots the term "accelerator key" is used instead of "hotkey", "hotkey" would have been the right term though.

Kind regards,
Karl

[ghisler(Author)]

The bug and fix was only for the 64-bit version. The 32-bit version should behave the same as TC 7.56a. Btw, I'm getting right-aligned menus with Windows 7 Aero-Glass.

Right aligned menus seem to be limited to Windows Vista or newer, I don't know about Server 2008 R2.

[Flint]

Right aligned menus seem to be limited to Windows Vista or newer, I don't know about Server 2008 R2.

I have now tested WinServer 2008R2. If classic theme is chosen all hotkeys in its Notepad are left-aligned; if Windows 7 Basic theme is set hotkeys are right-aligned.

[ghisler(Author)]

I can confirm that the hotkeys in the lister menus are right-aligned in Total Commander 8.0ß3 64-bit.
They are left aligned in Total Commander 8.0ß3 32-bit.

I have decided to keep it like this for the moment. It seems that when themes are off, lister uses left-alignd menus too on Windows Vista and newer, so the 32-bit version would be right. However, Lazarus always draws them right-aligned on these Windows versions, independent from whether themes are on or off.

[Flint]

However, Lazarus always draws them right-aligned on these Windows versions, independent from whether themes are on or off.

And how do you draw the menu of the main TC window? Currently it works correctly in both x32 and x64 TC versions: in XP and Win7 Classic themes the hotkeys are left-aligned, and in Win7 Basic/Aero themes they are right-aligned. Is it too hard to implement the same mechanism for Lister and SyncDirs context menu?

[ghisler(Author)]

The main menu is owner-drawn to support all the different types of icons and checkmarks. The lister menu and all context menus are drawn by Lazarus.

[Botvinko]

I'm getting right-aligned menus with Windows 7 Aero-Glass.

Right aligned menus seem to be limited to Windows Vista or newer, I don't know about Server 2008 R2.