[8.50b1] Add ability to call by F4 editor ......

Here you can propose new features, make suggestions etc.

Moderators: Hacker, petermad, Stefan2, white

User avatar
Stefan2
Power Member
Power Member
Posts: 4281
Joined: 2007-09-13, 22:20 UTC
Location: Europa

Post by *Stefan2 »

AntonDudarenko wrote:It's an amazing situation!
Author STILL did not say anything!
Is it hard of not hard to implement - does he agree or disagree - and why....

I am still voting for quickest implementation of this feature in the nearest beta of TC.
The Author is busy with fixing the current betas, no new features are planned to get implemented. (there is a posting somewhere)

Perhaps ask again after the final release.


.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50873
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Unfortunately it's not so easy, because TC would have to somehow monitor what the editor does, and re-upload/re-pack the file if necessary. There are all kinds of problems, especially with multiple document editors, where Windows doesn't return a process handle to monitor.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1665
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Post by *AntonyD »

why you should monitor actions from editor's side?
we are talking about the listbox with results of searching!
it should be not matter - what was done with files from this list.
And what ALSO is strange - F3 is calling ONLY Lister window! even if I said at settings that by F3 the external program should be used!
So - you've hardcoded F3 for this listbox with calling only Lister win - and now you are saying that to add support for F4 is hard?

You are saying that problems can be found with archives. SIMPLY - do not allow using F4 for such files as a quick decision - only show the warning dialog with explanations WHY right now we can't use F4.
It will be practically the same action - like when you are graying button "feed to panel" in case when files were found at archives...
A little be further obviously that such limitation can be avoided.
#146217 personal license
Nagger
Junior Member
Junior Member
Posts: 19
Joined: 2004-10-24, 22:45 UTC

Post by *Nagger »

I also miss this feature very much.

Editing 'normal' files would be enough, no need to support files in archives and so.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50873
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

You can edit normal files via right click context menu. Just add internal commands (via internal associations, leave the open verb empty) if there aren't any system associations to edit.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1665
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Post by *AntonyD »

the same "simple" suggestion - do not forget pls, to remove existing hardcoded capability to view the file by F3 - because an availability of such feature mixes the understanding of actions which can be and can't be done in listbox with file's searching results.

IF we can't do F4 - it must be easily clear that we also should not do F3. ALL actions should be done ONLY via context menu or special internal commands, linked by user's himself to some key's shortcuts....
#146217 personal license
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

ghisler,
Since TC doesn't merge context menu actions for different templates, it is a pain to add 'edit' action to all types.
blind12
Junior Member
Junior Member
Posts: 25
Joined: 2004-04-22, 17:06 UTC

Post by *blind12 »

+1
User avatar
Balderstrom
Power Member
Power Member
Posts: 2148
Joined: 2005-10-11, 10:10 UTC

Post by *Balderstrom »

MVV wrote:ghisler,
Since TC doesn't merge context menu actions for different templates, it is a pain to add 'edit' action to all types.
Different issue, but could likely be fixed by allowing "fall-through" or "priority" for internal associations.

E.g. Define,
---> "EDIT" internal association for *.* (all files) priority 0
---> "EDIT" internal association for *.ini, priority 1

Another approach would be to allow Internal Associations to have rules applied like is used for e-mail filters (e.g. Opera's M1, etc)

---> "EDIT" internal association:
-------> Apply to [All Files: Except] [comma-delimited-list|regex|glob]
-------> Apply to [Exact Match] ...
-------> Apply to [Does Not Match] ...
::: Allow multiple rules to be applied to a given Internal Association filter.

TC also uses similiar type rules in the ALT+F7 (Find Files) plugins dialog.
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Balderstrom, we already have templates as filters so additional filtering is not needed.
What we need is allowing multiple items with same names by appending template names or indexes to these names, e.g. Edit (*.txt), Edit (*.bmp), Edit (Images) so user would distinguish them (or find this item and rename it if he wants).
User avatar
AntonyD
Power Member
Power Member
Posts: 1665
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Post by *AntonyD »

or more simply and general decision - to allow using of F4 key in a listbox with search results.
if Ghisler somehow hardcoded F3 using - obviously that to hardcode F4 - should be more-or-less easy.
and we do not talk about supporting of those actions in archives - as a first step of course.... at next version this feature could be improved a lot....
#146217 personal license
hi5
Power Member
Power Member
Posts: 642
Joined: 2012-11-03, 11:35 UTC
Contact:

Post by *hi5 »

If you use AutoHotkey it is relatively easy to using this script, not entirely foolproof but works for me

Code: Select all

Editor=notepad.exe ; you can change your path here OR read from the INI file
#IfWinActive, ahk_class TFindFile
F4::
ControlGet, EditFile, Choice,, LCLListBox2, ahk_class TFindFile
IfNotInString, EditFile,[ ; make sure you haven't selected a directory or the first line
  Run, %editor% "%EditFile%"
Return
F4MiniMenu (Forum) - Open selected file(s) from TC in defined editor(s) - A (minimalistic) clone of F4Menu
Source at GitHub (AutoHotkey). TCSyncComments (copy file comments)
User avatar
eugensyl
Power Member
Power Member
Posts: 564
Joined: 2004-06-03, 18:27 UTC
Location: România
Contact:

Post by *eugensyl »

AntonDudarenko wrote:It's an amazing situation!
Author STILL did not say anything!
Is it hard of not hard to implement - does he agree or disagree - and why....

I am still voting for quickest implementation of this feature in the nearest beta of TC.
This is an false problem. AppLoader solve this problem very well.
I do not agree more buttons in search windows without a real improvement.
My Best Wishes,

Eugen
User avatar
AntonyD
Power Member
Power Member
Posts: 1665
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Post by *AntonyD »

2eugensyl
you've made a false post ;)
because using your logic - there are no any problems related to any SW installed on my comp - because always somewhere I can find an appropriate 3party program which will do the same like my one - but only w/o any problems....
But it's a real world. And I am trying to use Occam's razor - and not to have too much programs - if only one can do all ....
SO - adding the ability to use F4 key in TС - is MUCH more effective and logical in comparing with your suggestion - to use some 3party program which probably can or can't to do ALL which I want to do....
#146217 personal license
User avatar
eugensyl
Power Member
Power Member
Posts: 564
Joined: 2004-06-03, 18:27 UTC
Location: România
Contact:

Post by *eugensyl »

AntonDudarenko wrote:2eugensyl
you've made a false post ;)
because using your logic - there are no any problems related to any SW installed on my comp - because always somewhere I can find an appropriate 3party program which will do the same like my one - but only w/o any problems....
But it's a real world. And I am trying to use Occam's razor - and not to have too much programs - if only one can do all ....
SO - adding the ability to use F4 key in TС - is MUCH more effective and logical in comparing with your suggestion - to use some 3party program which probably can or can't to do ALL which I want to do....
So, don't be angry.
I told you as I had the same problem and Apploader solve me all kind of problems like this. Also combined with internal associations. Mr. Ghisler is very prudent. Any new add in his application must be very sure. If I must admire only one quality of TC this is the one: standalone without any plugins work like a charm. This is because he make a lot of tests and there where are many options and some are (possible) dangerous, he prefer to keep code simple and unbreakable.
Since version 3.02 personal I have made a lot of suggestions but not all pass those tests. This is not a mistake. He keep his code clean, useful and less dangerous he can.

On the other hand, try Synminus, synplus or the new Syn2 plugins and it's very possible to edit directly your file from the view state (F3), even in search results windows. So for me is not necessary F4 button. Into file list window, provided by search or not you can use F4 and F4Menu which is brilliant.

Finally I suggest you when you want something keep calm and make us understanding your request. All we think different and what for you is important for me maybe is less, and vice-versa. Certainty, here are few 'dinosaurus' in TC world who can give you the most appropriate advices. If you know how to ask...
My Best Wishes,

Eugen
Post Reply