+TC8.51b4: problem with icons

Bug reports will be moved here when the described bug has been fixed

Moderators: Stefan2, white, sheep, Hacker

Skif_off
Member
Member
Posts: 114
Joined: 2013-09-30, 13:13 UTC

+TC8.51b4: problem with icons

Post by *Skif_off » 2014-03-19, 22:18 UTC

Don't display all icons for the all registered files. For example: http://rghost.ru/53193360/image.png
If I click on the file, it will display the correct icon. Or go to the directory again.
And directory Windows looks like a shared folder http://rghost.ru/53192433/image.png
I tried to change options in Configuration/Icons: nothing has changed.

Win7x64

User avatar
Flint
Power Member
Power Member
Posts: 3168
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2014-03-19, 22:34 UTC

Confirm both problems in 8.51β4 x64.

In 32-bit version I could reproduce only the "shared Windows". With the "unregistered icons" situation is a bit different: icons for those files which looked "unregistered" in x64, at first do look "unregistered" in 32-bit version as well, but very quickly (less than 0,5 sec) their icons are redrawn and become normal. The other icons in the same dir (those which looked normal in x64) look normal as well in 32-bit from the very beginning (well, maybe they are redrawn too, but then it's done so quickly I cannot notice).
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21a / Win7 x64 SP1, Win10 x64

a_flying_visit
Junior Member
Junior Member
Posts: 16
Joined: 2012-07-13, 19:27 UTC

Post by *a_flying_visit » 2014-03-20, 09:07 UTC

Confirm. TCb4 x64, Windows 7.

krasusczak
Senior Member
Senior Member
Posts: 259
Joined: 2011-09-23, 10:35 UTC

Post by *krasusczak » 2014-03-20, 10:10 UTC

Maybe this have something relate with your rights for this files?

User avatar
Flint
Power Member
Power Member
Posts: 3168
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2014-03-20, 10:22 UTC

krasusczak
I suppose, it's just side-effect of the following changes:
19.03.14 Added: Also load per extension icons in a (separate) background thread to avoid slowdowns when scrolling (e.g. due to Windows Defender) (32/64)
14.03.14 Added: Use NetShareEnum to get list of all shared folders (if user has admin rights) to speed up loading of shared folder icons (32/64)
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21a / Win7 x64 SP1, Win10 x64

User avatar
Flint
Power Member
Power Member
Posts: 3168
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2014-03-20, 14:25 UTC

Additional information from another user on the Russian forum:

On WinXP the icons are not redrawn at all (tested with original TC icons and with an external DLL):
http://s1.directupload.net/images/140320/6luu28lk.png
http://s14.directupload.net/images/140320/jnzdu9ce.png
The Windows directory is NOT displayed as shared.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21a / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 37410
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2014-03-20, 16:31 UTC

Skif_off wrote:Don't display all icons for the all registered files.
This seems to happen only immediately after TC starts, and only in the right panel - can you confirm it?
Skif_off wrote:And directory Windows looks like a shared folder
NetShareEnum does report the Windows directory as shared - seems to be some special administrative share not visible to users. I will try to find out what is going on.
Flint wrote:On WinXP the icons are not redrawn at all
Thanks for the screenshots - the problem isn't Windows XP, but the icon size 32x32 - that doesn't seem to work. I will check it.
Author of Total Commander
http://www.ghisler.com

Skif_off
Member
Member
Posts: 114
Joined: 2013-09-30, 13:13 UTC

Post by *Skif_off » 2014-03-20, 17:02 UTC

ghisler(Author) wrote:This seems to happen only immediately after TC starts, and only in the right panel - can you confirm it?
No, all icons appear only if I go to the directory again or after scrolling (if possible), or if I carefully click on each file without icons, or after call cm_Rereadsource, or if I click on any file in the opposite panel.

User avatar
Flint
Power Member
Power Member
Posts: 3168
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2014-03-20, 18:55 UTC

ghisler(Author) wrote:
Skif_off wrote:Don't display all icons for the all registered files.
This seems to happen only immediately after TC starts, and only in the right panel - can you confirm it?
No, I've got this behavior also in the left panel, and not only after TC starts, but while navigating directories and switching between tabs (again, both in left and right panels).
ghisler(Author) wrote:Thanks for the screenshots - the problem isn't Windows XP, but the icon size 32x32 - that doesn't seem to work.
Seems to be it. In the meantime another user who uses 16x16 icons, reported that on WinXP he has the same behavior with the "unregistered icons" that I observed in Win7.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21a / Win7 x64 SP1, Win10 x64

Sob
Power Member
Power Member
Posts: 908
Joined: 2005-01-19, 17:33 UTC

Post by *Sob » 2014-03-20, 20:24 UTC

ghisler(Author) wrote:NetShareEnum does report the Windows directory as shared - seems to be some special administrative share not visible to users.
It's \\server\admin$

-

I just spent few minutes going though different directories, trying to find some pattern for this, but it seems completely random. There's about 1 in 20 chance that when I enter new directory, some icons will be missing. When the file line gets redrawn (when I click on it, or if I just switch from TC to another program, while still keeping TC's panel visible), icon appears. It's not related to Windows theme, it happens with both Classic and Aero (Windows 7). It happens also with clean ini.

Could it perhaps be some timing problem, i.e. icon extraction in background thread being too fast and returning result before TC is ready for it? Because when it happens that some files of same type do have icons and some don't (e.g. in directory full of jpegs), missing icons are always those at the beginning.

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 37410
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2014-03-21, 17:27 UTC

After checking the code, I found the reason why it doesn't work in 64-bit version: I defined the Windows message incorrectly:
wm_refreshiconbyext=221;
instead of
wm_refreshiconbyext=wm_user+221;

Unfortunately Lazarus filters out all Windows messages below wm_user, so Total Commander 64-bit never gets the notifications that the icons have been extracted and can be displayed! Therefore they only show up when you move the text cursor.

I will fix it in beta 5.
Author of Total Commander
http://www.ghisler.com

User avatar
Tianuchka
Junior Member
Junior Member
Posts: 6
Joined: 2012-12-14, 10:19 UTC

WIN XP 32 SP3 RUS TC 8.51B4 Icons Problem

Post by *Tianuchka » 2014-03-22, 17:01 UTC


User avatar
karlchen
Power Member
Power Member
Posts: 4553
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen » 2014-03-22, 20:52 UTC

ghisler(Author) wrote:NetShareEnum does report the Windows directory as shared - seems to be some special administrative share not visible to users. I will try to find out what is going on.
It is the administrative Admin$ share. :wink:
You can make administrative networkshares visible in T.C. and then navigate to \\localhost. You will see C$, D$, E$ etc depending on how many drives your machine has got and Admin$.
Last edited by karlchen on 2014-03-22, 20:57 UTC, edited 1 time in total.
Linux Mint 18.1 64-bit Cinnamon Desktop, Total Commander 9.22a 64-bit
Ubuntu 18.04.2 32-bit Mate Desktop, Total Commander 9.22a 32-bit
Windows? - 1 window in every room

User avatar
karlchen
Power Member
Power Member
Posts: 4553
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Re: WIN XP 32 SP3 RUS TC 8.51B4 Icons Problem

Post by *karlchen » 2014-03-22, 20:54 UTC

Tianuchka wrote:I've got the same Icons problem on WIN XP 32 SP3 RUS.
[img]http://img-fotki.yandex.ru/get/9825/18527241.0/0_c9033_364e5cf3_XXXL.jpg[/img]
Yes. A few posts above Flint had reported so for WinXP. :wink:
Linux Mint 18.1 64-bit Cinnamon Desktop, Total Commander 9.22a 64-bit
Ubuntu 18.04.2 32-bit Mate Desktop, Total Commander 9.22a 32-bit
Windows? - 1 window in every room

User avatar
Flint
Power Member
Power Member
Posts: 3168
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Post by *Flint » 2014-03-26, 16:54 UTC

8.51β5, both issues seem to be fixed. 32x32 icons are displayed correctly as well.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.21a / Win7 x64 SP1, Win10 x64

Post Reply