Solved [TC9b2] cm_ReloadBarIcons issues

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Solved [TC9b2] cm_ReloadBarIcons issues

Post by *petermad »

When using cm_ReloadBarIcons and there are tempory bars loaded, for example subbars, then it is not the current button bars that are updated but the Main (default) button bars (horizontal and vertical) that are updated, which I find unexpected.

There is no description of cm_ReloadBarIcons in history.txt - so it is unknown if this is an intended behaviour.
Last edited by petermad on 2021-05-30, 15:35 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50864
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

That's indeed not intentional, thanks!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed fixed in TC9b3

But the icons in the Main menu are still using wciconex.dll if present - no matter what icon set I choose.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50864
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, when user has installed wciconex.dll, it takes precedence over all other icon settings. Should I change it? If yes, how?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

No, what I experience is that if I change to wcmicon2.dll via the new Icon library dialog, then the icons in the buttonbar is using this wcmicon2.dll while it is only the icons in the menu that is continuing using wciconex.dll.

Expected behaviour: only use wciconex.dll (if present) if default wcmicons.dll is selected.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Alternative icon dll if chiosen, is still not used for the Menu in TC9b4
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50864
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

wciconex.dll is now ignored when user has chosen different icon library than wcmicons.dll!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2ghisler(Author)
wciconex.dll is now ignored when user has chosen different icon library than wcmicons.dll!
That is not what I See. Here in TC9b4 wciconex.dll is still used for the Menu when I use another icon library than wcmicons.dll. If wciconex.dll is not present, the chosen icon library is used for both buttonbar and menu.

Also if wciconex.dll and wciconex.inc i present, then wciconex.inc is no longer used in the Menu if wcmicons.dll loaded, but it is used for any other icon library.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed that icons are now also set in the menu - also when wciconex.dll is present in TC9b5.

wciconex.inc is now only used if 1: wcmicons.dll is chosen - as expected.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply